chenboat commented on code in PR #12744:
URL: https://github.com/apache/pinot/pull/12744#discussion_r1558152978
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/mutable/MutableIndex.java:
##########
@@ -60,4 +60,12 @@ public interface MutableIndex extends IndexReader {
* @param docId The document id of the given row. A non-negative value.
*/
void add(@Nonnull Object[] values, @Nullable int[] dictIds, int docId);
+
+ /**
+ * Commits the mutable index artifacts to disk. This is used in preparation
for realtime segment conversion.
+ * commit() should perform any required actions before using mutable segment
artifacts to optimize immutable
Review Comment:
Comments in line 65-66 seem to be self-conflicting: commit to disk is just
one possible action? the implementation can actually choose other action for
preparation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
