gortiz commented on code in PR #12704:
URL: https://github.com/apache/pinot/pull/12704#discussion_r1565313954
##########
pinot-broker/src/test/java/org/apache/pinot/broker/querylog/QueryLoggerTest.java:
##########
@@ -259,11 +259,9 @@ private QueryLogger.QueryLogParams generateParams(boolean
isGroupLimitHit, int n
response.setExceptions(
IntStream.range(0, numExceptions)
.mapToObj(i -> new
ProcessingException()).collect(Collectors.toList()));
- response.setOfflineTotalCpuTimeNs(14);
Review Comment:
Yes, I've removed these `setOflineTotalCpuTimeNs` and
`setRealtimeTotalCpuTimeNs` from `BrokerResponseNative`. In production code
they are always set as `threadCpuTimeNs + systemActivitiesCpuTimeNs +
responseSerializationCpuTimeNs`, so it looks error prone to have a setter (like
the one we used here). Instead we never set the value of the total and always
derive it from its parts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
