gortiz commented on code in PR #12704: URL: https://github.com/apache/pinot/pull/12704#discussion_r1565395943
########## pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/channel/MailboxContentObserver.java: ########## @@ -62,22 +58,9 @@ public void onNext(MailboxContent mailboxContent) { _mailbox = _mailboxService.getReceivingMailbox(mailboxId); } try { - TransferableBlock block; - DataBlock dataBlock = DataBlockUtils.getDataBlock(mailboxContent.getPayload().asReadOnlyByteBuffer()); - if (dataBlock instanceof MetadataBlock) { - Map<Integer, String> exceptions = dataBlock.getExceptions(); - if (exceptions.isEmpty()) { - block = TransferableBlockUtils.getEndOfStreamTransferableBlock(((MetadataBlock) dataBlock).getStats()); - } else { - _mailbox.setErrorBlock(TransferableBlockUtils.getErrorTransferableBlock(exceptions)); - return; - } - } else { - block = new TransferableBlock(dataBlock); - } - Review Comment: This code has been moved to `ReceivingMailbox.offerRaw` in order to be able to capture the stats there. Also, I think the responsibility of doing this should be in ReceivingMailbox and not in the pipeline itself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org