Jackie-Jiang commented on code in PR #12993:
URL: https://github.com/apache/pinot/pull/12993#discussion_r1580255906
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/window/WindowFunction.java:
##########
@@ -18,14 +18,75 @@
*/
package org.apache.pinot.query.runtime.operator.window;
+import com.google.common.collect.ImmutableMap;
+import java.lang.reflect.Constructor;
+import java.lang.reflect.InvocationTargetException;
import java.util.List;
+import java.util.Map;
+import org.apache.commons.collections.CollectionUtils;
+import org.apache.pinot.common.utils.DataSchema;
+import org.apache.pinot.query.planner.logical.RexExpression;
+import org.apache.pinot.query.runtime.operator.WindowAggregateOperator;
+import org.apache.pinot.query.runtime.operator.utils.AggregationUtils;
+import
org.apache.pinot.query.runtime.operator.window.aggregate.AggregateWindowFunction;
+import
org.apache.pinot.query.runtime.operator.window.range.RangeWindowFunction;
+import
org.apache.pinot.query.runtime.operator.window.value.ValueWindowFunction;
-public interface WindowFunction {
+/**
+ * This class provides the basic structure for window functions. It provides
the batch row processing API:
+ * processRows(List<Object[]> rows) which processes a batch of rows at a time.
+ *
+ */
+public abstract class WindowFunction extends AggregationUtils.Accumulator {
Review Comment:
Suggest adding a `WindowFunctionFactory` if you want to make it pluggable,
maybe following the same way of how `TransformFunction` is handle
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/window/WindowFunction.java:
##########
@@ -18,14 +18,75 @@
*/
package org.apache.pinot.query.runtime.operator.window;
+import com.google.common.collect.ImmutableMap;
+import java.lang.reflect.Constructor;
+import java.lang.reflect.InvocationTargetException;
import java.util.List;
+import java.util.Map;
+import org.apache.commons.collections.CollectionUtils;
+import org.apache.pinot.common.utils.DataSchema;
+import org.apache.pinot.query.planner.logical.RexExpression;
+import org.apache.pinot.query.runtime.operator.WindowAggregateOperator;
+import org.apache.pinot.query.runtime.operator.utils.AggregationUtils;
+import
org.apache.pinot.query.runtime.operator.window.aggregate.AggregateWindowFunction;
+import
org.apache.pinot.query.runtime.operator.window.range.RangeWindowFunction;
+import
org.apache.pinot.query.runtime.operator.window.value.ValueWindowFunction;
-public interface WindowFunction {
+/**
+ * This class provides the basic structure for window functions. It provides
the batch row processing API:
+ * processRows(List<Object[]> rows) which processes a batch of rows at a time.
+ *
+ */
+public abstract class WindowFunction extends AggregationUtils.Accumulator {
Review Comment:
Also consider making this a separate PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
