xiangfu0 commented on PR #12993: URL: https://github.com/apache/pinot/pull/12993#issuecomment-2090071828
> Can you add some more comments in the PR describing about the different types of window functions extracted? What is their difference? Following how presto models the WindowFunction with one `WindowFunction` interface, then 3 types: 1. AggregateWindowFunction: this is one function try to handle all the existing aggregation functions 2. Abstract `RankingWindowFunction`, this is for all the ranking functions. Here are all the implements: `CumulativeDistributionFunction`, `CustomRank`, `DenseRankFunction`, `NTileFunction`, `PercentRankFunction`, `RankFunction`, `RowNumberFunction` 3. Abstract `ValueWindowFunction`, this is for all the row position based functions. Here are all the implements: `FirstValueFunction`, `LagFunction`, `LastValueFunction`, `LeadFunction`, `NthValueFunction` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
