jadami10 commented on code in PR #11907:
URL: https://github.com/apache/pinot/pull/11907#discussion_r1605541235
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/recordtransformer/TimeValidationTransformer.java:
##########
@@ -103,6 +103,7 @@ public GenericRow transform(GenericRow record) {
if (_continueOnError) {
LOGGER.debug(errorMessage);
record.putValue(_timeColumnName, null);
+ record.putValue(GenericRow.INCOMPLETE_RECORD_KEY, true);
Review Comment:
is this actually causing the even to be skipped? I tried tracing this, and I
can't find anywhere this causes skipping
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
