jadami10 commented on code in PR #11907:
URL: https://github.com/apache/pinot/pull/11907#discussion_r1609061742
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/recordtransformer/TimeValidationTransformer.java:
##########
@@ -103,6 +103,7 @@ public GenericRow transform(GenericRow record) {
if (_continueOnError) {
LOGGER.debug(errorMessage);
record.putValue(_timeColumnName, null);
+ record.putValue(GenericRow.INCOMPLETE_RECORD_KEY, true);
Review Comment:
ok that's what I thought. Might be worth updating the PR description.
This part seems misleading
```After this PR, if the primary time column contains and invalid value, the
row will be skipped and ServerMeter.INCOMPLETE_REALTIME_ROWS_CONSUMED will be
increased.```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
