klsince opened a new pull request, #13415: URL: https://github.com/apache/pinot/pull/13415
The upsert partition manager doesn't necessarily track all segments belonging to a table partition, e.g. segments out of metadata TTL are not tracked. So after getting validDocIds bitmaps from upsert partition managers, we should double check if any segment doesn't get its bitmap. For segments still missing their validDocIds bitmaps, we use those tracked by the segment objects themselves, as bitmaps from those segments are not updated since loaded anyway, otherwise, they'd be tracked in one partition mgr. Added a query option `skipUpsertView` to help debug this feature, and bypass it in case. Refactored the code to separate the locking logic for different consistency modes more clearly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
