tibrewalpratik17 commented on code in PR #13415:
URL: https://github.com/apache/pinot/pull/13415#discussion_r1643411561
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/UpsertUtils.java:
##########
@@ -38,6 +39,15 @@ public class UpsertUtils {
private UpsertUtils() {
}
+ public static MutableRoaringBitmap
getQueryableDocIdsSnapshotFromSegment(IndexSegment segment) {
+ ThreadSafeMutableRoaringBitmap queryableDocIds =
segment.getQueryableDocIds();
+ if (queryableDocIds != null) {
+ return queryableDocIds.getMutableRoaringBitmap();
+ }
+ ThreadSafeMutableRoaringBitmap validDocIds = segment.getValidDocIds();
+ return validDocIds != null ? validDocIds.getMutableRoaringBitmap() : null;
Review Comment:
nit: since we are returning null here can we add `@Nullable` annotation to
`setQueryableDocIdsSnapshot` parameter in SegmentContext class?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
