tibrewalpratik17 commented on code in PR #13697:
URL: https://github.com/apache/pinot/pull/13697#discussion_r1712200400
##########
pinot-common/src/test/java/org/apache/pinot/common/metrics/AbstractMetricsTest.java:
##########
@@ -48,4 +49,63 @@ public void testAddOrUpdateGauge() {
controllerMetrics.removeGauge(metricName);
Assert.assertTrue(controllerMetrics.getMetricsRegistry().allMetrics().isEmpty());
}
+
+ @Test
+ public void testConcurrentGaugeUpdates() throws InterruptedException {
Review Comment:
Since we are not doing concurrent updates, can you rename the method as
well. Something like: `testMultipleUpdatesToGauge`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
