tibrewalpratik17 commented on PR #13697:
URL: https://github.com/apache/pinot/pull/13697#issuecomment-2283669229

   > Is it this one? . I think you can also see that as well right ? 🤔 Or am I 
missing something here
   
   Hmm not sure if this one is correct. When clicking on the CodeCov report, it 
shows a lot of files changed in the list which are not touched in this PR.
   <img width="1633" alt="Screenshot 2024-08-12 at 4 30 49 PM" 
src="https://github.com/user-attachments/assets/e55c91ae-2121-44a7-9b07-776356d7543e";>
   
   Anyways this is not a must, just a good-to-have thing on the PR description 
if we can show increase in coverage of `AbstractMetrics` class. 
   
   Left one minor suggestion, rest LGTM! 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to