shounakmk219 commented on code in PR #13803:
URL: https://github.com/apache/pinot/pull/13803#discussion_r1714661141
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java:
##########
@@ -1671,12 +1694,20 @@ public PauseStatus resumeConsumption(String
tableNameWithType, @Nullable String
+ "Consuming segments are being created. Use /pauseStatus endpoint in
a few moments to double check.");
}
- private IdealState updatePauseStatusInIdealState(String tableNameWithType,
boolean pause) {
+ private IdealState updatePauseStatusInIdealState(String tableNameWithType,
boolean pause, String comment) {
IdealState updatedIdealState = HelixHelper.updateIdealState(_helixManager,
tableNameWithType, idealState -> {
ZNRecord znRecord = idealState.getRecord();
+ TablePauseStatus pauseStatus;
+ if (pause) {
+ pauseStatus = new
TablePauseStatus(TablePauseStatus.ReasonCode.ADMINISTRATIVE, comment);
+ } else {
+ pauseStatus = new TablePauseStatus();
+ pauseStatus.setPaused(false);
Review Comment:
Makes sense, will do the required changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
