shounakmk219 commented on code in PR #13803:
URL: https://github.com/apache/pinot/pull/13803#discussion_r1716288662
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PauseStatus.java:
##########
@@ -22,20 +22,27 @@
import com.fasterxml.jackson.annotation.JsonInclude;
import com.fasterxml.jackson.annotation.JsonProperty;
import java.util.Set;
+import org.apache.pinot.spi.config.table.TablePauseStatus;
@JsonInclude(JsonInclude.Include.NON_NULL)
public class PauseStatus {
private boolean _pauseFlag;
private Set<String> _consumingSegments;
+ private TablePauseStatus.ReasonCode _reasonCode;
+ private String _comment;
private String _description;
Review Comment:
1. If either works, can we keep `description` in order to not break any
existing usages?
2. Will add
3. Does it make sense to return the consuming segment count as that would be
a useful info to track the pause/unpause progress (0 or total # partitions
indicating respective operation completion) on the table?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
