rfscholte commented on code in PR #13969:
URL: https://github.com/apache/pinot/pull/13969#discussion_r1751642270
##########
pinot-common/pom.xml:
##########
@@ -372,5 +337,45 @@
<shade.phase.prop>package</shade.phase.prop>
</properties>
</profile>
+ <profile>
+ <!-- These plugins don't care about unchanged (re)sources and will
always generate.
+ This causes the maven-compiler-plugin to detect changes and always
recompile the Java sources
+ If there are changes in src/main/codegen, either run mvn clean or mvn -P
sqlparser
+ -->
+ <id>sqlparser</id>
+ <activation>
+ <file>
+ <missing>target/generated-sources/fmpp/javacc/Parser.jj</missing>
+ </file>
+ </activation>
+ <build>
+ <plugins>
+ <!-- "Plugs in" the Calcite's Parser.jj with the variables present
in config.fmpp. These contain the custom rules
+ as well as the class to which the custom implementation will get
generated -->
+ <plugin>
+ <groupId>com.googlecode.fmpp-maven-plugin</groupId>
+ <artifactId>fmpp-maven-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>generate-fmpp-sources</id>
+ <phase>generate-sources</phase>
+ <goals>
+ <goal>generate</goal>
+ </goals>
+ <configuration>
+ <cfgFile>src/main/codegen/config.fmpp</cfgFile>
+
<templateDirectory>src/main/codegen/templates</templateDirectory>
+
<outputDirectory>${project.build.directory}/generated-sources/fmpp</outputDirectory>
+ </configuration>
+ </execution>
+ </executions>
+ </plugin>
+ <plugin> <!-- Enforce right order -->
Review Comment:
yes, will adjust the comment. They are bound to the same phase and without
mentioning it, javacc is executed first (i guess main configuration wins from
profile configuration)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
