gortiz commented on code in PR #13969:
URL: https://github.com/apache/pinot/pull/13969#discussion_r1751681052
##########
pinot-common/pom.xml:
##########
@@ -372,5 +337,45 @@
<shade.phase.prop>package</shade.phase.prop>
</properties>
</profile>
+ <profile>
+ <!-- These plugins don't care about unchanged (re)sources and will
always generate.
+ This causes the maven-compiler-plugin to detect changes and always
recompile the Java sources
+ If there are changes in src/main/codegen, either run mvn clean or mvn -P
sqlparser
+ -->
+ <id>sqlparser</id>
+ <activation>
+ <file>
+ <missing>target/generated-sources/fmpp/javacc/Parser.jj</missing>
+ </file>
Review Comment:
Can you add a comment in this activation to inform about the `mvn clean
verify` limitation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
