deemoliu commented on code in PR #13790:
URL: https://github.com/apache/pinot/pull/13790#discussion_r1764227690
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/TableConfigUtils.java:
##########
@@ -173,15 +173,18 @@ public static void validate(TableConfig tableConfig,
@Nullable Schema schema, @N
// Only allow realtime tables with non-null stream.type and LLC
consumer.type
if (tableConfig.getTableType() == TableType.REALTIME) {
- Map<String, String> streamConfigMap =
IngestionConfigUtils.getStreamConfigMap(tableConfig);
+ List<Map<String, String>> streamConfigMaps =
IngestionConfigUtils.getStreamConfigMaps(tableConfig);
Review Comment:
let's add a validation to avoid upsert table creating with multiple topics
for now. One of the most important reason is that upsert table requires same
primary keys to be distributed to the same host. it will be a bit complex to
validate whether all source topics are partitioned equally (partition key,
partition counts, parttion algorithms).
there are other potential concerns including race condition consumption
during reload, rebalance, pause ingestion etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
