deemoliu commented on code in PR #13790:
URL: https://github.com/apache/pinot/pull/13790#discussion_r1764232316
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java:
##########
@@ -774,15 +778,32 @@ Set<Integer> getPartitionIds(StreamConfig streamConfig)
}
}
+ @VisibleForTesting
+ Set<Integer> getPartitionIds(List<StreamConfig> streamConfigs)
+ throws Exception {
+ Set<Integer> partitionIds = new HashSet<>();
+ for (int i = 0; i < streamConfigs.size(); i++) {
+ final int index = i;
+ try {
+
partitionIds.addAll(getPartitionIds(streamConfigs.get(index)).stream().map(
Review Comment:
can you please elaborate on why we don't need to maintain orders for
partitionIds? we use list for streamConfigs and use unordered set to store
partitionids?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
