yashmayya commented on code in PR #14249:
URL: https://github.com/apache/pinot/pull/14249#discussion_r1806083255
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/window/aggregate/AggregateWindowFunction.java:
##########
@@ -49,54 +50,198 @@ public AggregateWindowFunction(RexExpression.FunctionCall
aggCall, DataSchema in
@Override
public final List<Object> processRows(List<Object[]> rows) {
- if (_partitionByOnly) {
- return processPartitionOnlyRows(rows);
Review Comment:
Also, the optimization is still applied to windows without `ORDER BY`, since
Calcite forces the window frame to be `RANGE BETWEEN UNBOUNDED PRECEDING AND
UNBOUNDED FOLLOWING` for such windows (and we do avoid the per row key
computation for `RANGE/ROWS BETWEEN UNBOUNDED PRECEDING AND UNBOUNDED
FOLLOWING`). So the only other case is where the partition keys and order by
keys are identical.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
