vrajat commented on code in PR #14249:
URL: https://github.com/apache/pinot/pull/14249#discussion_r1811081362
##########
pinot-query-planner/src/test/java/org/apache/pinot/query/QueryCompilationTest.java:
##########
@@ -392,6 +394,85 @@ public void testDuplicateWithAlias() {
assertTrue(e.getCause().getMessage().contains("Duplicate alias in WITH:
'tmp'"));
}
+ @Test
+ public void testWindowFunctionsWithCustomWindowFrame() {
+ String queryWithDefaultWindow = "SELECT col1, col2, RANK() OVER (PARTITION
BY col1 ORDER BY col2) FROM a";
+ _queryEnvironment.planQuery(queryWithDefaultWindow);
Review Comment:
Is this a complete test for a query ? The expectation is that planning wont
throw an exception ?
Also the same test contains queries that will throw a parse exception ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
