gortiz commented on code in PR #14384:
URL: https://github.com/apache/pinot/pull/14384#discussion_r1828960237
##########
pinot-common/src/main/java/org/apache/pinot/common/response/broker/BrokerResponseNative.java:
##########
@@ -485,4 +488,15 @@ public Map<String, String> getTraceInfo() {
public void setTraceInfo(Map<String, String> traceInfo) {
_traceInfo = traceInfo;
}
+
+ @Override
+ public void setTablesQueried(@NotNull Set<String> tablesQueried) {
+ _tablesQueried = tablesQueried;
+ }
+
+ @Override
+ @NotNull
Review Comment:
I would say the convention is to mandatory mark nullable
fields/methods/parameters and to _recommend_ to do not mark not nullable. The
later is mainly to do avoid _annotatiomania_, but it is fine for me in
situations we want to empathize something is not null.
Probably in this case that is not necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
