vrajat commented on code in PR #14384:
URL: https://github.com/apache/pinot/pull/14384#discussion_r1828972766
##########
pinot-common/src/main/java/org/apache/pinot/common/response/broker/BrokerResponseNative.java:
##########
@@ -485,4 +488,15 @@ public Map<String, String> getTraceInfo() {
public void setTraceInfo(Map<String, String> traceInfo) {
_traceInfo = traceInfo;
}
+
+ @Override
+ public void setTablesQueried(@NotNull Set<String> tablesQueried) {
+ _tablesQueried = tablesQueried;
+ }
+
+ @Override
+ @NotNull
Review Comment:
> assume that non annotated elements are never nullable.
I haven't seen this to be true. I use this field in #14110. That has no
annotation but checks for null.
The choice is between `@NotNull` or checks for `if (object == null) {...}`.
##########
pinot-common/src/main/java/org/apache/pinot/common/response/broker/BrokerResponseNative.java:
##########
@@ -485,4 +488,15 @@ public Map<String, String> getTraceInfo() {
public void setTraceInfo(Map<String, String> traceInfo) {
_traceInfo = traceInfo;
}
+
+ @Override
+ public void setTablesQueried(@NotNull Set<String> tablesQueried) {
+ _tablesQueried = tablesQueried;
+ }
+
+ @Override
+ @NotNull
Review Comment:
> assume that non annotated elements are never nullable.
I haven't seen this to be true. I use this field in #14110. That has no
annotation but checks for null.
The choice is between `@NotNull` or checks for `if (object == null) {...}`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
