chunxiaozheng commented on PR #14398: URL: https://github.com/apache/pinot/pull/14398#issuecomment-2466062102
> It looks like at runtime we sometimes use longs to implement timestamps, date and time, but some other times we use LocalDate and LocalTime. That seems a bit odd. I don't know if we are doing the same with Timestamp right now in master, we would need to study if this is what we want Thanks! In fact, I added these new data types based on the implementation of `TIMESTAMP` data type in Pinot.🤔 From my understanding, these time related type use the `long`type in storage, and when queried through DQL, they will be converted to the corresponding Java type, such as `java.sql.Timestamp`, `java.time.LocalDateTime`, `java.time.LocalDate` and `java.time.LocalTime`. Therefore, this will include many conversions between these Java types and long types -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
