bziobrowski commented on code in PR #14398:
URL: https://github.com/apache/pinot/pull/14398#discussion_r1842442129
##########
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/FieldConfig.java:
##########
@@ -127,7 +127,7 @@ public enum EncodingType {
// If null, there won't be any index
public enum IndexType {
- INVERTED, SORTED, TEXT, FST, H3, JSON, TIMESTAMP, VECTOR, RANGE
+ INVERTED, SORTED, TEXT, FST, H3, JSON, TIMESTAMP, VECTOR, RANGE,
TIMESTAMP_NTZ, DATE, TIME
Review Comment:
Does the PR really add 3 new index types?
##########
pinot-spi/src/main/java/org/apache/pinot/spi/data/FieldSpec.java:
##########
@@ -519,6 +543,9 @@ public enum DataType {
BIG_DECIMAL(true, true),
BOOLEAN(INT, false, true),
TIMESTAMP(LONG, false, true),
Review Comment:
Is there a reason for DATE to use 8 bytes ? What granularity do you plan to
use for TIME ? If it's millis then 4 bytes should be enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
