Jackie-Jiang commented on code in PR #14485:
URL: https://github.com/apache/pinot/pull/14485#discussion_r1847467851
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/segment/SegmentSizeBasedFlushThresholdUpdater.java:
##########
@@ -50,5 +57,9 @@ public synchronized void updateFlushThreshold(StreamConfig
streamConfig, Segment
_flushThresholdComputer.computeThreshold(streamConfig,
committingSegmentDescriptor, committingSegmentZKMetadata,
newSegmentZKMetadata.getSegmentName());
newSegmentZKMetadata.setSizeThresholdToFlushSegment(threshold);
+
+ _controllerMetrics.setOrUpdateTableGauge(_rawTableName,
ControllerGauge.NUM_ROWS_THRESHOLD, threshold);
Review Comment:
Do we want to log it under the raw name or real-time table name (with
suffix)? Seems most of the gauges are under the table name with suffix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
