sajjad-moradi commented on code in PR #14485:
URL: https://github.com/apache/pinot/pull/14485#discussion_r1847597415
##########
pinot-common/src/main/java/org/apache/pinot/common/metrics/ControllerGauge.java:
##########
@@ -165,6 +165,16 @@ public enum ControllerGauge implements
AbstractMetrics.Gauge {
TABLE_DISABLED("tableDisabled", false),
+ // A per-table metric that shows the number of rows we expect to consume for
the next segment of
+ // any partition in the realtime table. This metric is emitted from the
segment size based threshold
+ // computer.
+ NUM_ROWS_THRESHOLD("numRowsThreshold", false),
+
+ // The actual segment size for committing segments. These may be shorter
than expected when the administrator
+ // issues a force-commit, or zero when new partitions are detected in the
stream (since there is no completing
+ // segment when the partition is first detected).
+ COMMITTING_SEGMENT_SIZE("numRowsThreshold", false),
Review Comment:
Although `unit`, the first param, is not used anywhere in the code base,
let's not use "numRowsThreshold" to be consistent with other metrics.
##########
pinot-common/src/main/java/org/apache/pinot/common/metrics/ControllerGauge.java:
##########
@@ -165,6 +165,16 @@ public enum ControllerGauge implements
AbstractMetrics.Gauge {
TABLE_DISABLED("tableDisabled", false),
+ // A per-table metric that shows the number of rows we expect to consume for
the next segment of
+ // any partition in the realtime table. This metric is emitted from the
segment size based threshold
+ // computer.
+ NUM_ROWS_THRESHOLD("numRowsThreshold", false),
+
+ // The actual segment size for committing segments. These may be shorter
than expected when the administrator
+ // issues a force-commit, or zero when new partitions are detected in the
stream (since there is no completing
+ // segment when the partition is first detected).
+ COMMITTING_SEGMENT_SIZE("numRowsThreshold", false),
Review Comment:
Although `unit`, the first param, is not used anywhere in the code base,
let's not use "numRowsThreshold" to be consistent with other metrics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
