gortiz commented on code in PR #14479:
URL: https://github.com/apache/pinot/pull/14479#discussion_r1856751542
##########
pinot-segment-local/src/test/java/org/apache/pinot/segment/local/indexsegment/mutable/MutableSegmentImplTestUtils.java:
##########
@@ -82,22 +82,22 @@ public static MutableSegmentImpl
createMutableSegmentImpl(Schema schema, Set<Str
PartitionDedupMetadataManager partitionDedupMetadataManager) {
return createMutableSegmentImpl(schema, noDictionaryColumns,
varLengthDictionaryColumns, invertedIndexColumns,
Collections.emptyMap(), aggregateMetrics, nullHandlingEnabled,
upsertConfig, timeColumnName,
- partitionUpsertMetadataManager, dedupConfig,
partitionDedupMetadataManager, null, Collections.emptyList());
+ partitionUpsertMetadataManager, dedupConfig,
partitionDedupMetadataManager, null, Collections.emptyList(), false);
}
public static MutableSegmentImpl createMutableSegmentImpl(Schema schema,
Set<String> noDictionaryColumns,
Set<String> varLengthDictionaryColumns, Set<String> invertedIndexColumns,
Map<String, JsonIndexConfig> jsonIndexConfigs, ServerMetrics
serverMetrics) {
return createMutableSegmentImpl(schema, noDictionaryColumns,
varLengthDictionaryColumns, invertedIndexColumns,
- jsonIndexConfigs, false, true, null, null, null, null, null,
serverMetrics, Collections.emptyList());
+ jsonIndexConfigs, false, true, null, null, null, null, null,
serverMetrics, Collections.emptyList(), false);
}
public static MutableSegmentImpl createMutableSegmentImpl(Schema schema,
Set<String> noDictionaryColumns,
Set<String> varLengthDictionaryColumns, Set<String> invertedIndexColumns,
Map<String, JsonIndexConfig> jsonIndexConfigs, boolean aggregateMetrics,
boolean nullHandlingEnabled,
UpsertConfig upsertConfig, String timeColumnName,
PartitionUpsertMetadataManager partitionUpsertMetadataManager,
DedupConfig dedupConfig, PartitionDedupMetadataManager
partitionDedupMetadataManager, ServerMetrics serverMetrics,
- List<AggregationConfig> aggregationConfigs) {
+ List<AggregationConfig> aggregationConfigs, boolean
thresholdForColEnabled) {
Review Comment:
I would recommend to add an overload method where the new boolean is false.
That way you can reduce the number of changes in the PR but also keep backward
compatibility in case some other class (in another repo) is using this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
