Jackie-Jiang commented on code in PR #14479:
URL: https://github.com/apache/pinot/pull/14479#discussion_r1870393069
##########
pinot-segment-local/src/test/java/org/apache/pinot/segment/local/indexsegment/mutable/MutableSegmentImplTestUtils.java:
##########
@@ -98,6 +98,20 @@ public static MutableSegmentImpl
createMutableSegmentImpl(Schema schema, Set<Str
UpsertConfig upsertConfig, String timeColumnName,
PartitionUpsertMetadataManager partitionUpsertMetadataManager,
DedupConfig dedupConfig, PartitionDedupMetadataManager
partitionDedupMetadataManager, ServerMetrics serverMetrics,
List<AggregationConfig> aggregationConfigs) {
+ return createMutableSegmentImpl(schema, noDictionaryColumns,
+ varLengthDictionaryColumns, invertedIndexColumns,
+ jsonIndexConfigs, aggregateMetrics, nullHandlingEnabled,
+ upsertConfig, timeColumnName, partitionUpsertMetadataManager,
+ dedupConfig, partitionDedupMetadataManager, serverMetrics,
+ aggregationConfigs, false);
+ }
+
+ public static MutableSegmentImpl createMutableSegmentImpl(Schema schema,
Set<String> noDictionaryColumns,
Review Comment:
We can revert this since the flag is removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
