ankitsultana commented on code in PR #14477:
URL: https://github.com/apache/pinot/pull/14477#discussion_r1870284658


##########
pinot-core/src/main/java/org/apache/pinot/core/common/MinionConstants.java:
##########
@@ -199,4 +200,59 @@ public static class UpsertCompactionTask {
      */
     public static final String NUM_SEGMENTS_BATCH_PER_SERVER_REQUEST = 
"numSegmentsBatchPerServerRequest";
   }
+
+  public static class UpsertCompactMergeTask {

Review Comment:
   broad question: say we run both merge compaction and the segment refresh 
task for a table. How do we ensure that there aren't any race conditions, 
because it could be that the two tasks end up processing the same set of 
segments concurrently.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to