yashmayya commented on code in PR #14739:
URL: https://github.com/apache/pinot/pull/14739#discussion_r1901497664
##########
pinot-clients/pinot-jdbc-client/src/main/java/org/apache/pinot/client/utils/DateTimeUtils.java:
##########
@@ -34,8 +34,8 @@ public class DateTimeUtils {
private DateTimeUtils() {
}
Review Comment:
`"2020-12-01 "` can be handled by introducing a trim and `"2020-12-01 12"` /
`"2020-12-01 12:00"` could be handled by also making the `mm` / `ss` parts
optional in the `DateTimeFormatter` pattern. While SDF is able to parse
`"2020-13-01"`, it's actually pretty non-standard behavior because it gets
parsed into `2021-01-01` so I think it might be fine to drop support for that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
