gortiz commented on PR #14739: URL: https://github.com/apache/pinot/pull/14739#issuecomment-2569004073
an easy and correct solution would be to go back to the previous state where we were using `DateTimeFormatter` but instead of keeping one static instance shared by different threads, have one instance per thread by either allocating one on each call (which would be expensive but correct) or keeping one thread local instance (which would be faster but allocate more). I suggest to implement one of these two options to be sure we don't break backward compatibility in the driver, which is critical. In the future we should think about the possibility of sending timestamps as millis since epoch, which would be better for both sides (broker and client) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
