9aman commented on code in PR #14798:
URL: https://github.com/apache/pinot/pull/14798#discussion_r1917189209
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java:
##########
@@ -543,13 +555,22 @@ private void commitSegmentMetadataInternal(String
realtimeTableName,
SegmentZKMetadata committingSegmentZKMetadata =
updateCommittingSegmentMetadata(realtimeTableName,
committingSegmentDescriptor, isStartMetadata);
+ // Used to inject failure for testing. RealtimeSegmentValidationManager
should be able to fix the
+ // segment that encounter failure at this stage of commit protocol.
+
FailureInjectionUtils.injectFailure(FailureInjectionUtils.FAULT_BEFORE_NEW_SEGMENT_METADATA_CREATION,
Review Comment:
For now I have kept the current approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
