9aman commented on code in PR #14798:
URL: https://github.com/apache/pinot/pull/14798#discussion_r1917191824
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/FileUploadDownloadClient.java:
##########
@@ -968,26 +970,25 @@ public String uploadToSegmentStore(String uri)
* Used by controllers to send requests to servers: Controller periodic task
uses this endpoint to ask servers
* to upload committed llc segment to segment store if missing.
* @param uri The uri to ask servers to upload segment to segment store
- * @return {@link TableLLCSegmentUploadResponse} - segment download url,
crc, other metadata
+ * @return {@link SegmentZKMetadata} - segment download url, crc, other
metadata
* @throws URISyntaxException
* @throws IOException
* @throws HttpErrorStatusException
*/
- public TableLLCSegmentUploadResponse uploadLLCToSegmentStore(String uri)
+ public SegmentZKMetadata uploadLLCToSegmentStore(String uri)
Review Comment:
Have added a new APi. On the controller side I have ensured backward
compatibility by trying the previous endpoints as well in case the latest
endpoint for segment upload fails.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
