noob-se7en commented on code in PR #14828:
URL: https://github.com/apache/pinot/pull/14828#discussion_r1919836713
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##########
@@ -2249,9 +2249,31 @@ public boolean addNewForceCommitJob(String
tableNameWithType, String jobId, long
jobMetadata.put(CommonConstants.ControllerJob.SUBMISSION_TIME_MS,
Long.toString(jobSubmissionTimeMs));
jobMetadata.put(CommonConstants.ControllerJob.CONSUMING_SEGMENTS_FORCE_COMMITTED_LIST,
JsonUtils.objectToString(consumingSegmentsCommitted));
+
jobMetadata.put(CommonConstants.ControllerJob.CONSUMING_SEGMENTS_YET_TO_BE_COMMITTED_LIST,
+ JsonUtils.objectToString(consumingSegmentsCommitted));
return addControllerJobToZK(jobId, jobMetadata,
ControllerJobType.FORCE_COMMIT);
}
+ public void updateForceCommitJobMetadata(String forceCommitJobId,
Set<String> segmentsYetToBeCommitted,
+ Map<String, String> controllerJobZKMetadata) {
+ addControllerJobToZK(forceCommitJobId,
+ controllerJobZKMetadata, ControllerJobType.FORCE_COMMIT,
prevJobMetadata -> {
+ String existingSegmentsYetToBeCommittedString =
Review Comment:
Actually this method is only useful for a rare edge case when two async
forceCommitStatus APIs are running.
But we can remove this as it will save overhead for one extra parsing on
each API call.
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##########
@@ -2249,9 +2249,31 @@ public boolean addNewForceCommitJob(String
tableNameWithType, String jobId, long
jobMetadata.put(CommonConstants.ControllerJob.SUBMISSION_TIME_MS,
Long.toString(jobSubmissionTimeMs));
jobMetadata.put(CommonConstants.ControllerJob.CONSUMING_SEGMENTS_FORCE_COMMITTED_LIST,
JsonUtils.objectToString(consumingSegmentsCommitted));
+
jobMetadata.put(CommonConstants.ControllerJob.CONSUMING_SEGMENTS_YET_TO_BE_COMMITTED_LIST,
+ JsonUtils.objectToString(consumingSegmentsCommitted));
return addControllerJobToZK(jobId, jobMetadata,
ControllerJobType.FORCE_COMMIT);
}
+ public void updateForceCommitJobMetadata(String forceCommitJobId,
Set<String> segmentsYetToBeCommitted,
+ Map<String, String> controllerJobZKMetadata) {
+ addControllerJobToZK(forceCommitJobId,
+ controllerJobZKMetadata, ControllerJobType.FORCE_COMMIT,
prevJobMetadata -> {
+ String existingSegmentsYetToBeCommittedString =
Review Comment:
have removed this method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
