KKcorps commented on code in PR #14828:
URL: https://github.com/apache/pinot/pull/14828#discussion_r1919945880
##########
pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManagerTest.java:
##########
@@ -1247,6 +1248,33 @@ public void testGetPartitionIds()
Assert.assertEquals(partitionIds.size(), 2);
}
+ @Test
+ public void getSegmentsYetToBeCommitted() {
+ PinotHelixResourceManager mockHelixResourceManager =
mock(PinotHelixResourceManager.class);
+ FakePinotLLCRealtimeSegmentManager realtimeSegmentManager =
+ new FakePinotLLCRealtimeSegmentManager(mockHelixResourceManager);
+
+ SegmentZKMetadata mockSegmentZKMetadataDone =
mock(SegmentZKMetadata.class);
+ when(mockSegmentZKMetadataDone.getStatus()).thenReturn(Status.DONE);
+
+ SegmentZKMetadata mockSegmentZKMetadataUploaded =
mock(SegmentZKMetadata.class);
+
when(mockSegmentZKMetadataUploaded.getStatus()).thenReturn(Status.UPLOADED);
+
+ SegmentZKMetadata mockSegmentZKMetadataInProgress =
mock(SegmentZKMetadata.class);
+
when(mockSegmentZKMetadataInProgress.getStatus()).thenReturn(Status.IN_PROGRESS);
Review Comment:
also add one for Status.COMMITTING
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
