EndZhu commented on code in PR #14910:
URL: https://github.com/apache/pinot/pull/14910#discussion_r1927796115
##########
pinot-common/src/main/java/org/apache/pinot/common/assignment/InstancePartitionsUtils.java:
##########
@@ -59,13 +59,13 @@ public static String getInstancePartitionsName(String
tableName, String instance
/**
* Fetches the instance partitions from Helix property store if it exists,
or computes it for backward-compatibility.
*/
- public static InstancePartitions
fetchOrComputeInstancePartitions(HelixManager helixManager, TableConfig
tableConfig,
- InstancePartitionsType instancePartitionsType) {
+ public static InstancePartitions
fetchOrComputeInstancePartitionsForSegmentAssignment(HelixManager helixManager,
Review Comment:
Hi @Jackie-Jiang , I discussed this with @vvivekiyer and @jasperjiaguo
offline. We are doing this renaming because we think this function is currently
generic and can be called even for InstanceAssignment in the future, and we
might want to differentiate different use cases for future proof.
To avoid introducing any incompatible changes, maybe I can keep the current
`fetchOrComputeInstancePartitions` name and mark it as deprecated. cc
@jasperjiaguo @vvivekiyer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
