Jackie-Jiang commented on code in PR #14908:
URL: https://github.com/apache/pinot/pull/14908#discussion_r1929237003
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java:
##########
@@ -1974,6 +1975,22 @@ private Set<String> findConsumingSegments(IdealState
idealState) {
}
}
});
+ // For pauseless tables, a segment marked ONLINE in the ideal state may
not have been committed yet.
Review Comment:
Shall we consider adding a new method `findCommittingSegments` to return the
committing segments for pauseless table? I don't want to mix consuming segment
and committing segment because this way it can potentially return 2 segments
per partition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
