Jackie-Jiang commented on code in PR #14908:
URL: https://github.com/apache/pinot/pull/14908#discussion_r1929238935
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java:
##########
@@ -1974,6 +1975,22 @@ private Set<String> findConsumingSegments(IdealState
idealState) {
}
}
});
+ // For pauseless tables, a segment marked ONLINE in the ideal state may
not have been committed yet.
+ // We rely on SegmentZkMetadata to determine whether a segment has been
committed (status is DONE)
+ // instead of relying solely on the ideal state.
+ // A segment in COMMITTING state is treated as consuming for pauseStatus.
+ String tableNameWithType = idealState.getResourceName();
+ if
(PauselessConsumptionUtils.isPauselessEnabled(getTableConfig(tableNameWithType)))
{
+ Map<Integer, SegmentZKMetadata> metadataMap =
getLatestSegmentZKMetadataMap(tableNameWithType);
Review Comment:
Does this work? Committing segment won't be the latest segment in each
partition. I think this will never find committing segment, but always
`IN_PROGRESS`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
