real-mj-song commented on code in PR #14917:
URL: https://github.com/apache/pinot/pull/14917#discussion_r1931035635
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/combine/BaseSingleBlockCombineOperator.java:
##########
@@ -111,7 +112,11 @@ protected void processSegments() {
@Override
protected void onProcessSegmentsException(Throwable t) {
_processingException.compareAndSet(null, t);
- _blockingQueue.offer(new ExceptionResultsBlock(t));
+ if (t instanceof BadQueryRequestException) {
Review Comment:
> In ServerQueryExecutorV1Impl, we are setting QUERY_VALIDATION_ERROR for
BadQueryRequestException. Do we require the same changes here?
It does. Without this change, generic `RuntimeException` is thrown to
[QueryDispatcher.java](https://github.com/apache/pinot/pull/14917/files#diff-71eb98c311f40e7de5fa9750de41ff89c86aa9a9f7e485800992ff8f2e77b2c0)
which will bypass that check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
