real-mj-song commented on code in PR #14917:
URL: https://github.com/apache/pinot/pull/14917#discussion_r1931042152
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/combine/BaseSingleBlockCombineOperator.java:
##########
@@ -111,7 +112,11 @@ protected void processSegments() {
@Override
protected void onProcessSegmentsException(Throwable t) {
_processingException.compareAndSet(null, t);
- _blockingQueue.offer(new ExceptionResultsBlock(t));
+ if (t instanceof BadQueryRequestException) {
Review Comment:
> Either way I see this change only being made in
BaseSingleBlockCombineOperator. What about GroupByCombineOperator and
BaseStreamingCombineOperator?
Yeah just noticed these implement the same interface. Will update them as
well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
