[
https://issues.apache.org/jira/browse/PIRK-48?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15418768#comment-15418768
]
ASF GitHub Bot commented on PIRK-48:
------------------------------------
GitHub user tellison opened a pull request:
https://github.com/apache/incubator-pirk/pull/56
PIRK-48 - Pirk should pass all FindBugs tests
- Address a number of FindBugs warnings, including
- Unused local variables.
- Inefficient use of keySet()-get() rather than entrySet().
- Exposed collections marked as final.
- Streams not closed.
There are still 22 warnings outstanding after these fixes.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tellison/incubator-pirk pirk-48
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-pirk/pull/56.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #56
----
commit 0ad8787eceb29bb63d16c5f258513dd7dde91eee
Author: Tim Ellison <[email protected]>
Date: 2016-08-12T11:06:50Z
PIRK-48 - Pirk should pass all FindBugs tests
- Address a number of FindBugs warnings, including
- Unused local variables.
- Inefficient use of keySet()-get() rather than entrySet().
- Exposed collections marked as final.
- Streams not closed.
There are still 22 warnings outstanding after these fixes.
----
> Pirk should pass all FindBugs tests
> -----------------------------------
>
> Key: PIRK-48
> URL: https://issues.apache.org/jira/browse/PIRK-48
> Project: PIRK
> Issue Type: Task
> Reporter: Tim Ellison
> Assignee: Tim Ellison
>
> FindBugs is a useful tool that static analyses Java code and flags potential
> bugs and improvements.
> Pirk developers should ensure that FindBugs warnings are reviewed to ensure
> they are not identifying a real code bug. Bugs should be fixed, and false
> positives from FindBugs added to the project's filter.
> There is a FindBugs plug-in for Maven that can ensure warnings are addressed
> for a successful compilation, and can add a site report containing the
> results of the static analysis. We should also consider adding this to the
> project pom file.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
