[
https://issues.apache.org/jira/browse/PIRK-48?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15418785#comment-15418785
]
ASF GitHub Bot commented on PIRK-48:
------------------------------------
Github user ellisonanne commented on the issue:
https://github.com/apache/incubator-pirk/pull/56
+1 - This is great, thanks so much for doing this.
I've never used Findbugs before, but looks like I'm about to start ;) I'm
in favor of adding the maven plugin into the pom. We should document our use of
Findbugs on the website developer info - I will comment on the corresponding
JIRA.
> Pirk should pass all FindBugs tests
> -----------------------------------
>
> Key: PIRK-48
> URL: https://issues.apache.org/jira/browse/PIRK-48
> Project: PIRK
> Issue Type: Task
> Reporter: Tim Ellison
> Assignee: Tim Ellison
>
> FindBugs is a useful tool that static analyses Java code and flags potential
> bugs and improvements.
> Pirk developers should ensure that FindBugs warnings are reviewed to ensure
> they are not identifying a real code bug. Bugs should be fixed, and false
> positives from FindBugs added to the project's filter.
> There is a FindBugs plug-in for Maven that can ensure warnings are addressed
> for a successful compilation, and can add a site report containing the
> results of the static analysis. We should also consider adding this to the
> project pom file.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
