[
https://issues.apache.org/jira/browse/PIRK-4?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15428646#comment-15428646
]
ASF GitHub Bot commented on PIRK-4:
-----------------------------------
Github user smarthi commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/74#discussion_r75534791
--- Diff:
src/main/java/org/apache/pirk/responder/wideskies/ResponderDriver.java ---
@@ -65,6 +66,13 @@ else if
(SystemConfiguration.getProperty(ResponderProps.PLATFORM).equals("spark"
ComputeResponse computeResponse = new ComputeResponse(fs);
computeResponse.performQuery();
}
+ else if
(SystemConfiguration.getProperty(ResponderProps.PLATFORM).equals("storm"))
--- End diff --
we will need to abstract this out to implement this as a Strategy Pattern -
the more backends we add like Flink, Spark, Beam and others in the future its
only gonna get messy with multi - if-else stmts.
For a fun context, let me point u to this code snippet from IBM SystemML,
they r now adding Flink support which would be another another if-else block of
code - https://gist.github.com/smarthi/eb848e46621b7444924f
> Add Streaming Implementation for Apache Storm
> ---------------------------------------------
>
> Key: PIRK-4
> URL: https://issues.apache.org/jira/browse/PIRK-4
> Project: PIRK
> Issue Type: Task
> Components: Responder
> Reporter: Chris Harris
> Assignee: Chris Harris
>
> Per the Pirk Roadmap, this is a feature to add support for Apache Storm
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
