[ https://issues.apache.org/jira/browse/PIRK-79?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15621125#comment-15621125 ]
ASF GitHub Bot commented on PIRK-79: ------------------------------------ Github user smarthi commented on a diff in the pull request: https://github.com/apache/incubator-pirk/pull/115#discussion_r85682557 --- Diff: src/main/java/org/apache/pirk/encryption/Paillier.java --- @@ -340,4 +342,41 @@ private String parametersToString() return "p = " + p.intValue() + " q = " + q.intValue() + " N = " + N.intValue() + " NSquared = " + NSquared.intValue() + " lambdaN = " + lambdaN.intValue() + " bitLength = " + bitLength; } + + @Override public boolean equals(Object o) + { + if (this == o) + return true; + if (o == null || getClass() != o.getClass()) + return false; + + Paillier paillier = (Paillier) o; + + if (bitLength != paillier.bitLength) + return false; + if (!p.equals(paillier.p)) + return false; + if (!q.equals(paillier.q)) + return false; + if (!N.equals(paillier.N)) + return false; + if (!NSquared.equals(paillier.NSquared)) + return false; + if (!lambdaN.equals(paillier.lambdaN)) + return false; + return w.equals(paillier.w); + + } + + @Override public int hashCode() + { + int result = p.hashCode(); + result = 31 * result + q.hashCode(); + result = 31 * result + N.hashCode(); + result = 31 * result + NSquared.hashCode(); + result = 31 * result + lambdaN.hashCode(); + result = 31 * result + w.hashCode(); + result = 31 * result + bitLength; + return result; + } --- End diff -- Java 8 provides a Objects.hash(). Could we use that for all hashCode() methods ? > Allow json serialization to deserialize a queryInfo object that has only the > name of a query schema. > ---------------------------------------------------------------------------------------------------- > > Key: PIRK-79 > URL: https://issues.apache.org/jira/browse/PIRK-79 > Project: PIRK > Issue Type: Improvement > Components: Querier > Reporter: Walter Ray-Dulany > Assignee: Walter Ray-Dulany > Fix For: 0.3.0 > > > In Pirk Java serialization, when deserializing a queryinfo object, one can > get the requisite query schema by deserializing an entire serialized query > schema object *OR* by reading the name of a query schema (stored in queryType > in the QueryInfo object) and querying against a registry of known > queryschemas. Currently, JSON serialization does the former, but not the > latter. -- This message was sent by Atlassian JIRA (v6.3.4#6332)