[
https://issues.apache.org/jira/browse/PIRK-79?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15621157#comment-15621157
]
ASF GitHub Bot commented on PIRK-79:
------------------------------------
Github user wraydulany commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/115#discussion_r85683430
--- Diff:
src/test/java/org/apache/pirk/serialization/SerializationTest.java ---
@@ -75,6 +94,106 @@ public void testJavaSerDe() throws Exception
Assert.assertTrue(deserializedDummyObject.equals(dummyRecord));
}
+ @Test
+ public void testQuerierResponseSerializationDeserialization()
+ {
+ testQuerierResponseSerializationDeserialization(jsonSerializer);
+ testQuerierResponseSerializationDeserialization(javaSerializer);
--- End diff --
That line isn't in there twice. It's in there once with the arg
jsonSerializer, and once with the arg javaSerializer. ;) Thus are both extant
serialization services tested.
> Allow json serialization to deserialize a queryInfo object that has only the
> name of a query schema.
> ----------------------------------------------------------------------------------------------------
>
> Key: PIRK-79
> URL: https://issues.apache.org/jira/browse/PIRK-79
> Project: PIRK
> Issue Type: Improvement
> Components: Querier
> Reporter: Walter Ray-Dulany
> Assignee: Walter Ray-Dulany
> Fix For: 0.3.0
>
>
> In Pirk Java serialization, when deserializing a queryinfo object, one can
> get the requisite query schema by deserializing an entire serialized query
> schema object *OR* by reading the name of a query schema (stored in queryType
> in the QueryInfo object) and querying against a registry of known
> queryschemas. Currently, JSON serialization does the former, but not the
> latter.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
