Modified: poi/trunk/src/testcases/org/apache/poi/ss/format/TestCellFormat.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/format/TestCellFormat.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/ss/format/TestCellFormat.java (original) +++ poi/trunk/src/testcases/org/apache/poi/ss/format/TestCellFormat.java Fri Jan 8 23:50:02 2021 @@ -71,7 +71,7 @@ public class TestCellFormat { } @Test - public void testSome() { + void testSome() { JLabel l = new JLabel(); CellFormat fmt = CellFormat.getInstance( "\"$\"#,##0.00_);[Red]\\(\"$\"#,##0.00\\)"); @@ -79,56 +79,56 @@ public class TestCellFormat { } @Test - public void testPositiveFormatHasOnePart() { + void testPositiveFormatHasOnePart() { CellFormat fmt = CellFormat.getInstance("0.00"); CellFormatResult result = fmt.apply(12.345); assertEquals("12.35", result.text); } @Test - public void testNegativeFormatHasOnePart() { + void testNegativeFormatHasOnePart() { CellFormat fmt = CellFormat.getInstance("0.00"); CellFormatResult result = fmt.apply(-12.345); assertEquals("-12.35", result.text); } @Test - public void testZeroFormatHasOnePart() { + void testZeroFormatHasOnePart() { CellFormat fmt = CellFormat.getInstance("0.00"); CellFormatResult result = fmt.apply(0.0); assertEquals("0.00", result.text); } @Test - public void testPositiveFormatHasPosAndNegParts() { + void testPositiveFormatHasPosAndNegParts() { CellFormat fmt = CellFormat.getInstance("0.00;-0.00"); CellFormatResult result = fmt.apply(12.345); assertEquals("12.35", result.text); } @Test - public void testNegativeFormatHasPosAndNegParts() { + void testNegativeFormatHasPosAndNegParts() { CellFormat fmt = CellFormat.getInstance("0.00;-0.00"); CellFormatResult result = fmt.apply(-12.345); assertEquals("-12.35", result.text); } @Test - public void testNegativeFormatHasPosAndNegParts2() { + void testNegativeFormatHasPosAndNegParts2() { CellFormat fmt = CellFormat.getInstance("0.00;(0.00)"); CellFormatResult result = fmt.apply(-12.345); assertEquals("(12.35)", result.text); } @Test - public void testZeroFormatHasPosAndNegParts() { + void testZeroFormatHasPosAndNegParts() { CellFormat fmt = CellFormat.getInstance("0.00;-0.00"); CellFormatResult result = fmt.apply(0.0); assertEquals("0.00", result.text); } @Test - public void testFormatWithThreeSections() { + void testFormatWithThreeSections() { CellFormat fmt = CellFormat.getInstance("0.00;-0.00;-"); assertEquals("12.35", fmt.apply(12.345).text); @@ -138,7 +138,7 @@ public class TestCellFormat { } @Test - public void testFormatWithFourSections() { + void testFormatWithFourSections() { CellFormat fmt = CellFormat.getInstance("0.00;-0.00;-; @ "); assertEquals("12.35", fmt.apply(12.345).text); @@ -148,7 +148,7 @@ public class TestCellFormat { } @Test - public void testApplyCellForGeneralFormat() throws Exception { + void testApplyCellForGeneralFormat() throws Exception { // Create a workbook, row and cell to test with Workbook wb = new HSSFWorkbook(); @@ -189,7 +189,7 @@ public class TestCellFormat { } @Test - public void testApplyCellForAtFormat() throws Exception { + void testApplyCellForAtFormat() throws Exception { // Create a workbook, row and cell to test with Workbook wb = new HSSFWorkbook(); @@ -230,7 +230,7 @@ public class TestCellFormat { } @Test - public void testApplyCellForDateFormat() throws Exception { + void testApplyCellForDateFormat() throws Exception { // Create a workbook, row and cell to test with Workbook wb = new HSSFWorkbook(); @@ -253,7 +253,7 @@ public class TestCellFormat { } @Test - public void testApplyCellForTimeFormat() throws Exception { + void testApplyCellForTimeFormat() throws Exception { // Create a workbook, row and cell to test with Workbook wb = new HSSFWorkbook(); @@ -271,7 +271,7 @@ public class TestCellFormat { } @Test - public void testApplyCellForDateFormatAndNegativeFormat() throws Exception { + void testApplyCellForDateFormatAndNegativeFormat() throws Exception { // Create a workbook, row and cell to test with Workbook wb = new HSSFWorkbook(); @@ -294,7 +294,7 @@ public class TestCellFormat { } @Test - public void testApplyJLabelCellForGeneralFormat() throws Exception { + void testApplyJLabelCellForGeneralFormat() throws Exception { // Create a workbook, row and cell to test with Workbook wb = new HSSFWorkbook(); @@ -346,7 +346,7 @@ public class TestCellFormat { } @Test - public void testApplyJLabelCellForAtFormat() throws Exception { + void testApplyJLabelCellForAtFormat() throws Exception { // Create a workbook, row and cell to test with Workbook wb = new HSSFWorkbook(); @@ -398,7 +398,7 @@ public class TestCellFormat { } @Test - public void testApplyJLabelCellForDateFormat() throws Exception { + void testApplyJLabelCellForDateFormat() throws Exception { // Create a workbook, row and cell to test with Workbook wb = new HSSFWorkbook(); @@ -426,7 +426,7 @@ public class TestCellFormat { } @Test - public void testApplyJLabelCellForTimeFormat() throws Exception { + void testApplyJLabelCellForTimeFormat() throws Exception { // Create a workbook, row and cell to test with Workbook wb = new HSSFWorkbook(); @@ -447,7 +447,7 @@ public class TestCellFormat { } @Test - public void testApplyJLabelCellForDateFormatAndNegativeFormat() throws Exception { + void testApplyJLabelCellForDateFormatAndNegativeFormat() throws Exception { // Create a workbook, row and cell to test with Workbook wb = new HSSFWorkbook(); @@ -475,7 +475,7 @@ public class TestCellFormat { } @Test - public void testApplyFormatHasOnePartAndPartHasCondition() throws Exception { + void testApplyFormatHasOnePartAndPartHasCondition() throws Exception { // Create a workbook, row and cell to test with Workbook wb = new HSSFWorkbook(); @@ -504,7 +504,7 @@ public class TestCellFormat { } @Test - public void testApplyFormatHasTwoPartsFirstHasCondition() throws Exception { + void testApplyFormatHasTwoPartsFirstHasCondition() throws Exception { // Create a workbook, row and cell to test with Workbook wb = new HSSFWorkbook(); @@ -539,7 +539,7 @@ public class TestCellFormat { } @Test - public void testApplyFormatHasTwoPartsBothHaveCondition() throws Exception { + void testApplyFormatHasTwoPartsBothHaveCondition() throws Exception { // Create a workbook, row and cell to test with Workbook wb = new HSSFWorkbook(); @@ -571,7 +571,7 @@ public class TestCellFormat { } @Test - public void testApplyFormatHasThreePartsFirstHasCondition() throws Exception { + void testApplyFormatHasThreePartsFirstHasCondition() throws Exception { // Create a workbook, row and cell to test with Workbook wb = new HSSFWorkbook(); @@ -605,7 +605,7 @@ public class TestCellFormat { } @Test - public void testApplyFormatHasThreePartsFirstTwoHaveCondition() throws Exception { + void testApplyFormatHasThreePartsFirstTwoHaveCondition() throws Exception { // Create a workbook, row and cell to test with Workbook wb = new HSSFWorkbook(); @@ -634,7 +634,7 @@ public class TestCellFormat { } @Test - public void testApplyFormatHasThreePartsFirstIsDateFirstTwoHaveCondition() throws Exception { + void testApplyFormatHasThreePartsFirstIsDateFirstTwoHaveCondition() throws Exception { // Create a workbook, row and cell to test with Workbook wb = new HSSFWorkbook(); @@ -663,7 +663,7 @@ public class TestCellFormat { } @Test - public void testApplyFormatHasTwoPartsFirstHasConditionSecondIsGeneral() throws Exception { + void testApplyFormatHasTwoPartsFirstHasConditionSecondIsGeneral() throws Exception { // Create a workbook, row and cell to test with Workbook wb = new HSSFWorkbook(); @@ -692,7 +692,7 @@ public class TestCellFormat { } @Test - public void testApplyFormatHasThreePartsFirstTwoHaveConditionThirdIsGeneral() throws Exception { + void testApplyFormatHasThreePartsFirstTwoHaveConditionThirdIsGeneral() throws Exception { // Create a workbook, row and cell to test with Workbook wb = new HSSFWorkbook(); @@ -721,7 +721,7 @@ public class TestCellFormat { } @Test - public void testApplyFormatHasFourPartsFirstHasCondition() throws Exception { + void testApplyFormatHasFourPartsFirstHasCondition() throws Exception { // Create a workbook, row and cell to test with Workbook wb = new HSSFWorkbook(); @@ -755,7 +755,7 @@ public class TestCellFormat { } @Test - public void testApplyFormatHasFourPartsSecondHasCondition() throws Exception { + void testApplyFormatHasFourPartsSecondHasCondition() throws Exception { // Create a workbook, row and cell to test with Workbook wb = new HSSFWorkbook(); @@ -790,7 +790,7 @@ public class TestCellFormat { } @Test - public void testApplyFormatHasFourPartsFirstTwoHaveCondition() throws Exception { + void testApplyFormatHasFourPartsFirstTwoHaveCondition() throws Exception { // Create a workbook, row and cell to test with Workbook wb = new HSSFWorkbook(); @@ -825,7 +825,7 @@ public class TestCellFormat { * Test apply(Object value) with a number as parameter */ @Test - public void testApplyObjectNumber() { + void testApplyObjectNumber() { CellFormat cf1 = CellFormat.getInstance("0.000"); @@ -853,7 +853,7 @@ public class TestCellFormat { * Test apply(Object value) with a Date as parameter */ @Test - public void testApplyObjectDate() throws ParseException { + void testApplyObjectDate() throws ParseException { CellFormat cf1 = CellFormat.getInstance("m/d/yyyy"); SimpleDateFormat sdf1 = new SimpleDateFormat("M/d/y", Locale.ROOT); sdf1.setTimeZone(TimeZone.getTimeZone("CET")); @@ -862,7 +862,7 @@ public class TestCellFormat { } @Test - public void testApplyCellForDateFormatWithConditions() throws Exception { + void testApplyCellForDateFormatWithConditions() throws Exception { // Create a workbook, row and cell to test with Workbook wb = new HSSFWorkbook(); @@ -888,7 +888,7 @@ public class TestCellFormat { * Test apply(Object value) with a String as parameter */ @Test - public void testApplyObjectString() { + void testApplyObjectString() { CellFormat cf = CellFormat.getInstance("0.00"); @@ -900,7 +900,7 @@ public class TestCellFormat { * Test apply(Object value) with a Boolean as parameter */ @Test - public void testApplyObjectBoolean() { + void testApplyObjectBoolean() { CellFormat cf1 = CellFormat.getInstance("0"); CellFormat cf2 = CellFormat.getInstance("General"); @@ -913,7 +913,7 @@ public class TestCellFormat { } @Test - public void testSimpleFractionFormat() throws IOException { + void testSimpleFractionFormat() throws IOException { CellFormat cf1 = CellFormat.getInstance("# ?/?"); // Create a workbook, row and cell to test with try (Workbook wb = new HSSFWorkbook()) { @@ -927,7 +927,7 @@ public class TestCellFormat { } @Test - public void testAccountingFormats() { + void testAccountingFormats() { char pound = '\u00A3'; char euro = '\u20AC'; @@ -978,7 +978,7 @@ public class TestCellFormat { } @Test - public void testThreePartComplexFormat1() { + void testThreePartComplexFormat1() { // verify a rather complex format found e.g. in http://wahl.land-oberoesterreich.gv.at/Downloads/bp10.xls CellFormatPart posPart = new CellFormatPart("[$-F400]h:mm:ss\\ AM/PM"); assertNotNull(posPart); @@ -996,7 +996,7 @@ public class TestCellFormat { } @Test - public void testThreePartComplexFormat2() { + void testThreePartComplexFormat2() { // verify a rather complex format found e.g. in http://wahl.land-oberoesterreich.gv.at/Downloads/bp10.xls CellFormatPart posPart = new CellFormatPart("dd/mm/yyyy"); assertNotNull(posPart); @@ -1014,13 +1014,13 @@ public class TestCellFormat { } @Test - public void testBug62865() { + void testBug62865() { CellFormat cf = CellFormat.getInstance("\"ca. \"0"); assertEquals("ca. 5", cf.apply((double) 5).text); } @Test - public void testNamedColors() { + void testNamedColors() { assertTrue(CellFormatPart.NAMED_COLORS.size() >= HSSFColor.HSSFColorPredefined.values().length); Stream.of("GREEN", "Green", "RED", "Red", "BLUE", "Blue", "YELLOW", "Yellow") .map(CellFormatPart.NAMED_COLORS::get)
Modified: poi/trunk/src/testcases/org/apache/poi/ss/format/TestCellFormatCondition.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/format/TestCellFormatCondition.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/ss/format/TestCellFormatCondition.java (original) +++ poi/trunk/src/testcases/org/apache/poi/ss/format/TestCellFormatCondition.java Fri Jan 8 23:50:02 2021 @@ -23,7 +23,7 @@ import org.junit.jupiter.api.Test; public class TestCellFormatCondition { @Test - public void testSVConditions() { + void testSVConditions() { CellFormatCondition lt = CellFormatCondition.getInstance("<", "1.5"); assertTrue(lt.pass(1.4)); assertFalse(lt.pass(1.5)); Modified: poi/trunk/src/testcases/org/apache/poi/ss/format/TestCellFormatResult.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/format/TestCellFormatResult.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/ss/format/TestCellFormatResult.java (original) +++ poi/trunk/src/testcases/org/apache/poi/ss/format/TestCellFormatResult.java Fri Jan 8 23:50:02 2021 @@ -25,7 +25,7 @@ import org.junit.jupiter.api.Test; public class TestCellFormatResult { @Test - public void testNullTextRaisesException() { + void testNullTextRaisesException() { final boolean applies = true; final String text = null; final Color textColor = Color.BLACK; Modified: poi/trunk/src/testcases/org/apache/poi/ss/formula/BaseTestExternalFunctions.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/formula/BaseTestExternalFunctions.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/ss/formula/BaseTestExternalFunctions.java (original) +++ poi/trunk/src/testcases/org/apache/poi/ss/formula/BaseTestExternalFunctions.java Fri Jan 8 23:50:02 2021 @@ -95,7 +95,7 @@ public abstract class BaseTestExternalFu } @Test - public void testExternalFunctions() throws IOException { + void testExternalFunctions() throws IOException { try (Workbook wb = _testDataProvider.createWorkbook()) { FormulaEvaluator evaluator = wb.getCreationHelper().createFormulaEvaluator(); Modified: poi/trunk/src/testcases/org/apache/poi/ss/formula/BaseTestMissingWorkbook.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/formula/BaseTestMissingWorkbook.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/ss/formula/BaseTestMissingWorkbook.java (original) +++ poi/trunk/src/testcases/org/apache/poi/ss/formula/BaseTestMissingWorkbook.java Fri Jan 8 23:50:02 2021 @@ -75,7 +75,7 @@ public abstract class BaseTestMissingWor } @Test - public void testMissingWorkbookMissing() { + void testMissingWorkbookMissing() { FormulaEvaluator evaluator = mainWorkbook.getCreationHelper().createFormulaEvaluator(); Sheet lSheet = mainWorkbook.getSheetAt(0); @@ -89,7 +89,7 @@ public abstract class BaseTestMissingWor } @Test - public void testMissingWorkbookMissingOverride() { + void testMissingWorkbookMissingOverride() { Sheet lSheet = mainWorkbook.getSheetAt(0); Cell lA1Cell = lSheet.getRow(0).getCell(0); Cell lB1Cell = lSheet.getRow(1).getCell(0); @@ -118,7 +118,7 @@ public abstract class BaseTestMissingWor } @Test - public void testExistingWorkbook() { + void testExistingWorkbook() { Sheet lSheet = mainWorkbook.getSheetAt(0); Cell lA1Cell = lSheet.getRow(0).getCell(0); Cell lB1Cell = lSheet.getRow(1).getCell(0); Modified: poi/trunk/src/testcases/org/apache/poi/ss/formula/TestCellCacheEntry.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/formula/TestCellCacheEntry.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/ss/formula/TestCellCacheEntry.java (original) +++ poi/trunk/src/testcases/org/apache/poi/ss/formula/TestCellCacheEntry.java Fri Jan 8 23:50:02 2021 @@ -29,7 +29,7 @@ import org.junit.jupiter.api.Test; public class TestCellCacheEntry { @Test - public void testBasic() { + void testBasic() { CellCacheEntry pcce = new PlainValueCellCacheEntry(new NumberEval(42.0)); ValueEval ve = pcce.getValue(); assertEquals(42, ((NumberEval)ve).getNumberValue(), 0.0); Modified: poi/trunk/src/testcases/org/apache/poi/ss/formula/TestEvaluationCache.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/formula/TestEvaluationCache.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/ss/formula/TestEvaluationCache.java (original) +++ poi/trunk/src/testcases/org/apache/poi/ss/formula/TestEvaluationCache.java Fri Jan 8 23:50:02 2021 @@ -311,7 +311,7 @@ public class TestEvaluationCache { } @Test - public void testMediumComplex() { + void testMediumComplex() { MySheet ms = createMediumComplex(); // completely fresh evaluation confirmEvaluate(ms, "A1", 46); @@ -389,7 +389,7 @@ public class TestEvaluationCache { } @Test - public void testMediumComplexWithDependencyChange() { + void testMediumComplexWithDependencyChange() { // Changing an intermediate formula MySheet ms = createMediumComplex(); confirmEvaluate(ms, "A1", 46); @@ -448,7 +448,7 @@ public class TestEvaluationCache { * only when the plain cell's value actually changes */ @Test - public void testRedundantUpdate() { + void testRedundantUpdate() { MySheet ms = new MySheet(); ms.setCellValue("B1", 12); @@ -492,7 +492,7 @@ public class TestEvaluationCache { * effect in almost every function and operator. */ @Test - public void testSimpleWithDependencyChange() { + void testSimpleWithDependencyChange() { MySheet ms = new MySheet(); ms.setCellFormula("A1", "INDEX(C1:E1,1,B1)"); @@ -542,7 +542,7 @@ public class TestEvaluationCache { } @Test - public void testBlankCells() { + void testBlankCells() { MySheet ms = new MySheet(); ms.setCellFormula("A1", "sum(B1:D4,B5:E6)"); @@ -592,7 +592,7 @@ public class TestEvaluationCache { * have their cached results cleared. */ @Test - public void testBlankCellChangedToValueCell_bug46053() { + void testBlankCellChangedToValueCell_bug46053() { HSSFWorkbook wb = new HSSFWorkbook(); HSSFSheet sheet = wb.createSheet("Sheet1"); HSSFRow row = sheet.createRow(0); @@ -628,7 +628,7 @@ public class TestEvaluationCache { * same use-case as the test for bug 46053, but checking trace values too */ @Test - public void testBlankCellChangedToValueCell() { + void testBlankCellChangedToValueCell() { MySheet ms = new MySheet(); @@ -669,7 +669,7 @@ public class TestEvaluationCache { } @Test - public void testPlainValueCache() { + void testPlainValueCache() { Workbook wb = new HSSFWorkbook(); int numberOfSheets = 4098; // Bug 51448 reported that Evaluation Cache got messed up after 256 sheets Modified: poi/trunk/src/testcases/org/apache/poi/ss/formula/TestFormulaShifter.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/formula/TestFormulaShifter.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/ss/formula/TestFormulaShifter.java (original) +++ poi/trunk/src/testcases/org/apache/poi/ss/formula/TestFormulaShifter.java Fri Jan 8 23:50:02 2021 @@ -42,7 +42,7 @@ public final class TestFormulaShifter { * moved */ @Test - public void testShiftAreasSourceRows() { + void testShiftAreasSourceRows() { // all these operations are on an area ref spanning rows 10 to 20 AreaPtg aptg = createAreaPtgRow(10, 20); @@ -82,7 +82,7 @@ public final class TestFormulaShifter { } @Test - public void testShiftAreasSourceColumns() { + void testShiftAreasSourceColumns() { // all these operations are on an area ref spanning columns 10 to 20 AreaPtg aptg = createAreaPtgColumn(10, 20); @@ -122,7 +122,7 @@ public final class TestFormulaShifter { } @Test - public void testCopyAreasSourceRowsRelRel() { + void testCopyAreasSourceRowsRelRel() { // all these operations are on an area ref spanning rows 10 to 20 final AreaPtg aptg = createAreaPtgRow(10, 20, true, true); @@ -132,7 +132,7 @@ public final class TestFormulaShifter { } @Test - public void testCopyAreasSourceRowsRelAbs() { + void testCopyAreasSourceRowsRelAbs() { // all these operations are on an area ref spanning rows 10 to 20 final AreaPtg aptg = createAreaPtgRow(10, 20, true, false); @@ -143,7 +143,7 @@ public final class TestFormulaShifter { } @Test - public void testCopyAreasSourceRowsAbsRel() { + void testCopyAreasSourceRowsAbsRel() { // aptg is part of a formula in a cell that was just copied to another row // aptg row references should be updated by the difference in rows that the cell was copied // No other references besides the cells that were involved in the copy need to be updated @@ -159,7 +159,7 @@ public final class TestFormulaShifter { } @Test - public void testCopyAreasSourceRowsAbsAbs() { + void testCopyAreasSourceRowsAbsAbs() { // aptg is part of a formula in a cell that was just copied to another row // aptg row references should be updated by the difference in rows that the cell was copied // No other references besides the cells that were involved in the copy need to be updated @@ -175,7 +175,7 @@ public final class TestFormulaShifter { } @Test - public void testCopyAreasSourceColumnsRelRel() { + void testCopyAreasSourceColumnsRelRel() { // all these operations are on an area ref spanning columns 10 to 20 final AreaPtg aptg = createAreaPtgColumn(10, 20, true, true); @@ -185,7 +185,7 @@ public final class TestFormulaShifter { } @Test - public void testCopyAreasSourceColumnsRelAbs() { + void testCopyAreasSourceColumnsRelAbs() { // all these operations are on an area ref spanning columns 10 to 20 final AreaPtg aptg = createAreaPtgColumn(10, 20, true, false); @@ -196,7 +196,7 @@ public final class TestFormulaShifter { } @Test - public void testCopyAreasSourceColumnsAbsRel() { + void testCopyAreasSourceColumnsAbsRel() { // aptg is part of a formula in a cell that was just copied to another column // aptg column references should be updated by the difference in columns that the cell was copied // No other references besides the cells that were involved in the copy need to be updated @@ -212,7 +212,7 @@ public final class TestFormulaShifter { } @Test - public void testCopyAreasSourceColumnsAbsAbs() { + void testCopyAreasSourceColumnsAbsAbs() { // aptg is part of a formula in a cell that was just copied to another column // aptg column references should be updated by the difference in columns that the cell was copied // No other references besides the cells that were involved in the copy need to be updated @@ -234,7 +234,7 @@ public final class TestFormulaShifter { * that area ref */ @Test - public void testShiftAreasDestRows() { + void testShiftAreasDestRows() { // all these operations are on an area ref spanning rows 20 to 25 AreaPtg aptg = createAreaPtgRow(20, 25); @@ -254,7 +254,7 @@ public final class TestFormulaShifter { * that area ref */ @Test - public void testShiftAreasDestColumns() { + void testShiftAreasDestColumns() { // all these operations are on an area ref spanning columns 20 to 25 AreaPtg aptg = createAreaPtgColumn(20, 25); @@ -382,7 +382,7 @@ public final class TestFormulaShifter { } @Test - public void testShiftSheet() { + void testShiftSheet() { // 4 sheets, move a sheet from pos 2 to pos 0, i.e. current 0 becomes 1, current 1 becomes pos 2 FormulaShifter shifter = FormulaShifter.createForSheetShift(2, 0); @@ -406,7 +406,7 @@ public final class TestFormulaShifter { } @Test - public void testShiftSheet2() { + void testShiftSheet2() { // 4 sheets, move a sheet from pos 1 to pos 2, i.e. current 2 becomes 1, current 1 becomes pos 2 FormulaShifter shifter = FormulaShifter.createForSheetShift(1, 2); @@ -430,7 +430,7 @@ public final class TestFormulaShifter { } @Test - public void testInvalidArgument() { + void testInvalidArgument() { assertThrows(IllegalArgumentException.class, () -> FormulaShifter.createForRowShift(1, "name", 1, 2, 0, SpreadsheetVersion.EXCEL97)); assertThrows(IllegalArgumentException.class, () -> @@ -438,12 +438,12 @@ public final class TestFormulaShifter { } @Test - public void testConstructor() { + void testConstructor() { assertNotNull(FormulaShifter.createForRowShift(1, "name", 1, 2, 2, SpreadsheetVersion.EXCEL97)); } @Test - public void testToString() { + void testToString() { FormulaShifter shifter = FormulaShifter.createForRowShift(0, "sheet", 123, 456, 789, SpreadsheetVersion.EXCEL2007); assertNotNull(shifter); Modified: poi/trunk/src/testcases/org/apache/poi/ss/formula/TestFunctionRegistry.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/formula/TestFunctionRegistry.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/ss/formula/TestFunctionRegistry.java (original) +++ poi/trunk/src/testcases/org/apache/poi/ss/formula/TestFunctionRegistry.java Fri Jan 8 23:50:02 2021 @@ -68,14 +68,14 @@ public class TestFunctionRegistry { } @Test - public void testRegisterInRuntimeA() { + void testRegisterInRuntimeA() { HSSFCell cellA = row.createCell(0); cellA.setCellFormula("FISHER(A5)"); assertThrows(NotImplementedException.class, () -> fe.evaluate(cellA)); } @Test - public void testRegisterInRuntimeB() { + void testRegisterInRuntimeB() { HSSFCell cellA = row.createCell(0); cellA.setCellFormula("FISHER(A5)"); FunctionEval.registerFunction("FISHER", (args, srcRowIndex, srcColumnIndex) -> ErrorEval.NA); @@ -84,14 +84,14 @@ public class TestFunctionRegistry { } @Test - public void testRegisterInRuntimeC() { + void testRegisterInRuntimeC() { HSSFCell cellB = row.createCell(1); cellB.setCellFormula("CUBEMEMBERPROPERTY(A5)"); assertThrows(NotImplementedException.class, () -> fe.evaluate(cellB)); } @Test - public void testRegisterInRuntimeD() { + void testRegisterInRuntimeD() { HSSFCell cellB = row.createCell(1); cellB.setCellFormula("CUBEMEMBERPROPERTY(A5)"); @@ -106,7 +106,7 @@ public class TestFunctionRegistry { } @Test - public void testExceptionsA() { + void testExceptionsA() { IllegalArgumentException ex = assertThrows( IllegalArgumentException.class, () -> FunctionEval.registerFunction("SUM", TestFunctionRegistry::na) @@ -115,7 +115,7 @@ public class TestFunctionRegistry { } @Test - public void testExceptionsB() { + void testExceptionsB() { IllegalArgumentException ex = assertThrows( IllegalArgumentException.class, () -> FunctionEval.registerFunction("SUMXXX", TestFunctionRegistry::na) @@ -124,7 +124,7 @@ public class TestFunctionRegistry { } @Test - public void testExceptionsC() { + void testExceptionsC() { IllegalArgumentException ex = assertThrows( IllegalArgumentException.class, () -> FunctionEval.registerFunction("ISODD", TestFunctionRegistry::na) @@ -139,7 +139,7 @@ public class TestFunctionRegistry { } @Test - public void testExceptionsD() { + void testExceptionsD() { IllegalArgumentException ex = assertThrows( IllegalArgumentException.class, () -> AnalysisToolPak.registerFunction("ISODD", TestFunctionRegistry::atpFunc) @@ -148,7 +148,7 @@ public class TestFunctionRegistry { } @Test - public void testExceptionsE() { + void testExceptionsE() { IllegalArgumentException ex = assertThrows( IllegalArgumentException.class, () -> AnalysisToolPak.registerFunction("ISODDXXX", TestFunctionRegistry::atpFunc) @@ -157,7 +157,7 @@ public class TestFunctionRegistry { } @Test - public void testExceptionsF() { + void testExceptionsF() { IllegalArgumentException ex = assertThrows( IllegalArgumentException.class, () -> AnalysisToolPak.registerFunction("SUM", TestFunctionRegistry::atpFunc) Modified: poi/trunk/src/testcases/org/apache/poi/ss/formula/TestPlainCellCache.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/formula/TestPlainCellCache.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/ss/formula/TestPlainCellCache.java (original) +++ poi/trunk/src/testcases/org/apache/poi/ss/formula/TestPlainCellCache.java Fri Jan 8 23:50:02 2021 @@ -30,7 +30,7 @@ import org.junit.jupiter.api.Test; public class TestPlainCellCache { @Test - public void testLoc(){ + void testLoc(){ PlainCellCache cache = new PlainCellCache(); for (int bookIndex = 0; bookIndex < 0x1000; bookIndex += 0x100) { for (int sheetIndex = 0; sheetIndex < 0x1000; sheetIndex += 0x100) { Modified: poi/trunk/src/testcases/org/apache/poi/ss/formula/TestSheetNameFormatter.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/formula/TestSheetNameFormatter.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/ss/formula/TestSheetNameFormatter.java (original) +++ poi/trunk/src/testcases/org/apache/poi/ss/formula/TestSheetNameFormatter.java Fri Jan 8 23:50:02 2021 @@ -35,7 +35,7 @@ public final class TestSheetNameFormatte * Tests main public method 'format' */ @Test - public void testFormat() { + void testFormat() { confirmFormat("abc", "abc"); confirmFormat("123", "'123'"); @@ -74,7 +74,7 @@ public final class TestSheetNameFormatte } @Test - public void testFormatWithWorkbookName() { + void testFormatWithWorkbookName() { confirmFormat("abc", "abc", "[abc]abc"); confirmFormat("abc", "123", "'[abc]123'"); @@ -113,7 +113,7 @@ public final class TestSheetNameFormatte } @Test - public void testFormatException() { + void testFormatException() { Appendable mock = new Appendable() { @Override public Appendable append(CharSequence csq) throws IOException { @@ -136,7 +136,7 @@ public final class TestSheetNameFormatte } @Test - public void testBooleanLiterals() { + void testBooleanLiterals() { confirmFormat("TRUE", "'TRUE'"); confirmFormat("FALSE", "'FALSE'"); confirmFormat("True", "'True'"); @@ -155,7 +155,7 @@ public final class TestSheetNameFormatte * would look (to Excel) like a cell name. */ @Test - public void testLooksLikePlainCellReference() { + void testLooksLikePlainCellReference() { confirmCellNameMatch("A1", true); confirmCellNameMatch("a111", true); @@ -178,7 +178,7 @@ public final class TestSheetNameFormatte * letters followed by one or more digits). */ @Test - public void testCellRange() { + void testCellRange() { confirmCellRange("A1", 1, true); confirmCellRange("a111", 1, true); confirmCellRange("A65536", 1, true); Modified: poi/trunk/src/testcases/org/apache/poi/ss/formula/TestWorkbookEvaluator.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/formula/TestWorkbookEvaluator.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/ss/formula/TestWorkbookEvaluator.java (original) +++ poi/trunk/src/testcases/org/apache/poi/ss/formula/TestWorkbookEvaluator.java Fri Jan 8 23:50:02 2021 @@ -74,7 +74,7 @@ public class TestWorkbookEvaluator { * the whole formula which converts tAttrSum to tFuncVar("SUM") ) */ @Test - public void testAttrSum() { + void testAttrSum() { Ptg[] ptgs = { new IntPtg(42), @@ -91,7 +91,7 @@ public class TestWorkbookEvaluator { * to the error constant #REF! ) */ @Test - public void testRefErr() { + void testRefErr() { confirmRefErr(new RefErrorPtg()); confirmRefErr(new AreaErrPtg()); @@ -112,7 +112,7 @@ public class TestWorkbookEvaluator { * the whole formula which converts tAttrSum to tFuncVar("SUM") ) */ @Test - public void testMemFunc() { + void testMemFunc() { Ptg[] ptgs = { new IntPtg(42), AttrPtg.SUM, @@ -123,7 +123,7 @@ public class TestWorkbookEvaluator { } @Test - public void testEvaluateMultipleWorkbooks() { + void testEvaluateMultipleWorkbooks() { HSSFWorkbook wbA = HSSFTestDataSamples.openSampleWorkbook("multibookFormulaA.xls"); HSSFWorkbook wbB = HSSFTestDataSamples.openSampleWorkbook("multibookFormulaB.xls"); @@ -189,7 +189,7 @@ public class TestWorkbookEvaluator { * the result of a function gets translated to {@link BlankEval}. */ @Test - public void testMissingArg() { + void testMissingArg() { HSSFWorkbook wb = new HSSFWorkbook(); HSSFSheet sheet = wb.createSheet("Sheet1"); HSSFRow row = sheet.createRow(0); @@ -225,7 +225,7 @@ public class TestWorkbookEvaluator { * should be dereferenced by the evaluator */ @Test - public void testResultOutsideRange() throws IOException { + void testResultOutsideRange() throws IOException { try (Workbook wb = new HSSFWorkbook()) { Cell cell = wb.createSheet("Sheet1").createRow(0).createCell(0); cell.setCellFormula("D2:D5"); // IF(TRUE,D2:D5,D2) or OFFSET(D2:D5,0,0) would work too @@ -256,7 +256,7 @@ public class TestWorkbookEvaluator { * formulas with defined names. */ @Test - public void testNamesInFormulas() throws IOException { + void testNamesInFormulas() throws IOException { Workbook wb = new HSSFWorkbook(); Sheet sheet = wb.createSheet("Sheet1"); @@ -311,7 +311,7 @@ public class TestWorkbookEvaluator { } @Test - public void testIgnoreMissingWorkbooks() { + void testIgnoreMissingWorkbooks() { // TODO: update this test for meaningful functional behavior WorkbookEvaluator evaluator = new WorkbookEvaluator(null, null, null); assertFalse(evaluator.isIgnoreMissingWorkbooks()); @@ -324,7 +324,7 @@ public class TestWorkbookEvaluator { } @Test - public void testDebugEvaluationOutputForNextEval() { + void testDebugEvaluationOutputForNextEval() { // TODO: update this test for meaningful functional behavior WorkbookEvaluator evaluator = new WorkbookEvaluator(null, null, null); assertFalse(evaluator.isDebugEvaluationOutputForNextEval()); @@ -413,7 +413,7 @@ public class TestWorkbookEvaluator { } @Test - public void testIFEqualsFormulaEvaluation_NumericLiteral() { + void testIFEqualsFormulaEvaluation_NumericLiteral() { final String formula = "IF(A1=1, 2, 3)"; final CellType cellType = CellType.NUMERIC; final String expectedFormula = "IF(A1=1,2,3)"; @@ -422,7 +422,7 @@ public class TestWorkbookEvaluator { } @Test - public void testIFEqualsFormulaEvaluation_Numeric() { + void testIFEqualsFormulaEvaluation_Numeric() { final String formula = "IF(A1=1, B1, C1)"; final CellType cellType = CellType.NUMERIC; final String expectedFormula = "IF(A1=1,B1,C1)"; @@ -431,7 +431,7 @@ public class TestWorkbookEvaluator { } @Test - public void testIFEqualsFormulaEvaluation_NumericCoerceToString() { + void testIFEqualsFormulaEvaluation_NumericCoerceToString() { final String formula = "IF(A1&\"\"=\"1\", B1, C1)"; final CellType cellType = CellType.NUMERIC; final String expectedFormula = "IF(A1&\"\"=\"1\",B1,C1)"; @@ -440,7 +440,7 @@ public class TestWorkbookEvaluator { } @Test - public void testIFEqualsFormulaEvaluation_String() { + void testIFEqualsFormulaEvaluation_String() { final String formula = "IF(A1=1, B1, C1)"; final CellType cellType = CellType.STRING; final String expectedFormula = "IF(A1=1,B1,C1)"; @@ -449,7 +449,7 @@ public class TestWorkbookEvaluator { } @Test - public void testIFEqualsFormulaEvaluation_StringCompareToString() { + void testIFEqualsFormulaEvaluation_StringCompareToString() { final String formula = "IF(A1=\"1\", B1, C1)"; final CellType cellType = CellType.STRING; final String expectedFormula = "IF(A1=\"1\",B1,C1)"; @@ -458,7 +458,7 @@ public class TestWorkbookEvaluator { } @Test - public void testIFEqualsFormulaEvaluation_StringCoerceToNumeric() { + void testIFEqualsFormulaEvaluation_StringCoerceToNumeric() { final String formula = "IF(A1+0=1, B1, C1)"; final CellType cellType = CellType.STRING; final String expectedFormula = "IF(A1+0=1,B1,C1)"; @@ -468,7 +468,7 @@ public class TestWorkbookEvaluator { @Disabled("Bug 58591: this test currently fails") @Test - public void testIFEqualsFormulaEvaluation_Boolean() { + void testIFEqualsFormulaEvaluation_Boolean() { final String formula = "IF(A1=1, B1, C1)"; final CellType cellType = CellType.BOOLEAN; final String expectedFormula = "IF(A1=1,B1,C1)"; @@ -478,7 +478,7 @@ public class TestWorkbookEvaluator { @Disabled("Bug 58591: this test currently fails") @Test - public void testIFEqualsFormulaEvaluation_BooleanSimple() { + void testIFEqualsFormulaEvaluation_BooleanSimple() { final String formula = "3-(A1=1)"; final CellType cellType = CellType.BOOLEAN; final String expectedFormula = "3-(A1=1)"; @@ -487,7 +487,7 @@ public class TestWorkbookEvaluator { } @Test - public void testIFEqualsFormulaEvaluation_Formula() { + void testIFEqualsFormulaEvaluation_Formula() { final String formula = "IF(A1=1, B1, C1)"; final CellType cellType = CellType.FORMULA; final String expectedFormula = "IF(A1=1,B1,C1)"; @@ -496,7 +496,7 @@ public class TestWorkbookEvaluator { } @Test - public void testIFEqualsFormulaEvaluation_Blank() { + void testIFEqualsFormulaEvaluation_Blank() { final String formula = "IF(A1=1, B1, C1)"; final CellType cellType = CellType.BLANK; final String expectedFormula = "IF(A1=1,B1,C1)"; @@ -505,7 +505,7 @@ public class TestWorkbookEvaluator { } @Test - public void testIFEqualsFormulaEvaluation_BlankCompareToZero() { + void testIFEqualsFormulaEvaluation_BlankCompareToZero() { final String formula = "IF(A1=0, B1, C1)"; final CellType cellType = CellType.BLANK; final String expectedFormula = "IF(A1=0,B1,C1)"; @@ -515,7 +515,7 @@ public class TestWorkbookEvaluator { @Disabled("Bug 58591: this test currently fails") @Test - public void testIFEqualsFormulaEvaluation_BlankInverted() { + void testIFEqualsFormulaEvaluation_BlankInverted() { final String formula = "IF(NOT(A1)=1, B1, C1)"; final CellType cellType = CellType.BLANK; final String expectedFormula = "IF(NOT(A1)=1,B1,C1)"; @@ -525,7 +525,7 @@ public class TestWorkbookEvaluator { @Disabled("Bug 58591: this test currently fails") @Test - public void testIFEqualsFormulaEvaluation_BlankInvertedSimple() { + void testIFEqualsFormulaEvaluation_BlankInvertedSimple() { final String formula = "3-(NOT(A1)=1)"; final CellType cellType = CellType.BLANK; final String expectedFormula = "3-(NOT(A1)=1)"; @@ -607,7 +607,7 @@ public class TestWorkbookEvaluator { } @Test - public void testRefToBlankCellInArrayFormula() { + void testRefToBlankCellInArrayFormula() { Workbook wb = new HSSFWorkbook(); Sheet sheet = wb.createSheet(); Row row = sheet.createRow(0); Modified: poi/trunk/src/testcases/org/apache/poi/ss/formula/atp/TestIfError.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/formula/atp/TestIfError.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/ss/formula/atp/TestIfError.java (original) +++ poi/trunk/src/testcases/org/apache/poi/ss/formula/atp/TestIfError.java Fri Jan 8 23:50:02 2021 @@ -41,7 +41,7 @@ public class TestIfError { * =IFERROR(C1,\"Error in calculation\")" References the result of dividing 55 by 0 and returns the error text */ @Test - public void testEvaluate() throws IOException { + void testEvaluate() throws IOException { try (Workbook wb = new HSSFWorkbook()) { Sheet sh = wb.createSheet(); Row row1 = sh.createRow(0); Modified: poi/trunk/src/testcases/org/apache/poi/ss/formula/atp/TestMRound.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/formula/atp/TestMRound.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/ss/formula/atp/TestMRound.java (original) +++ poi/trunk/src/testcases/org/apache/poi/ss/formula/atp/TestMRound.java Fri Jan 8 23:50:02 2021 @@ -38,7 +38,7 @@ public class TestMRound { =MROUND(5, -2) Returns an error, because -2 and 5 have different signs (#NUM!) * */ @Test - public void testEvaluate(){ + void testEvaluate(){ Workbook wb = new HSSFWorkbook(); Sheet sh = wb.createSheet(); Cell cell1 = sh.createRow(0).createCell(0); Modified: poi/trunk/src/testcases/org/apache/poi/ss/formula/atp/TestNetworkdaysFunction.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/formula/atp/TestNetworkdaysFunction.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/ss/formula/atp/TestNetworkdaysFunction.java (original) +++ poi/trunk/src/testcases/org/apache/poi/ss/formula/atp/TestNetworkdaysFunction.java Fri Jan 8 23:50:02 2021 @@ -44,47 +44,47 @@ public class TestNetworkdaysFunction { private static final OperationEvaluationContext EC = new OperationEvaluationContext(null, null, 1, 1, 1, null); @Test - public void testFailWhenNoArguments() { + void testFailWhenNoArguments() { assertEquals(VALUE_INVALID, NetworkdaysFunction.instance.evaluate(new ValueEval[0], null)); } @Test - public void testFailWhenLessThan2Arguments() { + void testFailWhenLessThan2Arguments() { assertEquals(VALUE_INVALID, NetworkdaysFunction.instance.evaluate(new ValueEval[1], null)); } @Test - public void testFailWhenMoreThan3Arguments() { + void testFailWhenMoreThan3Arguments() { assertEquals(VALUE_INVALID, NetworkdaysFunction.instance.evaluate(new ValueEval[4], null)); } @Test - public void testFailWhenArgumentsAreNotDates() { + void testFailWhenArgumentsAreNotDates() { assertEquals(VALUE_INVALID, NetworkdaysFunction.instance.evaluate(new ValueEval[]{ new StringEval("Potato"), new StringEval("Cucumber") }, EC)); } @Test - public void testFailWhenStartDateAfterEndDate() { + void testFailWhenStartDateAfterEndDate() { assertEquals(NAME_INVALID, NetworkdaysFunction.instance.evaluate(new ValueEval[]{ new StringEval(END_DATE), new StringEval(STARTING_DATE) }, EC)); } @Test - public void testReturnNetworkdays() { + void testReturnNetworkdays() { assertEquals(108, (int) ((NumericValueEval) NetworkdaysFunction.instance.evaluate(new ValueEval[]{ new StringEval(STARTING_DATE), new StringEval(END_DATE) }, EC)).getNumberValue()); } @Test - public void testReturnNetworkdaysWithAHoliday() { + void testReturnNetworkdaysWithAHoliday() { assertEquals(107, (int) ((NumericValueEval) NetworkdaysFunction.instance.evaluate(new ValueEval[]{ new StringEval(STARTING_DATE), new StringEval(END_DATE), new StringEval(FIRST_HOLIDAY) }, EC)).getNumberValue()); } @Test - public void testReturnNetworkdaysWithManyHolidays() { + void testReturnNetworkdaysWithManyHolidays() { assertEquals(105, (int) ((NumericValueEval) NetworkdaysFunction.instance.evaluate(new ValueEval[]{ new StringEval(STARTING_DATE), new StringEval(END_DATE), new MockAreaEval(FIRST_HOLIDAY, SECOND_HOLIDAY, THIRD_HOLIDAY)}, EC)).getNumberValue()); Modified: poi/trunk/src/testcases/org/apache/poi/ss/formula/atp/TestPercentile.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/formula/atp/TestPercentile.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/ss/formula/atp/TestPercentile.java (original) +++ poi/trunk/src/testcases/org/apache/poi/ss/formula/atp/TestPercentile.java Fri Jan 8 23:50:02 2021 @@ -53,7 +53,7 @@ public class TestPercentile { } @Test - public void testBasic() { + void testBasic() { ValueEval[] values = { new NumberEval(210.128), new NumberEval(65.2182), new NumberEval(32.231), new NumberEval(12.123), new NumberEval(45.32) }; ValueEval percentile = new NumberEval(0.95); @@ -61,7 +61,7 @@ public class TestPercentile { } @Test - public void testBlanks() { + void testBlanks() { ValueEval[] values = { new NumberEval(210.128), new NumberEval(65.2182), new NumberEval(32.231), BlankEval.instance, new NumberEval(45.32) }; ValueEval percentile = new NumberEval(0.95); @@ -69,7 +69,7 @@ public class TestPercentile { } @Test - public void testUnusualArgs() { + void testUnusualArgs() { ValueEval[] values = { new NumberEval(1), new NumberEval(2), BoolEval.TRUE, BoolEval.FALSE }; ValueEval percentile = new NumberEval(0.95); confirmPercentile(percentile, values, 1.95); @@ -77,7 +77,7 @@ public class TestPercentile { //percentile has to be between 0 and 1 - here we test less than zero @Test - public void testUnusualArgs2() { + void testUnusualArgs2() { ValueEval[] values = { new NumberEval(1), new NumberEval(2), }; ValueEval percentile = new NumberEval(-0.1); confirmPercentile(percentile, values, ErrorEval.NUM_ERROR); @@ -85,7 +85,7 @@ public class TestPercentile { //percentile has to be between 0 and 1 - here we test more than 1 @Test - public void testUnusualArgs3() { + void testUnusualArgs3() { ValueEval[] values = { new NumberEval(1), new NumberEval(2) }; ValueEval percentile = new NumberEval(1.1); confirmPercentile(percentile, values, ErrorEval.NUM_ERROR); @@ -93,7 +93,7 @@ public class TestPercentile { //here we test where there are errors as part of inputs @Test - public void testErrors() { + void testErrors() { ValueEval[] values = { new NumberEval(1), ErrorEval.NAME_INVALID, new NumberEval(3), ErrorEval.DIV_ZERO, }; ValueEval percentile = new NumberEval(0.95); confirmPercentile(percentile, values, ErrorEval.NAME_INVALID); @@ -101,7 +101,7 @@ public class TestPercentile { //here we test where there are errors as part of inputs @Test - public void testErrors2() { + void testErrors2() { ValueEval[] values = { new NumberEval(1), new NumberEval(2), new NumberEval(3), ErrorEval.DIV_ZERO, }; ValueEval percentile = new NumberEval(0.95); confirmPercentile(percentile, values, ErrorEval.DIV_ZERO); Modified: poi/trunk/src/testcases/org/apache/poi/ss/formula/atp/TestRandBetween.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/formula/atp/TestRandBetween.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/ss/formula/atp/TestRandBetween.java (original) +++ poi/trunk/src/testcases/org/apache/poi/ss/formula/atp/TestRandBetween.java Fri Jan 8 23:50:02 2021 @@ -56,7 +56,7 @@ public class TestRandBetween { * Check where values are the same */ @Test - public void testRandBetweenSameValues() { + void testRandBetweenSameValues() { evaluator.clearAllCachedResultValues(); formulaCell.setCellFormula("RANDBETWEEN(1,1)"); evaluator.evaluateFormulaCell(formulaCell); @@ -69,7 +69,7 @@ public class TestRandBetween { } @Test - public void testRandBetweenLargeLongs() { + void testRandBetweenLargeLongs() { for (int i = 0; i < 100; i++) { evaluator.clearAllCachedResultValues(); formulaCell.setCellFormula("RANDBETWEEN(0,9999999999)"); @@ -85,7 +85,7 @@ public class TestRandBetween { * top value. */ @Test - public void testRandBetweenSpecialCase() { + void testRandBetweenSpecialCase() { bottomValueCell.setCellValue(0.05); topValueCell.setCellValue(0.1); formulaCell.setCellFormula("RANDBETWEEN($A$1,$B$1)"); @@ -116,7 +116,7 @@ public class TestRandBetween { * Check top value of BLANK which Excel will evaluate as 0 */ @Test - public void testRandBetweenTopBlank() { + void testRandBetweenTopBlank() { bottomValueCell.setCellValue(-1); topValueCell.setBlank(); formulaCell.setCellFormula("RANDBETWEEN($A$1,$B$1)"); @@ -129,7 +129,7 @@ public class TestRandBetween { * Check where input values are of wrong type */ @Test - public void testRandBetweenWrongInputTypes() { + void testRandBetweenWrongInputTypes() { // Check case where bottom input is of the wrong type bottomValueCell.setCellValue("STRING"); topValueCell.setCellValue(1); @@ -163,7 +163,7 @@ public class TestRandBetween { * Check case where bottom is greater than top */ @Test - public void testRandBetweenBottomGreaterThanTop() { + void testRandBetweenBottomGreaterThanTop() { // Check case where bottom is greater than top bottomValueCell.setCellValue(1); topValueCell.setCellValue(0); @@ -185,7 +185,7 @@ public class TestRandBetween { * Boundary check of Double MIN and MAX values */ @Test - public void testRandBetweenBoundaryCheck() { + void testRandBetweenBoundaryCheck() { bottomValueCell.setCellValue(Double.MIN_VALUE); topValueCell.setCellValue(Double.MAX_VALUE); formulaCell.setCellFormula("RANDBETWEEN($A$1,$B$1)"); Modified: poi/trunk/src/testcases/org/apache/poi/ss/formula/atp/TestWorkdayCalculator.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/formula/atp/TestWorkdayCalculator.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/ss/formula/atp/TestWorkdayCalculator.java (original) +++ poi/trunk/src/testcases/org/apache/poi/ss/formula/atp/TestWorkdayCalculator.java Fri Jan 8 23:50:02 2021 @@ -30,28 +30,28 @@ import org.junit.jupiter.api.Test; public class TestWorkdayCalculator { @Test - public void testCalculateWorkdaysShouldReturnJustWeekdaysWhenNoWeekend() { + void testCalculateWorkdaysShouldReturnJustWeekdaysWhenNoWeekend() { final double A_MONDAY = DateUtil.getExcelDate(d(2011, 12, 12)); final double A_FRIDAY = DateUtil.getExcelDate(d(2011, 12, 16)); assertEquals(5, WorkdayCalculator.instance.calculateWorkdays(A_MONDAY, A_FRIDAY, new double[0])); } @Test - public void testCalculateWorkdaysShouldReturnAllDaysButNoSaturdays() { + void testCalculateWorkdaysShouldReturnAllDaysButNoSaturdays() { final double A_WEDNESDAY = DateUtil.getExcelDate(d(2011, 12, 14)); final double A_SATURDAY = DateUtil.getExcelDate(d(2011, 12, 18)); assertEquals(3, WorkdayCalculator.instance.calculateWorkdays(A_WEDNESDAY, A_SATURDAY, new double[0])); } @Test - public void testCalculateWorkdaysShouldReturnAllDaysButNoSundays() { + void testCalculateWorkdaysShouldReturnAllDaysButNoSundays() { final double A_SUNDAY = DateUtil.getExcelDate(d(2011, 12, 11)); final double A_THURSDAY = DateUtil.getExcelDate(d(2011, 12, 15)); assertEquals(4, WorkdayCalculator.instance.calculateWorkdays(A_SUNDAY, A_THURSDAY, new double[0])); } @Test - public void testCalculateWorkdaysShouldReturnAllDaysButNoHolidays() { + void testCalculateWorkdaysShouldReturnAllDaysButNoHolidays() { final double A_MONDAY = DateUtil.getExcelDate(d(2011, 12, 12)); final double A_FRIDAY = DateUtil.getExcelDate(d(2011, 12, 16)); final double A_WEDNESDAY = DateUtil.getExcelDate(d(2011, 12, 14)); @@ -59,7 +59,7 @@ public class TestWorkdayCalculator { } @Test - public void testCalculateWorkdaysShouldIgnoreWeekendHolidays() { + void testCalculateWorkdaysShouldIgnoreWeekendHolidays() { final double A_FRIDAY = DateUtil.getExcelDate(d(2011, 12, 16)); final double A_SATURDAY = DateUtil.getExcelDate(d(2011, 12, 17)); final double A_SUNDAY = DateUtil.getExcelDate(d(2011, 12, 18)); @@ -68,60 +68,60 @@ public class TestWorkdayCalculator { } @Test - public void testCalculateWorkdaysOnSameDayShouldReturn1ForWeekdays() { + void testCalculateWorkdaysOnSameDayShouldReturn1ForWeekdays() { final double A_MONDAY = DateUtil.getExcelDate(d(2017, 1, 2)); assertEquals(1, WorkdayCalculator.instance.calculateWorkdays(A_MONDAY, A_MONDAY, new double[0])); } @Test - public void testCalculateWorkdaysOnSameDayShouldReturn0ForHolidays() { + void testCalculateWorkdaysOnSameDayShouldReturn0ForHolidays() { final double A_MONDAY = DateUtil.getExcelDate(d(2017, 1, 2)); assertEquals(0, WorkdayCalculator.instance.calculateWorkdays(A_MONDAY, A_MONDAY, new double[]{ A_MONDAY })); } @Test - public void testCalculateWorkdaysOnSameDayShouldReturn0ForWeekends() { + void testCalculateWorkdaysOnSameDayShouldReturn0ForWeekends() { final double A_SUNDAY = DateUtil.getExcelDate(d(2017, 1, 1)); assertEquals(0, WorkdayCalculator.instance.calculateWorkdays(A_SUNDAY, A_SUNDAY, new double[0])); } @Test - public void testCalculateWorkdaysNumberOfDays() { + void testCalculateWorkdaysNumberOfDays() { double start = 41553.0; int days = 1; assertEquals(d(2013, 10, 7), WorkdayCalculator.instance.calculateWorkdays(start, days, new double[0])); } @Test - public void testPastDaysOfWeekShouldReturn0Past0Saturdays() { + void testPastDaysOfWeekShouldReturn0Past0Saturdays() { final double A_WEDNESDAY = DateUtil.getExcelDate(d(2011, 12, 7)); final double A_FRIDAY = DateUtil.getExcelDate(d(2011, 12, 9)); assertEquals(0, WorkdayCalculator.instance.pastDaysOfWeek(A_WEDNESDAY, A_FRIDAY, SATURDAY)); } @Test - public void testPastDaysOfWeekShouldReturn1Past1Saturdays() { + void testPastDaysOfWeekShouldReturn1Past1Saturdays() { final double A_WEDNESDAY = DateUtil.getExcelDate(d(2011, 12, 7)); final double A_SUNDAY = DateUtil.getExcelDate(d(2011, 12, 11)); assertEquals(1, WorkdayCalculator.instance.pastDaysOfWeek(A_WEDNESDAY, A_SUNDAY, SATURDAY)); } @Test - public void testPastDaysOfWeekShouldReturn2Past2Saturdays() { + void testPastDaysOfWeekShouldReturn2Past2Saturdays() { final double A_THURSDAY = DateUtil.getExcelDate(d(2011, 12, 8)); final double A_MONDAY = DateUtil.getExcelDate(d(2011, 12, 19)); assertEquals(2, WorkdayCalculator.instance.pastDaysOfWeek(A_THURSDAY, A_MONDAY, SATURDAY)); } @Test - public void testPastDaysOfWeekShouldReturn1BeginningFromASaturday() { + void testPastDaysOfWeekShouldReturn1BeginningFromASaturday() { final double A_SATURDAY = DateUtil.getExcelDate(d(2011, 12, 10)); final double A_SUNDAY = DateUtil.getExcelDate(d(2011, 12, 11)); assertEquals(1, WorkdayCalculator.instance.pastDaysOfWeek(A_SATURDAY, A_SUNDAY, SATURDAY)); } @Test - public void testPastDaysOfWeekShouldReturn1EndingAtASaturday() { + void testPastDaysOfWeekShouldReturn1EndingAtASaturday() { final double A_THURSDAY = DateUtil.getExcelDate(d(2011, 12, 8)); final double A_SATURDAY = DateUtil.getExcelDate(d(2011, 12, 10)); assertEquals(1, WorkdayCalculator.instance.pastDaysOfWeek(A_THURSDAY, A_SATURDAY, SATURDAY)); @@ -133,7 +133,7 @@ public class TestWorkdayCalculator { } @Test - public void testCalculateNonWeekendHolidays() { + void testCalculateNonWeekendHolidays() { final double start = DateUtil.getExcelDate(d(2016, 12, 24)); final double end = DateUtil.getExcelDate(d(2016, 12, 31)); final double holiday1 = DateUtil.getExcelDate(d(2016, 12, 25)); @@ -143,7 +143,7 @@ public class TestWorkdayCalculator { } @Test - public void testCalculateNonWeekendHolidaysOneDay() { + void testCalculateNonWeekendHolidaysOneDay() { final double start = DateUtil.getExcelDate(d(2016, 12, 26)); final double end = DateUtil.getExcelDate(d(2016, 12, 26)); final double holiday1 = DateUtil.getExcelDate(d(2016, 12, 25)); Modified: poi/trunk/src/testcases/org/apache/poi/ss/formula/atp/TestWorkdayFunction.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/formula/atp/TestWorkdayFunction.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/ss/formula/atp/TestWorkdayFunction.java (original) +++ poi/trunk/src/testcases/org/apache/poi/ss/formula/atp/TestWorkdayFunction.java Fri Jan 8 23:50:02 2021 @@ -49,31 +49,31 @@ public class TestWorkdayFunction { private static final OperationEvaluationContext EC = new OperationEvaluationContext(null, null, 1, 1, 1, null); @Test - public void testFailWhenNoArguments() { + void testFailWhenNoArguments() { ValueEval[] ve = new ValueEval[0]; assertEquals(VALUE_INVALID, WorkdayFunction.instance.evaluate(ve, null)); } @Test - public void testFailWhenLessThan2Arguments() { + void testFailWhenLessThan2Arguments() { ValueEval[] ve = new ValueEval[1]; assertEquals(VALUE_INVALID, WorkdayFunction.instance.evaluate(ve, null)); } @Test - public void testFailWhenMoreThan3Arguments() { + void testFailWhenMoreThan3Arguments() { ValueEval[] ve = new ValueEval[4]; assertEquals(VALUE_INVALID, WorkdayFunction.instance.evaluate(ve, null)); } @Test - public void testFailWhenArgumentsAreNotDatesNorNumbers() { + void testFailWhenArgumentsAreNotDatesNorNumbers() { ValueEval[] ve = {new StringEval("Potato"), new StringEval("Cucumber")}; assertEquals(VALUE_INVALID, WorkdayFunction.instance.evaluate(ve, EC)); } @Test - public void testReturnWorkdays() { + void testReturnWorkdays() { Calendar expCal = LocaleUtil.getLocaleCalendar(2009, 3, 30); Date expDate = expCal.getTime(); ValueEval[] ve = {new StringEval(STARTING_DATE), new NumberEval(151)}; @@ -82,7 +82,7 @@ public class TestWorkdayFunction { } @Test - public void testReturnWorkdaysSpanningAWeekendSubtractingDays() { + void testReturnWorkdaysSpanningAWeekendSubtractingDays() { Calendar expCal = LocaleUtil.getLocaleCalendar(2013, 8, 27); Date expDate = expCal.getTime(); @@ -95,7 +95,7 @@ public class TestWorkdayFunction { } @Test - public void testReturnWorkdaysSpanningAWeekendAddingDays() { + void testReturnWorkdaysSpanningAWeekendAddingDays() { Calendar expCal = LocaleUtil.getLocaleCalendar(2013, 8, 30); Date expDate = expCal.getTime(); @@ -108,7 +108,7 @@ public class TestWorkdayFunction { } @Test - public void testReturnWorkdaysWhenStartIsWeekendAddingDays() { + void testReturnWorkdaysWhenStartIsWeekendAddingDays() { Calendar expCal = LocaleUtil.getLocaleCalendar(2013, 9, 7); Date expDate = expCal.getTime(); @@ -121,7 +121,7 @@ public class TestWorkdayFunction { } @Test - public void testReturnWorkdaysWhenStartIsWeekendSubtractingDays() { + void testReturnWorkdaysWhenStartIsWeekendSubtractingDays() { Calendar expCal = LocaleUtil.getLocaleCalendar(2013, 9, 4); Date expDate = expCal.getTime(); @@ -134,7 +134,7 @@ public class TestWorkdayFunction { } @Test - public void testReturnWorkdaysWithDaysTruncated() { + void testReturnWorkdaysWithDaysTruncated() { Calendar expCal = LocaleUtil.getLocaleCalendar(2009, 3, 30); Date expDate = expCal.getTime(); @@ -146,7 +146,7 @@ public class TestWorkdayFunction { } @Test - public void testReturnRetroativeWorkday() { + void testReturnRetroativeWorkday() { Calendar expCal = LocaleUtil.getLocaleCalendar(2008, 8, 23); Date expDate = expCal.getTime(); @@ -158,7 +158,7 @@ public class TestWorkdayFunction { } @Test - public void testReturnNetworkdaysWithManyHolidays() { + void testReturnNetworkdaysWithManyHolidays() { Calendar expCal = LocaleUtil.getLocaleCalendar(2009, 4, 5); Date expDate = expCal.getTime(); Modified: poi/trunk/src/testcases/org/apache/poi/ss/formula/atp/TestYearFracCalculator.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/formula/atp/TestYearFracCalculator.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/ss/formula/atp/TestYearFracCalculator.java (original) +++ poi/trunk/src/testcases/org/apache/poi/ss/formula/atp/TestYearFracCalculator.java Fri Jan 8 23:50:02 2021 @@ -32,7 +32,7 @@ import org.junit.jupiter.api.Test; public final class TestYearFracCalculator { @Test - public void testBasis1() { + void testBasis1() { confirm(md(1999, 1, 1), md(1999, 4, 5), 1, 0.257534247); confirm(md(1999, 4, 1), md(1999, 4, 5), 1, 0.010958904); confirm(md(1999, 4, 1), md(1999, 4, 4), 1, 0.008219178); Modified: poi/trunk/src/testcases/org/apache/poi/ss/formula/atp/TestYearFracCalculatorFromSpreadsheet.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/formula/atp/TestYearFracCalculatorFromSpreadsheet.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/ss/formula/atp/TestYearFracCalculatorFromSpreadsheet.java (original) +++ poi/trunk/src/testcases/org/apache/poi/ss/formula/atp/TestYearFracCalculatorFromSpreadsheet.java Fri Jan 8 23:50:02 2021 @@ -52,7 +52,7 @@ public final class TestYearFracCalculato } @Test - public void testAll() throws Exception { + void testAll() throws Exception { HSSFWorkbook wb = HSSFTestDataSamples.openSampleWorkbook("yearfracExamples.xls"); HSSFSheet sheet = wb.getSheetAt(0); Modified: poi/trunk/src/testcases/org/apache/poi/ss/formula/constant/TestConstantValueParser.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/formula/constant/TestConstantValueParser.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/ss/formula/constant/TestConstantValueParser.java (original) +++ poi/trunk/src/testcases/org/apache/poi/ss/formula/constant/TestConstantValueParser.java Fri Jan 8 23:50:02 2021 @@ -45,13 +45,13 @@ public final class TestConstantValuePars "10 07 00 00 00 00 00 00 00"); @Test - public void testGetEncodedSize() { + void testGetEncodedSize() { int actual = ConstantValueParser.getEncodedSize(SAMPLE_VALUES); assertEquals(51, actual); } @Test - public void testEncode() { + void testEncode() { int size = ConstantValueParser.getEncodedSize(SAMPLE_VALUES); byte[] data = new byte[size]; @@ -61,7 +61,7 @@ public final class TestConstantValuePars } @Test - public void testDecode() { + void testDecode() { LittleEndianInput in = TestcaseRecordInputStream.createLittleEndian(SAMPLE_ENCODING); Object[] values = ConstantValueParser.parse(in, 4); Modified: poi/trunk/src/testcases/org/apache/poi/ss/formula/eval/BaseTestCircularReferences.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/formula/eval/BaseTestCircularReferences.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/ss/formula/eval/BaseTestCircularReferences.java (original) +++ poi/trunk/src/testcases/org/apache/poi/ss/formula/eval/BaseTestCircularReferences.java Fri Jan 8 23:50:02 2021 @@ -76,7 +76,7 @@ public abstract class BaseTestCircularRe * "INDEX() formula cannot contain its own location in the data array range" */ @Test - public void testIndexFormula() throws IOException { + void testIndexFormula() throws IOException { try (Workbook wb = _testDataProvider.createWorkbook()) { Sheet sheet = wb.createSheet("Sheet1"); @@ -105,7 +105,7 @@ public abstract class BaseTestCircularRe * Cell A1 has formula "=A1" */ @Test - public void testSimpleCircularReference() throws IOException { + void testSimpleCircularReference() throws IOException { try (Workbook wb = _testDataProvider.createWorkbook()) { Sheet sheet = wb.createSheet("Sheet1"); @@ -124,7 +124,7 @@ public abstract class BaseTestCircularRe * A1=B1, B1=C1, C1=D1, D1=A1 */ @Test - public void testMultiLevelCircularReference() throws IOException { + void testMultiLevelCircularReference() throws IOException { try (Workbook wb = _testDataProvider.createWorkbook()) { Sheet sheet = wb.createSheet("Sheet1"); @@ -142,7 +142,7 @@ public abstract class BaseTestCircularRe } @Test - public void testIntermediateCircularReferenceResults_bug46898() throws IOException { + void testIntermediateCircularReferenceResults_bug46898() throws IOException { try (Workbook wb = _testDataProvider.createWorkbook()) { Sheet sheet = wb.createSheet("Sheet1"); Modified: poi/trunk/src/testcases/org/apache/poi/ss/formula/eval/TestAreaEval.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/formula/eval/TestAreaEval.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/ss/formula/eval/TestAreaEval.java (original) +++ poi/trunk/src/testcases/org/apache/poi/ss/formula/eval/TestAreaEval.java Fri Jan 8 23:50:02 2021 @@ -33,7 +33,7 @@ import org.junit.jupiter.api.Test; public final class TestAreaEval { @Test - public void testGetValue_bug44950() { + void testGetValue_bug44950() { // TODO - this test probably isn't testing much anymore AreaPtg ptg = new AreaPtg(new AreaReference("B2:D3", SpreadsheetVersion.EXCEL97)); NumberEval one = new NumberEval(1); Modified: poi/trunk/src/testcases/org/apache/poi/ss/formula/eval/TestDivideEval.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/formula/eval/TestDivideEval.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/ss/formula/eval/TestDivideEval.java (original) +++ poi/trunk/src/testcases/org/apache/poi/ss/formula/eval/TestDivideEval.java Fri Jan 8 23:50:02 2021 @@ -39,7 +39,7 @@ public final class TestDivideEval { } @Test - public void testBasic() { + void testBasic() { confirm(new NumberEval(5), new NumberEval(2), 2.5); confirm(new NumberEval(3), new NumberEval(16), 0.1875); confirm(new NumberEval(-150), new NumberEval(-15), 10.0); @@ -48,14 +48,14 @@ public final class TestDivideEval { } @Test - public void test1x1Area() { + void test1x1Area() { AreaEval ae0 = EvalFactory.createAreaEval("B2:B2", new ValueEval[] { new NumberEval(50), }); AreaEval ae1 = EvalFactory.createAreaEval("C2:C2", new ValueEval[] { new NumberEval(10), }); confirm(ae0, ae1, 5); } @Test - public void testDivZero() { + void testDivZero() { ValueEval[] args = { new NumberEval(5), NumberEval.ZERO, }; Modified: poi/trunk/src/testcases/org/apache/poi/ss/formula/eval/TestEqualEval.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/formula/eval/TestEqualEval.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/ss/formula/eval/TestEqualEval.java (original) +++ poi/trunk/src/testcases/org/apache/poi/ss/formula/eval/TestEqualEval.java Fri Jan 8 23:50:02 2021 @@ -34,7 +34,7 @@ public final class TestEqualEval { * The value from a 1x1 area should be taken immediately, regardless of srcRow and srcCol */ @Test - public void test1x1AreaOperand() { + void test1x1AreaOperand() { ValueEval[] values = { BoolEval.FALSE, }; ValueEval[] args = { @@ -51,7 +51,7 @@ public final class TestEqualEval { * Empty string is equal to blank */ @Test - public void testBlankEqualToEmptyString() { + void testBlankEqualToEmptyString() { ValueEval[] args = { new StringEval(""), @@ -67,7 +67,7 @@ public final class TestEqualEval { * Test for bug 46613 (observable at svn r737248) */ @Test - public void testStringInsensitive_bug46613() { + void testStringInsensitive_bug46613() { assertTrue(evalStringCmp("abc", "aBc", EvalInstances.Equal)); assertTrue(evalStringCmp("ABC", "azz", EvalInstances.LessThan)); assertTrue(evalStringCmp("abc", "AZZ", EvalInstances.LessThan)); @@ -87,7 +87,7 @@ public final class TestEqualEval { } @Test - public void testBooleanCompares() { + void testBooleanCompares() { confirmCompares(BoolEval.TRUE, new StringEval("TRUE"), +1); confirmCompares(BoolEval.TRUE, new NumberEval(1.0), +1); confirmCompares(BoolEval.TRUE, BoolEval.TRUE, 0); @@ -130,7 +130,7 @@ public final class TestEqualEval { * See {@link TestMinusZeroResult} for more specific tests regarding -0.0. */ @Test - public void testZeroEquality_bug47198() { + void testZeroEquality_bug47198() { NumberEval zero = new NumberEval(0.0); NumberEval mZero = (NumberEval) evaluate(UnaryMinusEval.instance, new ValueEval[] { zero, }, 0, 0); assertNotEquals(0x8000000000000000L, Double.doubleToLongBits(mZero.getNumberValue()), @@ -141,7 +141,7 @@ public final class TestEqualEval { } @Test - public void testRounding_bug47598() { + void testRounding_bug47598() { double x = 1+1.0028-0.9973; // should be 1.0055, but has IEEE rounding assertNotEquals(1.0055, x, 0.0); Modified: poi/trunk/src/testcases/org/apache/poi/ss/formula/eval/TestExternalFunction.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/formula/eval/TestExternalFunction.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/ss/formula/eval/TestExternalFunction.java (original) +++ poi/trunk/src/testcases/org/apache/poi/ss/formula/eval/TestExternalFunction.java Fri Jan 8 23:50:02 2021 @@ -56,7 +56,7 @@ public final class TestExternalFunction * Checks that an external function can get invoked from the formula evaluator. */ @Test - public void testInvoke() throws IOException { + void testInvoke() throws IOException { try (HSSFWorkbook wb = HSSFTestDataSamples.openSampleWorkbook("testNames.xls")) { HSSFSheet sheet = wb.getSheetAt(0); Modified: poi/trunk/src/testcases/org/apache/poi/ss/formula/eval/TestFormulaBugs.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/formula/eval/TestFormulaBugs.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/ss/formula/eval/TestFormulaBugs.java (original) +++ poi/trunk/src/testcases/org/apache/poi/ss/formula/eval/TestFormulaBugs.java Fri Jan 8 23:50:02 2021 @@ -46,7 +46,7 @@ public final class TestFormulaBugs { * added <em>long</em> after the relevant functionality was fixed. */ @Test - public void test27349() throws Exception { + void test27349() throws Exception { // 27349-vlookupAcrossSheets.xls is bugzilla/attachment.cgi?id=10622 InputStream is = HSSFTestDataSamples.openSampleFileStream("27349-vlookupAcrossSheets.xls"); // original bug may have thrown exception here, @@ -78,7 +78,7 @@ public final class TestFormulaBugs { * seems to be a duplicate of 24925 */ @Test - public void test27405() throws Exception { + void test27405() throws Exception { Workbook wb = new HSSFWorkbook(); Sheet sheet = wb.createSheet("input"); // input row 0 @@ -127,7 +127,7 @@ public final class TestFormulaBugs { * Bug 42448 - Can't parse SUMPRODUCT(A!C7:A!C67, B8:B68) / B69 <p> */ @Test - public void test42448() throws IOException { + void test42448() throws IOException { try (Workbook wb = new HSSFWorkbook()) { Sheet sheet1 = wb.createSheet("Sheet1"); @@ -178,7 +178,7 @@ public final class TestFormulaBugs { } @Test - public void test55032() throws IOException { + void test55032() throws IOException { Workbook wb = new HSSFWorkbook(); Sheet sheet = wb.createSheet("input"); @@ -199,7 +199,7 @@ public final class TestFormulaBugs { // bug 52063: LOOKUP(2-arg) and LOOKUP(3-arg) // FIXME: This could be moved into LookupFunctionsTestCaseData.xls, which is tested by TestLookupFunctionsFromSpreadsheet.java @Test - public void testLookupFormula() throws Exception { + void testLookupFormula() throws Exception { Workbook wb = new HSSFWorkbook(); Sheet sheet = wb.createSheet("52063"); Modified: poi/trunk/src/testcases/org/apache/poi/ss/formula/eval/TestMinusZeroResult.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/formula/eval/TestMinusZeroResult.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/ss/formula/eval/TestMinusZeroResult.java (original) +++ poi/trunk/src/testcases/org/apache/poi/ss/formula/eval/TestMinusZeroResult.java Fri Jan 8 23:50:02 2021 @@ -41,7 +41,7 @@ public final class TestMinusZeroResult { private static final double MINUS_ZERO = -0.0; @Test - public void testSimpleOperators() { + void testSimpleOperators() { // unary plus is a no-op checkEval(MINUS_ZERO, UnaryPlusEval.instance, MINUS_ZERO); @@ -63,14 +63,14 @@ public final class TestMinusZeroResult { * gets to the comparison operator) */ @Test - public void testComparisonOperators() { + void testComparisonOperators() { checkEval(false, EvalInstances.Equal, 0.0, MINUS_ZERO); checkEval(true, EvalInstances.GreaterThan, 0.0, MINUS_ZERO); checkEval(true, EvalInstances.LessThan, MINUS_ZERO, 0.0); } @Test - public void testTextRendering() { + void testTextRendering() { confirmTextRendering(MINUS_ZERO); // sub-normal negative numbers also display as '-0' confirmTextRendering(Double.longBitsToDouble(0x8000100020003000L)); @@ -107,7 +107,7 @@ public final class TestMinusZeroResult { * Not really a POI test - just shows similar behaviour of '-0.0' in Java. */ @Test - public void testJava() { + void testJava() { assertEquals(0x8000000000000000L, Double.doubleToLongBits(MINUS_ZERO)); // The simple operators consider all zeros to be the same Modified: poi/trunk/src/testcases/org/apache/poi/ss/formula/eval/TestMissingArgEval.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/formula/eval/TestMissingArgEval.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/ss/formula/eval/TestMissingArgEval.java (original) +++ poi/trunk/src/testcases/org/apache/poi/ss/formula/eval/TestMissingArgEval.java Fri Jan 8 23:50:02 2021 @@ -36,7 +36,7 @@ import org.junit.jupiter.api.Test; public final class TestMissingArgEval { @Test - public void testEvaluateMissingArgs() throws IOException { + void testEvaluateMissingArgs() throws IOException { try (HSSFWorkbook wb = new HSSFWorkbook()) { HSSFFormulaEvaluator fe = new HSSFFormulaEvaluator(wb); HSSFSheet sheet = wb.createSheet("Sheet1"); @@ -57,7 +57,7 @@ public final class TestMissingArgEval { } @Test - public void testCompareMissingArgs() throws IOException { + void testCompareMissingArgs() throws IOException { try (HSSFWorkbook wb = new HSSFWorkbook()) { HSSFFormulaEvaluator fe = new HSSFFormulaEvaluator(wb); HSSFSheet sheet = wb.createSheet("Sheet1"); @@ -117,7 +117,7 @@ public final class TestMissingArgEval { } @Test - public void testCountFuncs() throws IOException { + void testCountFuncs() throws IOException { try (HSSFWorkbook wb = new HSSFWorkbook()) { HSSFFormulaEvaluator fe = new HSSFFormulaEvaluator(wb); HSSFSheet sheet = wb.createSheet("Sheet1"); Modified: poi/trunk/src/testcases/org/apache/poi/ss/formula/eval/TestMultiSheetEval.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/formula/eval/TestMultiSheetEval.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/ss/formula/eval/TestMultiSheetEval.java (original) +++ poi/trunk/src/testcases/org/apache/poi/ss/formula/eval/TestMultiSheetEval.java Fri Jan 8 23:50:02 2021 @@ -124,7 +124,7 @@ public final class TestMultiSheetEval { @ParameterizedTest @MethodSource("data") - public void testFunction(String testName, String functionName, Cell expected, Row testRow) { + void testFunction(String testName, String functionName, Cell expected, Row testRow) { Cell c = testRow.getCell(SS.COLUMN_INDEX_ACTUAL_VALUE); if (c == null || c.getCellType() != CellType.FORMULA) { Modified: poi/trunk/src/testcases/org/apache/poi/ss/formula/eval/TestOperandResolver.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/formula/eval/TestOperandResolver.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/ss/formula/eval/TestOperandResolver.java (original) +++ poi/trunk/src/testcases/org/apache/poi/ss/formula/eval/TestOperandResolver.java Fri Jan 8 23:50:02 2021 @@ -31,14 +31,14 @@ import org.junit.jupiter.api.Test; */ public final class TestOperandResolver { @Test - public void testParseDouble_bug48472() { + void testParseDouble_bug48472() { // bug 48472 - StringIndexOutOfBoundsException Double resolvedValue = OperandResolver.parseDouble("-"); assertNull(resolvedValue); } @Test - public void testParseDouble_bug49723() { + void testParseDouble_bug49723() { String value = ".1"; Double resolvedValue = OperandResolver.parseDouble(value); @@ -49,7 +49,7 @@ public final class TestOperandResolver { * Tests that a list of valid strings all return a non null value from {@link OperandResolver#parseDouble(String)} */ @Test - public void testParseDoubleValidStrings() { + void testParseDoubleValidStrings() { String[] values = new String[]{".19", "0.19", "1.9", "1E4", "-.19", "-0.19", "8.5","-1E4", ".5E6","+1.5","+1E5", " +1E5 ", " 123 ", "1E4", "-123" }; @@ -64,7 +64,7 @@ public final class TestOperandResolver { * Tests that a list of invalid strings all return null from {@link OperandResolver#parseDouble(String)} */ @Test - public void testParseDoubleInvalidStrings() { + void testParseDoubleInvalidStrings() { String[] values = new String[]{"-", "ABC", "-X", "1E5a", "Infinity", "NaN", ".5F", "1,000"}; for (String value : values) { @@ -73,7 +73,7 @@ public final class TestOperandResolver { } @Test - public void testCoerceDateStringToNumber() throws EvaluationException { + void testCoerceDateStringToNumber() throws EvaluationException { Map<String, Double> values = new LinkedHashMap<>(); values.put("2019/1/18", 43483.); values.put("01/18/2019", 43483.); @@ -86,7 +86,7 @@ public final class TestOperandResolver { } @Test - public void testCoerceTimeStringToNumber() throws EvaluationException { + void testCoerceTimeStringToNumber() throws EvaluationException { Map<String, Double> values = new LinkedHashMap<>(); values.put("00:00", 0.0); values.put("12:00", 0.5); Modified: poi/trunk/src/testcases/org/apache/poi/ss/formula/eval/TestPercentEval.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/formula/eval/TestPercentEval.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/ss/formula/eval/TestPercentEval.java (original) +++ poi/trunk/src/testcases/org/apache/poi/ss/formula/eval/TestPercentEval.java Fri Jan 8 23:50:02 2021 @@ -48,7 +48,7 @@ public final class TestPercentEval { } @Test - public void testBasic() { + void testBasic() { confirm(new NumberEval(5), 0.05); confirm(new NumberEval(3000), 30.0); confirm(new NumberEval(-150), -1.5); @@ -57,13 +57,13 @@ public final class TestPercentEval { } @Test - public void test1x1Area() { + void test1x1Area() { AreaEval ae = EvalFactory.createAreaEval("B2:B2", new ValueEval[] { new NumberEval(50), }); confirm(ae, 0.5); } @Test - public void testInSpreadSheet() throws IOException { + void testInSpreadSheet() throws IOException { try (HSSFWorkbook wb = new HSSFWorkbook()) { HSSFSheet sheet = wb.createSheet("Sheet1"); HSSFRow row = sheet.createRow(0); Modified: poi/trunk/src/testcases/org/apache/poi/ss/formula/eval/TestPowerEval.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/formula/eval/TestPowerEval.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/ss/formula/eval/TestPowerEval.java (original) +++ poi/trunk/src/testcases/org/apache/poi/ss/formula/eval/TestPowerEval.java Fri Jan 8 23:50:02 2021 @@ -33,14 +33,14 @@ import org.junit.jupiter.api.Test; */ public final class TestPowerEval { @Test - public void testPositiveValues() { + void testPositiveValues() { confirm(0, 0, 1); confirm(1, 1, 0); confirm(9, 3, 2); } @Test - public void testNegativeValues() { + void testNegativeValues() { confirm(-1, -1, 1); confirm(1, 1, -1); confirm(1, -10, 0); @@ -48,22 +48,22 @@ public final class TestPowerEval { } @Test - public void testPositiveDecimalValues() { + void testPositiveDecimalValues() { confirm(3, 27, (1/3.0)); } @Test - public void testNegativeDecimalValues() { + void testNegativeDecimalValues() { confirm(-3, -27, (1/3.0)); } @Test - public void testErrorValues() { + void testErrorValues() { confirmError(-1.00001, 1.1); } @Test - public void testInSpreadSheet() { + void testInSpreadSheet() { HSSFWorkbook wb = new HSSFWorkbook(); HSSFSheet sheet = wb.createSheet("Sheet1"); HSSFRow row = sheet.createRow(0); Modified: poi/trunk/src/testcases/org/apache/poi/ss/formula/eval/TestRangeEval.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/formula/eval/TestRangeEval.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/ss/formula/eval/TestRangeEval.java (original) +++ poi/trunk/src/testcases/org/apache/poi/ss/formula/eval/TestRangeEval.java Fri Jan 8 23:50:02 2021 @@ -41,7 +41,7 @@ import org.junit.jupiter.api.Test; */ public final class TestRangeEval { @Test - public void testPermutations() { + void testPermutations() { confirm("B3", "D7", "B3:D7"); confirm("B1", "B1", "B1:B1"); @@ -136,7 +136,7 @@ public final class TestRangeEval { } @Test - public void testRangeUsingOffsetFunc_bug46948() { + void testRangeUsingOffsetFunc_bug46948() { HSSFWorkbook wb = new HSSFWorkbook(); HSSFRow row = wb.createSheet("Sheet1").createRow(0); HSSFCell cellA1 = row.createCell(0); Modified: poi/trunk/src/testcases/org/apache/poi/ss/formula/eval/TestUnaryPlusEval.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/formula/eval/TestUnaryPlusEval.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/ss/formula/eval/TestUnaryPlusEval.java (original) +++ poi/trunk/src/testcases/org/apache/poi/ss/formula/eval/TestUnaryPlusEval.java Fri Jan 8 23:50:02 2021 @@ -34,7 +34,7 @@ public final class TestUnaryPlusEval { * The code for handling column operands had been copy-pasted from the row handling code. */ @Test - public void testColumnOperand() { + void testColumnOperand() { short firstRow = (short)8; short lastRow = (short)12; --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@poi.apache.org For additional commands, e-mail: commits-h...@poi.apache.org