Modified: poi/trunk/src/testcases/org/apache/poi/hssf/eventmodel/TestEventRecordFactory.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/eventmodel/TestEventRecordFactory.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/eventmodel/TestEventRecordFactory.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/eventmodel/TestEventRecordFactory.java Fri Jan 8 23:50:02 2021 @@ -60,7 +60,7 @@ public final class TestEventRecordFactor * tests that the records can be processed and properly return values. */ @Test - public void testProcessRecords() { + void testProcessRecords() { final boolean[] wascalled = { false }; // hack to pass boolean by ref into inner class ERFListener listener = rec -> { @@ -94,7 +94,7 @@ public final class TestEventRecordFactor * constructed record in the simple case. */ @Test - public void testCreateRecord() { + void testCreateRecord() { BOFRecord bof = new BOFRecord(); bof.setBuild((short)0); bof.setBuildYear((short)1999); @@ -122,7 +122,7 @@ public final class TestEventRecordFactor // @NotImplemented // @Test // @Disabled - // public void testCreateContinuedRecord() { + // void testCreateContinuedRecord() { // } @@ -135,7 +135,7 @@ public final class TestEventRecordFactor * */ @Test - public void testContinuedUnknownRecord() throws IOException { + void testContinuedUnknownRecord() throws IOException { ByteArrayOutputStream bos = new ByteArrayOutputStream(); for (byte[] b : CONTINUE_DATA) { bos.write(b);
Modified: poi/trunk/src/testcases/org/apache/poi/hssf/eventusermodel/TestEventWorkbookBuilder.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/eventusermodel/TestEventWorkbookBuilder.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/eventusermodel/TestEventWorkbookBuilder.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/eventusermodel/TestEventWorkbookBuilder.java Fri Jan 8 23:50:02 2021 @@ -67,20 +67,20 @@ public final class TestEventWorkbookBuil } @Test - public void testBasics() { + void testBasics() { assertNotNull(listener.getSSTRecord()); assertNotNull(listener.getBoundSheetRecords()); assertNotNull(listener.getExternSheetRecords()); } @Test - public void testGetStubWorkbooks() { + void testGetStubWorkbooks() { assertNotNull(listener.getStubWorkbook()); assertNotNull(listener.getStubHSSFWorkbook()); } @Test - public void testContents() { + void testContents() { assertEquals(2, listener.getSSTRecord().getNumStrings()); assertEquals(3, listener.getBoundSheetRecords().length); assertEquals(1, listener.getExternSheetRecords().length); @@ -94,7 +94,7 @@ public final class TestEventWorkbookBuil } @Test - public void testFormulas() { + void testFormulas() { // Check our formula records assertEquals(6, fRecs.size()); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/eventusermodel/TestFormatTrackingHSSFListener.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/eventusermodel/TestFormatTrackingHSSFListener.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/eventusermodel/TestFormatTrackingHSSFListener.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/eventusermodel/TestFormatTrackingHSSFListener.java Fri Jan 8 23:50:02 2021 @@ -52,7 +52,7 @@ public final class TestFormatTrackingHSS } @Test - public void testFormats() throws Exception { + void testFormats() throws Exception { processFile("MissingBits.xls"); assertEquals("_(* #,##0_);_(* (#,##0);_(* \"-\"_);_(@_)", listener.getFormatString(41)); @@ -69,7 +69,7 @@ public final class TestFormatTrackingHSS * want to check the exact strings! */ @Test - public void testTurnToString() throws Exception { + void testTurnToString() throws Exception { String[] files = new String[] { "45365.xls", "45365-2.xls", "MissingBits.xls" }; Modified: poi/trunk/src/testcases/org/apache/poi/hssf/eventusermodel/TestHSSFEventFactory.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/eventusermodel/TestHSSFEventFactory.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/eventusermodel/TestHSSFEventFactory.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/eventusermodel/TestHSSFEventFactory.java Fri Jan 8 23:50:02 2021 @@ -61,7 +61,7 @@ public final class TestHSSFEventFactory } @Test - public void testWithMissingRecords() throws Exception { + void testWithMissingRecords() throws Exception { openSample("SimpleWithSkip.xls"); @@ -78,7 +78,7 @@ public final class TestHSSFEventFactory } @Test - public void testWithCrazyContinueRecords() throws Exception { + void testWithCrazyContinueRecords() throws Exception { // Some files have crazy ordering of their continue records // Check that we don't break on them (bug #42844) @@ -105,26 +105,26 @@ public final class TestHSSFEventFactory */ @Test @SuppressWarnings("java:S2699") - public void testUnknownContinueRecords() throws Exception { + void testUnknownContinueRecords() throws Exception { openSample("42844.xls"); } @Test @SuppressWarnings("java:S2699") - public void testWithDifferentWorkbookName() throws Exception { + void testWithDifferentWorkbookName() throws Exception { openSample("BOOK_in_capitals.xls"); openSample("WORKBOOK_in_capitals.xls"); } @Test @SuppressWarnings("java:S2699") - public void testWithPasswordProtectedWorkbooksNoPass() { + void testWithPasswordProtectedWorkbooksNoPass() { // Without a password, can't be read assertThrows(EncryptedDocumentException.class, () -> openSample("xor-encryption-abc.xls")); } @Test - public void testWithPasswordProtectedWorkbooks() throws Exception { + void testWithPasswordProtectedWorkbooks() throws Exception { // With the password, is properly processed Biff8EncryptionKey.setCurrentUserPassword("abc"); try { Modified: poi/trunk/src/testcases/org/apache/poi/hssf/eventusermodel/TestMissingRecordAwareHSSFListener.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/eventusermodel/TestMissingRecordAwareHSSFListener.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/eventusermodel/TestMissingRecordAwareHSSFListener.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/eventusermodel/TestMissingRecordAwareHSSFListener.java Fri Jan 8 23:50:02 2021 @@ -64,7 +64,7 @@ public final class TestMissingRecordAwar } @Test - public void testMissingRowRecords() throws IOException { + void testMissingRowRecords() throws IOException { readRecords("MissingBits.xls"); // We have rows 0, 1, 2, 20 and 21 @@ -96,7 +96,7 @@ public final class TestMissingRecordAwar // Make sure we don't put in any extra new lines that aren't already there @Test - public void testNoExtraNewLines() throws IOException { + void testNoExtraNewLines() throws IOException { // Load a different file // This file has has something in lines 1-33 readRecords("MRExtraLines.xls"); @@ -117,7 +117,7 @@ public final class TestMissingRecordAwar * Make sure that the presence of shared formulas does not cause extra end-of-row records. */ @Test - public void testEndOfRow_bug45672() throws IOException { + void testEndOfRow_bug45672() throws IOException { readRecords("ex45672.xls"); assertEquals(1, matches(r -> r instanceof SharedFormulaRecord)); assertEquals(1, matches(r -> r instanceof LastCellOfRowDummyRecord)); @@ -128,7 +128,7 @@ public final class TestMissingRecordAwar * Check that we don't have any MulBlankRecords, but do have lots of BlankRecords */ @Test - public void testMulBlankHandling() throws IOException { + void testMulBlankHandling() throws IOException { readRecords("45672.xls"); assertEquals(20, matches(r -> r instanceof BlankRecord)); assertEquals(2, matches(r -> r instanceof LastCellOfRowDummyRecord)); @@ -136,14 +136,14 @@ public final class TestMissingRecordAwar } @Test - public void testStringRecordHandling() throws IOException { + void testStringRecordHandling() throws IOException { readRecords("53588.xls"); assertEquals(1, matches(r -> r instanceof MissingCellDummyRecord)); assertEquals(1, matches(r -> r instanceof LastCellOfRowDummyRecord)); } @Test - public void testFormulasWithStringResultsHandling() throws IOException { + void testFormulasWithStringResultsHandling() throws IOException { readRecords("53433.xls"); String exp = Modified: poi/trunk/src/testcases/org/apache/poi/hssf/extractor/TestExcelExtractor.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/extractor/TestExcelExtractor.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/extractor/TestExcelExtractor.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/extractor/TestExcelExtractor.java Fri Jan 8 23:50:02 2021 @@ -47,7 +47,7 @@ public final class TestExcelExtractor { } @Test - public void testSimple() throws IOException { + void testSimple() throws IOException { try (ExcelExtractor extractor = createExtractor("Simple.xls")) { assertEquals("Sheet1\nreplaceMe\nSheet2\nSheet3\n", extractor.getText()); @@ -58,7 +58,7 @@ public final class TestExcelExtractor { } @Test - public void testNumericFormula() throws IOException { + void testNumericFormula() throws IOException { try (ExcelExtractor extractor = createExtractor("sumifformula.xls")) { assertEquals( "Sheet1\n" + @@ -87,7 +87,7 @@ public final class TestExcelExtractor { } @Test - public void testWithContinueRecords() throws IOException { + void testWithContinueRecords() throws IOException { try (ExcelExtractor extractor = createExtractor("StringContinueRecords.xls")) { // Has masses of text // Until we fixed bug #41064, this would've @@ -97,7 +97,7 @@ public final class TestExcelExtractor { } @Test - public void testStringConcat() throws IOException { + void testStringConcat() throws IOException { try (ExcelExtractor extractor = createExtractor("SimpleWithFormula.xls")) { // Comes out as NaN if treated as a number // And as XYZ if treated as a string @@ -110,7 +110,7 @@ public final class TestExcelExtractor { } @Test - public void testStringFormula() throws IOException { + void testStringFormula() throws IOException { try (ExcelExtractor extractor = createExtractor("StringFormulas.xls")) { // Comes out as NaN if treated as a number // And as XYZ if treated as a string @@ -124,7 +124,7 @@ public final class TestExcelExtractor { @Test - public void testEventExtractor() throws Exception { + void testEventExtractor() throws Exception { // First up, a simple file with string // based formulas in it try (EventBasedExcelExtractor extractor1 = new EventBasedExcelExtractor( @@ -167,7 +167,7 @@ public final class TestExcelExtractor { } @Test - public void testWithComments() throws IOException { + void testWithComments() throws IOException { try (ExcelExtractor extractor = createExtractor("SimpleWithComments.xls")) { extractor.setIncludeSheetNames(false); @@ -191,7 +191,7 @@ public final class TestExcelExtractor { } @Test - public void testWithBlank() throws IOException { + void testWithBlank() throws IOException { try (ExcelExtractor extractor = createExtractor("MissingBits.xls")) { String def = extractor.getText(); extractor.setIncludeBlankCells(true); @@ -214,7 +214,7 @@ public final class TestExcelExtractor { } @Test - public void testFormatting() throws Exception { + void testFormatting() throws Exception { Locale userLocale = LocaleUtil.getUserLocale(); LocaleUtil.setUserLocale(Locale.ROOT); try (ExcelExtractor extractor = createExtractor("Formatting.xls")) { @@ -243,7 +243,7 @@ public final class TestExcelExtractor { * Embeded in a non-excel file */ @Test - public void testWithEmbeded() throws Exception { + void testWithEmbeded() throws Exception { POIFSFileSystem fs = null; HSSFWorkbook wbA = null, wbB = null; @@ -278,7 +278,7 @@ public final class TestExcelExtractor { * Excel embeded in excel */ @Test - public void testWithEmbededInOwn() throws Exception { + void testWithEmbededInOwn() throws Exception { POIDataSamples ssSamples = POIDataSamples.getSpreadSheetInstance(); POIFSFileSystem fs = null; HSSFWorkbook wbA = null, wbB = null; @@ -319,7 +319,7 @@ public final class TestExcelExtractor { * Test that we get text from headers and footers */ @Test - public void test45538() throws IOException { + void test45538() throws IOException { String[] files = { "45538_classic_Footer.xls", "45538_form_Footer.xls", "45538_classic_Header.xls", "45538_form_Header.xls" @@ -334,7 +334,7 @@ public final class TestExcelExtractor { } @Test - public void testPassword() throws IOException { + void testPassword() throws IOException { Biff8EncryptionKey.setCurrentUserPassword("password"); try (ExcelExtractor extractor = createExtractor("password.xls")) { String text = extractor.getText(); @@ -346,7 +346,7 @@ public final class TestExcelExtractor { } @Test - public void testNullPointerException() throws IOException { + void testNullPointerException() throws IOException { try (ExcelExtractor extractor = createExtractor("ar.org.apsme.www_Form%20Inscripcion%20Curso%20NO%20Socios.xls")) { assertNotNull(extractor); assertNotNull(extractor.getText()); @@ -354,7 +354,7 @@ public final class TestExcelExtractor { } @Test - public void test61045() throws IOException { + void test61045() throws IOException { //bug 61045. File is govdocs1 626534 try (ExcelExtractor extractor = createExtractor("61045_govdocs1_626534.xls")) { String txt = extractor.getText(); @@ -363,7 +363,7 @@ public final class TestExcelExtractor { } @Test - public void test60405a() throws IOException { + void test60405a() throws IOException { //bug 61045. File is govdocs1 626534 try (ExcelExtractor extractor = createExtractor("60405.xls")) { String txt = extractor.getText(); @@ -373,7 +373,7 @@ public final class TestExcelExtractor { } @Test - public void test60405b() throws IOException { + void test60405b() throws IOException { //bug 61045. File is govdocs1 626534 try (ExcelExtractor extractor = createExtractor("60405.xls")) { extractor.setFormulasNotResults(true); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/extractor/TestOldExcelExtractor.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/extractor/TestOldExcelExtractor.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/extractor/TestOldExcelExtractor.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/extractor/TestOldExcelExtractor.java Fri Jan 8 23:50:02 2021 @@ -53,7 +53,7 @@ public final class TestOldExcelExtractor } @Test - public void testSimpleExcel3() throws IOException { + void testSimpleExcel3() throws IOException { try (OldExcelExtractor extractor = createExtractor("testEXCEL_3.xls")) { // Check we can call getText without error @@ -79,14 +79,14 @@ public final class TestOldExcelExtractor @Test - public void testSimpleExcel3NoReading() throws IOException { + void testSimpleExcel3NoReading() throws IOException { try (OldExcelExtractor extractor = createExtractor("testEXCEL_3.xls")) { assertNotNull(extractor); } } @Test - public void testSimpleExcel4() throws IOException { + void testSimpleExcel4() throws IOException { try (OldExcelExtractor extractor = createExtractor("testEXCEL_4.xls")) { // Check we can call getText without error @@ -108,7 +108,7 @@ public final class TestOldExcelExtractor } @Test - public void testSimpleExcel5() throws IOException { + void testSimpleExcel5() throws IOException { for (String ver : new String[] {"5", "95"}) { try (OldExcelExtractor extractor = createExtractor("testEXCEL_"+ver+".xls")) { @@ -135,7 +135,7 @@ public final class TestOldExcelExtractor } @Test - public void testStrings() throws IOException { + void testStrings() throws IOException { try (OldExcelExtractor extractor = createExtractor("testEXCEL_4.xls")) { String text = extractor.getText(); @@ -155,7 +155,7 @@ public final class TestOldExcelExtractor } @Test - public void testFormattedNumbersExcel4() throws IOException { + void testFormattedNumbersExcel4() throws IOException { try (OldExcelExtractor extractor = createExtractor("testEXCEL_4.xls")) { String text = extractor.getText(); @@ -175,7 +175,7 @@ public final class TestOldExcelExtractor } @Test - public void testFormattedNumbersExcel5() throws IOException { + void testFormattedNumbersExcel5() throws IOException { for (String ver : new String[] {"5", "95"}) { try (OldExcelExtractor extractor = createExtractor("testEXCEL_"+ver+".xls")) { String text = extractor.getText(); @@ -201,7 +201,7 @@ public final class TestOldExcelExtractor } @Test - public void testFromFile() throws IOException { + void testFromFile() throws IOException { for (String ver : new String[] {"4", "5", "95"}) { String filename = "testEXCEL_"+ver+".xls"; File f = HSSFTestDataSamples.getSampleFile(filename); @@ -215,7 +215,7 @@ public final class TestOldExcelExtractor } @Test - public void testFromInputStream() throws IOException { + void testFromInputStream() throws IOException { for (String ver : new String[] {"4", "5", "95"}) { String filename = "testEXCEL_"+ver+".xls"; File f = HSSFTestDataSamples.getSampleFile(filename); @@ -230,7 +230,7 @@ public final class TestOldExcelExtractor } @Test - public void testOpenInvalidFile1() throws IOException { + void testOpenInvalidFile1() throws IOException { // a file that exists, but is a different format assertThrows(OfficeXmlFileException.class, () -> createExtractor("WithVariousData.xlsx").close()); @@ -244,13 +244,13 @@ public final class TestOldExcelExtractor } @Test - public void testOpenNonExistingFile() { + void testOpenNonExistingFile() { // a file that exists, but is a different format assertThrows(EmptyFileException.class, () -> new OldExcelExtractor(new File("notexistingfile.xls")).close()); } @Test - public void testInputStream() throws IOException { + void testInputStream() throws IOException { File file = HSSFTestDataSamples.getSampleFile("testEXCEL_3.xls"); try (InputStream stream = new FileInputStream(file); OldExcelExtractor extractor = new OldExcelExtractor(stream)) { @@ -260,7 +260,7 @@ public final class TestOldExcelExtractor } @Test - public void testInputStreamNPOIHeader() throws IOException { + void testInputStreamNPOIHeader() throws IOException { //TODO: the worksheet names are currently mangled. They're treated //as if UTF-16, but they're just ascii. Need to fix this. //Is it possible that the leading 0 byte in the worksheet name is a signal @@ -274,7 +274,7 @@ public final class TestOldExcelExtractor } @Test - public void testPOIFSFileSystem() throws IOException { + void testPOIFSFileSystem() throws IOException { File file = HSSFTestDataSamples.getSampleFile("FormulaRefs.xls"); try (POIFSFileSystem fs = new POIFSFileSystem(file); OldExcelExtractor extractor = new OldExcelExtractor(fs)){ @@ -284,7 +284,7 @@ public final class TestOldExcelExtractor } @Test - public void testDirectoryNode() throws IOException { + void testDirectoryNode() throws IOException { File file = HSSFTestDataSamples.getSampleFile("FormulaRefs.xls"); try (POIFSFileSystem fs = new POIFSFileSystem(file); OldExcelExtractor extractor = new OldExcelExtractor(fs.getRoot())) { @@ -294,7 +294,7 @@ public final class TestOldExcelExtractor } @Test - public void testDirectoryNodeInvalidFile() throws IOException { + void testDirectoryNodeInvalidFile() throws IOException { File file = POIDataSamples.getDocumentInstance().getFile("test.doc"); try (POIFSFileSystem fs = new POIFSFileSystem(file)) { assertThrows(FileNotFoundException.class, () -> new OldExcelExtractor(fs.getRoot())); @@ -302,7 +302,7 @@ public final class TestOldExcelExtractor } @Test - public void testMainUsage() { + void testMainUsage() { PrintStream save = System.err; SecurityManager sm = System.getSecurityManager(); System.setSecurityManager(new NoExitSecurityManager()); @@ -317,7 +317,7 @@ public final class TestOldExcelExtractor } @Test - public void testMain() throws IOException { + void testMain() throws IOException { File file = HSSFTestDataSamples.getSampleFile("testEXCEL_3.xls"); PrintStream save = System.out; try { @@ -333,7 +333,7 @@ public final class TestOldExcelExtractor } @Test - public void testEncryptionException() throws IOException { + void testEncryptionException() throws IOException { //test file derives from Common Crawl File file = HSSFTestDataSamples.getSampleFile("60284.xls"); @@ -345,7 +345,7 @@ public final class TestOldExcelExtractor } @Test - public void testSheetWithNoName() throws IOException { + void testSheetWithNoName() throws IOException { File file = HSSFTestDataSamples.getSampleFile("64130.xls"); try (OldExcelExtractor ex = new OldExcelExtractor(file)) { Modified: poi/trunk/src/testcases/org/apache/poi/hssf/model/TestDrawingAggregate.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/model/TestDrawingAggregate.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/model/TestDrawingAggregate.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/model/TestDrawingAggregate.java Fri Jan 8 23:50:02 2021 @@ -143,7 +143,7 @@ public class TestDrawingAggregate { */ @ParameterizedTest @MethodSource("samples") - public void testAllTestSamples(File file) throws IOException { + void testAllTestSamples(File file) throws IOException { boolean ignoreParse = true; try (HSSFWorkbook wb = HSSFTestDataSamples.openSampleWorkbook(file.getName())) { ignoreParse = false; @@ -196,7 +196,7 @@ public class TestDrawingAggregate { * when reading incomplete data ensure that the serialized bytes match the source */ @Test - public void testIncompleteData() throws IOException { + void testIncompleteData() throws IOException { //EscherDgContainer and EscherSpgrContainer length exceeds the actual length of the data String data = "H4sIAAAAAAAAAGWOOw7CQAxE32YTsSRIWSgQJSUloqSm5g4ICURBg+iBK3APGi6wBWeh9xGYbEps2WON"+ @@ -227,7 +227,7 @@ public class TestDrawingAggregate { * TODO: figure out why it fails with "RecordFormatException: 0 bytes written but getRecordSize() reports 80" */ @Test - public void testFailing() throws IOException { + void testFailing() throws IOException { try (HSSFWorkbook wb = HSSFTestDataSamples.openSampleWorkbook("15573.xls")) { HSSFSheet sh = wb.getSheetAt(0); HSSFPatriarch dp = sh.getDrawingPatriarch(); @@ -255,7 +255,7 @@ public class TestDrawingAggregate { } @Test - public void testSolverContainerMustBeSavedDuringSerialization() throws IOException{ + void testSolverContainerMustBeSavedDuringSerialization() throws IOException{ try (HSSFWorkbook wb1 = HSSFTestDataSamples.openSampleWorkbook("SolverContainerAfterSPGR.xls")) { HSSFSheet sh = wb1.getSheetAt(0); InternalSheet ish = HSSFTestHelper.getSheetForTest(sh); @@ -289,7 +289,7 @@ public class TestDrawingAggregate { } @Test - public void testFileWithTextbox() throws IOException{ + void testFileWithTextbox() throws IOException{ try (HSSFWorkbook wb = HSSFTestDataSamples.openSampleWorkbook("text.xls")) { HSSFSheet sh = wb.getSheetAt(0); InternalSheet ish = HSSFTestHelper.getSheetForTest(sh); @@ -309,7 +309,7 @@ public class TestDrawingAggregate { } @Test - public void testFileWithCharts() throws IOException { + void testFileWithCharts() throws IOException { try (HSSFWorkbook wb = HSSFTestDataSamples.openSampleWorkbook("49581.xls")) { HSSFSheet sh = wb.getSheetAt(0); InternalSheet ish = HSSFTestHelper.getSheetForTest(sh); @@ -337,7 +337,7 @@ public class TestDrawingAggregate { * test reading drawing aggregate from a test file from Bugzilla 45129 */ @Test - public void test45129() throws IOException { + void test45129() throws IOException { try (HSSFWorkbook wb = HSSFTestDataSamples.openSampleWorkbook("45129.xls")) { HSSFSheet sh = wb.getSheetAt(0); @@ -401,7 +401,7 @@ public class TestDrawingAggregate { * ... */ @Test - public void testSerializeDrawingBigger8k() throws IOException { + void testSerializeDrawingBigger8k() throws IOException { try (HSSFWorkbook wb = HSSFTestDataSamples.openSampleWorkbook("DrawingContinue.xls")) { InternalWorkbook iworkbook = HSSFTestHelper.getWorkbookForTest(wb); HSSFSheet sh = wb.getSheetAt(0); @@ -458,7 +458,7 @@ public class TestDrawingAggregate { @Test - public void testSerializeDrawingBigger8k_noAggregation() throws IOException { + void testSerializeDrawingBigger8k_noAggregation() throws IOException { try (HSSFWorkbook wb1 = HSSFTestDataSamples.openSampleWorkbook("DrawingContinue.xls")) { InternalSheet isheet = HSSFTestHelper.getSheetForTest(wb1.getSheetAt(0)); List<RecordBase> records = isheet.getRecords(); @@ -483,7 +483,7 @@ public class TestDrawingAggregate { } @Test - public void testSerializeDrawingWithComments() throws IOException { + void testSerializeDrawingWithComments() throws IOException { try (HSSFWorkbook wb = HSSFTestDataSamples.openSampleWorkbook("DrawingAndComments.xls")) { HSSFSheet sh = wb.getSheetAt(0); InternalWorkbook iworkbook = HSSFTestHelper.getWorkbookForTest(wb); @@ -539,7 +539,7 @@ public class TestDrawingAggregate { @Test - public void testFileWithPictures() throws IOException { + void testFileWithPictures() throws IOException { try (HSSFWorkbook wb = HSSFTestDataSamples.openSampleWorkbook("ContinueRecordProblem.xls")) { HSSFSheet sh = wb.getSheetAt(0); @@ -594,7 +594,7 @@ public class TestDrawingAggregate { } @Test - public void testUnhandledContinue() throws IOException { + void testUnhandledContinue() throws IOException { String data = "H4sIAAAAAAAAAO3adVRU2/4A8EPHAEOnlEooNaSUdCNIg4CUDCEtQ6gwlITSjYiSkoKA0ikg0i1IyCjS"+ "QwpSEr8B73v3PS6+9+67vz/eH+615pyz9tn71PqevT/rfGcJOIcLBtDXrNgAgBjAXcMFAAAb9SPDBAAw"+ @@ -737,7 +737,7 @@ public class TestDrawingAggregate { } @Test - public void testUnhandledContinue2() throws IOException { + void testUnhandledContinue2() throws IOException { String data = "H4sIAAAAAAAAAO3bdVRUW9sA8AGGrqFHSlpAhSEcQAkJ6UYQyaFBmiEFpCVEOiREGikJSekGlRJQuiQl"+ "FQFB4ptBvxvIvd+97/fete4f7rWYc9aZc4aZw7P3/s3zbFYB/FiEANTNeD4AAATA2sQCAADIH0wgAEAI"+ Modified: poi/trunk/src/testcases/org/apache/poi/hssf/model/TestDrawingManager2.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/model/TestDrawingManager2.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/model/TestDrawingManager2.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/model/TestDrawingManager2.java Fri Jan 8 23:50:02 2021 @@ -36,7 +36,7 @@ public final class TestDrawingManager2 { } @Test - public void testCreateDgRecord() { + void testCreateDgRecord() { EscherDgRecord dgRecord1 = drawingManager2.createDgRecord(); assertEquals( 1, dgRecord1.getDrawingGroupId() ); assertEquals( -1, dgRecord1.getLastMSOSPID() ); @@ -52,7 +52,7 @@ public final class TestDrawingManager2 { } @Test - public void testCreateDgRecordOld() { + void testCreateDgRecordOld() { // converted from TestDrawingManager(1) EscherDggRecord dgg = new EscherDggRecord(); dgg.setDrawingsSaved( 0 ); @@ -69,7 +69,7 @@ public final class TestDrawingManager2 { } @Test - public void testAllocateShapeId() { + void testAllocateShapeId() { EscherDgRecord dgRecord1 = drawingManager2.createDgRecord(); assertEquals( 1, dgg.getDrawingsSaved() ); EscherDgRecord dgRecord2 = drawingManager2.createDgRecord(); @@ -105,7 +105,7 @@ public final class TestDrawingManager2 { } @Test - public void testFindNewDrawingGroupId() { + void testFindNewDrawingGroupId() { // converted from TestDrawingManager(1) EscherDggRecord dgg = new EscherDggRecord(); dgg.setDrawingsSaved( 1 ); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/model/TestDrawingShapes.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/model/TestDrawingShapes.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/model/TestDrawingShapes.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/model/TestDrawingShapes.java Fri Jan 8 23:50:02 2021 @@ -84,7 +84,7 @@ public class TestDrawingShapes { * ----shape */ @Test - public void testDrawingGroups() throws IOException { + void testDrawingGroups() throws IOException { HSSFWorkbook wb = HSSFTestDataSamples.openSampleWorkbook("drawings.xls"); HSSFSheet sheet = wb.getSheet("groups"); HSSFPatriarch patriarch = sheet.getDrawingPatriarch(); @@ -99,7 +99,7 @@ public class TestDrawingShapes { } @Test - public void testHSSFShapeCompatibility() { + void testHSSFShapeCompatibility() { HSSFSimpleShape shape = new HSSFSimpleShape(null, new HSSFClientAnchor()); shape.setShapeType(HSSFSimpleShape.OBJECT_TYPE_LINE); assertEquals(0x08000040, shape.getLineStyleColor()); @@ -118,7 +118,7 @@ public class TestDrawingShapes { } @Test - public void testDefaultPictureSettings() { + void testDefaultPictureSettings() { HSSFPicture picture = new HSSFPicture(null, new HSSFClientAnchor()); assertEquals(picture.getLineWidth(), HSSFShape.LINEWIDTH_DEFAULT); assertEquals(picture.getFillColor(), HSSFShape.FILL__FILLCOLOR_DEFAULT); @@ -132,7 +132,7 @@ public class TestDrawingShapes { * No NullPointerException should appear */ @Test - public void testDefaultSettingsWithEmptyContainer() { + void testDefaultSettingsWithEmptyContainer() { EscherContainerRecord container = new EscherContainerRecord(); EscherOptRecord opt = new EscherOptRecord(); opt.setRecordId(EscherOptRecord.RECORD_ID); @@ -155,7 +155,7 @@ public class TestDrawingShapes { * create a rectangle, save the workbook, read back and verify that all shape properties are there */ @Test - public void testReadWriteRectangle() throws IOException { + void testReadWriteRectangle() throws IOException { HSSFWorkbook wb1 = new HSSFWorkbook(); HSSFSheet sheet = wb1.createSheet(); @@ -252,7 +252,7 @@ public class TestDrawingShapes { } @Test - public void testReadExistingImage() throws IOException { + void testReadExistingImage() throws IOException { HSSFWorkbook wb = HSSFTestDataSamples.openSampleWorkbook("drawings.xls"); HSSFSheet sheet = wb.getSheet("pictures"); HSSFPatriarch drawing = sheet.getDrawingPatriarch(); @@ -274,7 +274,7 @@ public class TestDrawingShapes { /* assert shape properties when reading shapes from a existing workbook */ @Test - public void testReadExistingRectangle() throws IOException { + void testReadExistingRectangle() throws IOException { HSSFWorkbook wb = HSSFTestDataSamples.openSampleWorkbook("drawings.xls"); HSSFSheet sheet = wb.getSheet("rectangles"); HSSFPatriarch drawing = sheet.getDrawingPatriarch(); @@ -292,7 +292,7 @@ public class TestDrawingShapes { } @Test - public void testShapeIds() throws IOException { + void testShapeIds() throws IOException { HSSFWorkbook wb1 = new HSSFWorkbook(); HSSFSheet sheet1 = wb1.createSheet(); HSSFPatriarch patriarch1 = sheet1.createDrawingPatriarch(); @@ -339,7 +339,7 @@ public class TestDrawingShapes { * File already have for 1 shape on each sheet, because document must contain EscherDgRecord for each sheet */ @Test - public void testAllocateNewIds() throws IOException { + void testAllocateNewIds() throws IOException { HSSFWorkbook wb = HSSFTestDataSamples.openSampleWorkbook("empty.xls"); HSSFSheet sheet = wb.getSheetAt(0); HSSFPatriarch patriarch = sheet.getDrawingPatriarch(); @@ -370,7 +370,7 @@ public class TestDrawingShapes { } @Test - public void testOpt() throws IOException { + void testOpt() throws IOException { HSSFWorkbook wb = new HSSFWorkbook(); // create a sheet with a text box @@ -385,7 +385,7 @@ public class TestDrawingShapes { } @Test - public void testCorrectOrderInOptRecord() throws IOException{ + void testCorrectOrderInOptRecord() throws IOException{ HSSFWorkbook wb = new HSSFWorkbook(); HSSFSheet sheet = wb.createSheet(); @@ -411,7 +411,7 @@ public class TestDrawingShapes { } @Test - public void testDgRecordNumShapes() throws IOException { + void testDgRecordNumShapes() throws IOException { HSSFWorkbook wb = new HSSFWorkbook(); HSSFSheet sheet = wb.createSheet(); HSSFPatriarch patriarch = sheet.createDrawingPatriarch(); @@ -423,7 +423,7 @@ public class TestDrawingShapes { } @Test - public void testTextForSimpleShape() throws IOException { + void testTextForSimpleShape() throws IOException { HSSFWorkbook wb1 = new HSSFWorkbook(); HSSFSheet sheet = wb1.createSheet(); HSSFPatriarch patriarch = sheet.createDrawingPatriarch(); @@ -468,7 +468,7 @@ public class TestDrawingShapes { } @Test - public void testRemoveShapes() throws IOException { + void testRemoveShapes() throws IOException { HSSFWorkbook wb1 = new HSSFWorkbook(); HSSFSheet sheet = wb1.createSheet(); HSSFPatriarch patriarch = sheet.createDrawingPatriarch(); @@ -618,7 +618,7 @@ public class TestDrawingShapes { } @Test - public void testShapeFlip() throws IOException { + void testShapeFlip() throws IOException { HSSFWorkbook wb1 = new HSSFWorkbook(); HSSFSheet sheet = wb1.createSheet(); HSSFPatriarch patriarch = sheet.createDrawingPatriarch(); @@ -662,7 +662,7 @@ public class TestDrawingShapes { } @Test - public void testRotation() throws IOException { + void testRotation() throws IOException { HSSFWorkbook wb1 = new HSSFWorkbook(); HSSFSheet sheet = wb1.createSheet(); HSSFPatriarch patriarch = sheet.createDrawingPatriarch(); @@ -691,7 +691,7 @@ public class TestDrawingShapes { @SuppressWarnings("unused") @Test - public void testShapeContainerImplementsIterable() throws IOException { + void testShapeContainerImplementsIterable() throws IOException { HSSFWorkbook wb = new HSSFWorkbook(); HSSFSheet sheet = wb.createSheet(); @@ -710,7 +710,7 @@ public class TestDrawingShapes { } @Test - public void testClearShapesForPatriarch() throws IOException { + void testClearShapesForPatriarch() throws IOException { HSSFWorkbook wb1 = new HSSFWorkbook(); HSSFSheet sheet = wb1.createSheet(); HSSFPatriarch patriarch = sheet.createDrawingPatriarch(); @@ -743,7 +743,7 @@ public class TestDrawingShapes { } @Test - public void testBug45312() throws Exception { + void testBug45312() throws Exception { try (HSSFWorkbook wb = new HSSFWorkbook()) { HSSFSheet sheet = wb.createSheet(); HSSFPatriarch patriarch = sheet.createDrawingPatriarch(); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/model/TestEscherRecordFactory.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/model/TestEscherRecordFactory.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/model/TestEscherRecordFactory.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/model/TestEscherRecordFactory.java Fri Jan 8 23:50:02 2021 @@ -56,7 +56,7 @@ public class TestEscherRecordFactory { } @Test - public void testDetectContainer() { + void testDetectContainer() { Random rnd = new Random(); assertTrue(isContainer((short) 0x0, EscherContainerRecord.DG_CONTAINER)); assertTrue(isContainer((short) 0x0, EscherContainerRecord.SOLVER_CONTAINER)); @@ -81,7 +81,7 @@ public class TestEscherRecordFactory { } @Test - public void testDgContainerMustBeRootOfHSSFSheetEscherRecords() { + void testDgContainerMustBeRootOfHSSFSheetEscherRecords() { HSSFWorkbook wb = HSSFTestDataSamples.openSampleWorkbook("47251.xls"); HSSFSheet sh = wb.getSheetAt(0); InternalSheet ish = HSSFTestHelper.getSheetForTest(sh); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/model/TestFormulaParser.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/model/TestFormulaParser.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/model/TestFormulaParser.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/model/TestFormulaParser.java Fri Jan 8 23:50:02 2021 @@ -72,35 +72,35 @@ public final class TestFormulaParser { } @Test - public void testSimpleFormula() { + void testSimpleFormula() { confirmTokenClasses("2+2",IntPtg.class, IntPtg.class, AddPtg.class); } @Test - public void testFormulaWithSpace1() { + void testFormulaWithSpace1() { confirmTokenClasses(" 2 + 2 ",IntPtg.class, IntPtg.class, AddPtg.class); } @Test - public void testFormulaWithSpace2() { + void testFormulaWithSpace2() { Ptg[] ptgs = parseFormula("2+ sum( 3 , 4) "); assertEquals(5, ptgs.length); } @Test - public void testFormulaWithSpaceNRef() { + void testFormulaWithSpaceNRef() { Ptg[] ptgs = parseFormula("sum( A2:A3 )"); assertEquals(2, ptgs.length); } @Test - public void testFormulaWithString() { + void testFormulaWithString() { Ptg[] ptgs = parseFormula("\"hello\" & \"world\" "); assertEquals(3, ptgs.length); } @Test - public void testTRUE() { + void testTRUE() { Ptg[] ptgs = parseFormula("TRUE"); assertEquals(1, ptgs.length); BoolPtg flag = (BoolPtg) ptgs[0]; @@ -108,7 +108,7 @@ public final class TestFormulaParser { } @Test - public void testSumIf() { + void testSumIf() { Ptg[] ptgs = parseFormula("SUMIF(A1:A5,\">4000\",B1:B5)"); assertEquals(4, ptgs.length); } @@ -119,14 +119,14 @@ public final class TestFormulaParser { * */ @Test - public void testNonAlphaFormula() { + void testNonAlphaFormula() { Ptg[] ptgs = parseFormula("\"TOTAL[\"&F3&\"]\""); confirmTokenClasses(ptgs, StringPtg.class, RefPtg.class, ConcatPtg.class, StringPtg.class, ConcatPtg.class); assertEquals("TOTAL[", ((StringPtg)ptgs[0]).getValue()); } @Test - public void testMacroFunction() throws IOException { + void testMacroFunction() throws IOException { // testNames.xls contains a VB function called 'myFunc' final String testFile = "testNames.xls"; try (HSSFWorkbook wb = HSSFTestDataSamples.openSampleWorkbook(testFile)) { @@ -191,19 +191,19 @@ public final class TestFormulaParser { } @Test - public void testEmbeddedSlash() { + void testEmbeddedSlash() { confirmTokenClasses("HYPERLINK(\"http://www.jakarta.org\",\"Jakarta\")", StringPtg.class, StringPtg.class, FuncVarPtg.class); } @Test - public void testConcatenate() { + void testConcatenate() { confirmTokenClasses("CONCATENATE(\"first\",\"second\")", StringPtg.class, StringPtg.class, FuncVarPtg.class); } @Test - public void testWorksheetReferences() throws IOException { + void testWorksheetReferences() throws IOException { try (HSSFWorkbook wb = new HSSFWorkbook()) { HSSFSheet sheet1 = wb.createSheet("NoQuotesNeeded"); @@ -231,12 +231,12 @@ public final class TestFormulaParser { } @Test - public void testUnaryMinus() { + void testUnaryMinus() { confirmTokenClasses("-A1", RefPtg.class, UnaryMinusPtg.class); } @Test - public void testUnaryPlus() { + void testUnaryPlus() { confirmTokenClasses("+A1", RefPtg.class, UnaryPlusPtg.class); } @@ -248,7 +248,7 @@ public final class TestFormulaParser { * check that POI follows the same encoding rules as Excel. */ @Test - public void testExactEncodingOfUnaryPlusAndMinus() { + void testExactEncodingOfUnaryPlusAndMinus() { // as tested in Excel: confirmUnary("-3", -3, NumberPtg.class); confirmUnary("--4", -4, NumberPtg.class, UnaryMinusPtg.class); @@ -278,7 +278,7 @@ public final class TestFormulaParser { } @Test - public void testLeadingSpaceInString() { + void testLeadingSpaceInString() { String value = " hi "; Ptg[] ptgs = parseFormula("\"" + value + "\""); confirmTokenClasses(ptgs, StringPtg.class); @@ -286,7 +286,7 @@ public final class TestFormulaParser { } @Test - public void testLookupAndMatchFunctionArgs() { + void testLookupAndMatchFunctionArgs() { Ptg[] ptgs = parseFormula("lookup(A1, A3:A52, B3:B52)"); confirmTokenClasses(ptgs, RefPtg.class, AreaPtg.class, AreaPtg.class, FuncVarPtg.class); assertEquals(ptgs[0].getPtgClass(), Ptg.CLASS_VALUE, "ptg0 has Value class"); @@ -298,20 +298,20 @@ public final class TestFormulaParser { /** bug 33160*/ @Test - public void testLargeInt() { + void testLargeInt() { confirmTokenClasses("40", IntPtg.class); confirmTokenClasses("40000", IntPtg.class); } /** bug 33160 */ @Test - public void testSimpleLongFormula() { + void testSimpleLongFormula() { confirmTokenClasses("40000/2", IntPtg.class, IntPtg.class, DividePtg.class); } /** bug 35027, underscore in sheet name */ @Test - public void testUnderscore() throws IOException { + void testUnderscore() throws IOException { try (HSSFWorkbook wb = new HSSFWorkbook()) { HSSFSheet sheet1 = wb.createSheet("Cash_Flow"); sheet1.createRow(0).createCell(0).setCellValue("Cash_Flow"); @@ -331,7 +331,7 @@ public final class TestFormulaParser { /** bug 49725, defined names with underscore */ @Test - public void testNamesWithUnderscore() throws IOException { + void testNamesWithUnderscore() throws IOException { HSSFWorkbook wb = new HSSFWorkbook(); //or new XSSFWorkbook(); HSSFSheet sheet = wb.createSheet("NamesWithUnderscore"); @@ -378,14 +378,14 @@ public final class TestFormulaParser { // bug 38396 : Formula with exponential numbers not parsed correctly. @Test - public void testExponentialParsing() { + void testExponentialParsing() { confirmTokenClasses("1.3E21/2", NumberPtg.class, IntPtg.class, DividePtg.class); confirmTokenClasses("1322E21/2", NumberPtg.class, IntPtg.class, DividePtg.class); confirmTokenClasses("1.3E1/2", NumberPtg.class, IntPtg.class, DividePtg.class); } @Test - public void testExponentialInSheet() throws IOException { + void testExponentialInSheet() throws IOException { HSSFWorkbook wb = new HSSFWorkbook(); wb.createSheet("Cash_Flow"); @@ -459,7 +459,7 @@ public final class TestFormulaParser { } @Test - public void testNumbers() throws IOException { + void testNumbers() throws IOException { HSSFWorkbook wb = new HSSFWorkbook(); wb.createSheet("Cash_Flow"); @@ -501,7 +501,7 @@ public final class TestFormulaParser { } @Test - public void testRanges() throws IOException { + void testRanges() throws IOException { HSSFWorkbook wb = new HSSFWorkbook(); wb.createSheet("Cash_Flow"); @@ -527,7 +527,7 @@ public final class TestFormulaParser { } @Test - public void testMultiSheetReference() throws IOException { + void testMultiSheetReference() throws IOException { HSSFWorkbook wb = new HSSFWorkbook(); wb.createSheet("Cash_Flow"); @@ -582,7 +582,7 @@ public final class TestFormulaParser { * a formula consisting of a single no-arg function got rendered without the function braces */ @Test - public void testToFormulaStringZeroArgFunction() throws IOException { + void testToFormulaStringZeroArgFunction() throws IOException { HSSFWorkbook book = new HSSFWorkbook(); Ptg[] ptgs = { @@ -594,7 +594,7 @@ public final class TestFormulaParser { } @Test - public void testPercent() { + void testPercent() { confirmTokenClasses("5%", IntPtg.class, PercentPtg.class); // spaces OK @@ -621,7 +621,7 @@ public final class TestFormulaParser { * Tests combinations of various operators in the absence of brackets */ @Test - public void testPrecedenceAndAssociativity() { + void testPrecedenceAndAssociativity() { // TRUE=TRUE=2=2 evaluates to FALSE confirmTokenClasses("TRUE=TRUE=2=2", BoolPtg.class, BoolPtg.class, EqualPtg.class, @@ -664,7 +664,7 @@ public final class TestFormulaParser { } @Test - public void testPower() { + void testPower() { confirmTokenClasses("2^5", IntPtg.class, IntPtg.class, PowerPtg.class); } @@ -677,7 +677,7 @@ public final class TestFormulaParser { } @Test - public void testParseNumber() { + void testParseNumber() { IntPtg ip; // bug 33160 @@ -697,7 +697,7 @@ public final class TestFormulaParser { } @Test - public void testMissingArgs() { + void testMissingArgs() { confirmTokenClasses("if(A1, ,C1)", RefPtg.class, AttrPtg.class, // tAttrIf @@ -713,7 +713,7 @@ public final class TestFormulaParser { } @Test - public void testParseErrorLiterals() { + void testParseErrorLiterals() { confirmParseErrorLiteral(ErrPtg.NULL_INTERSECTION, "#NULL!"); confirmParseErrorLiteral(ErrPtg.DIV_ZERO, "#DIV/0!"); @@ -744,7 +744,7 @@ public final class TestFormulaParser { } @Test - public void testParseStringLiterals_bug28754() throws IOException { + void testParseStringLiterals_bug28754() throws IOException { StringPtg sp; try { @@ -771,7 +771,7 @@ public final class TestFormulaParser { } @Test - public void testParseStringLiterals() { + void testParseStringLiterals() { confirmStringParse("goto considered harmful"); confirmStringParse("goto 'considered' harmful"); @@ -784,7 +784,7 @@ public final class TestFormulaParser { } @Test - public void testParseSumIfSum() { + void testParseSumIfSum() { String formulaString; Ptg[] ptgs; ptgs = parseFormula("sum(5, 2, if(3>2, sum(A1:A2), 6))"); @@ -797,7 +797,7 @@ public final class TestFormulaParser { } @Test - public void testParserErrors() { + void testParserErrors() { parseExpectedException(" 12 . 345 "); parseExpectedException("1 .23 "); @@ -824,7 +824,7 @@ public final class TestFormulaParser { } @Test - public void testSetFormulaWithRowBeyond32768_Bug44539() throws IOException { + void testSetFormulaWithRowBeyond32768_Bug44539() throws IOException { HSSFWorkbook wb = new HSSFWorkbook(); HSSFSheet sheet = wb.createSheet(); @@ -840,7 +840,7 @@ public final class TestFormulaParser { } @Test - public void testSpaceAtStartOfFormula() { + void testSpaceAtStartOfFormula() { // Simulating cell formula of "= 4" (note space) // The same Ptg array can be observed if an excel file is saved with that exact formula @@ -868,7 +868,7 @@ public final class TestFormulaParser { * Checks some internal error detecting logic ('stack underflow error' in toFormulaString) */ @Test - public void testTooFewOperandArgs() { + void testTooFewOperandArgs() { // Simulating badly encoded cell formula of "=/1" // Not sure if Excel could ever produce this Ptg[] ptgs = { @@ -889,7 +889,7 @@ public final class TestFormulaParser { * (e.g. COUNTIF) Excel fails to evaluate the formula, giving '#VALUE!' instead. */ @Test - public void testFuncPtgSelection() { + void testFuncPtgSelection() { Ptg[] ptgs = parseFormula("countif(A1:A2, 1)"); assertEquals(3, ptgs.length); @@ -900,7 +900,7 @@ public final class TestFormulaParser { } @Test - public void testWrongNumberOfFunctionArgs() throws IOException { + void testWrongNumberOfFunctionArgs() throws IOException { confirmArgCountMsg("sin()", "Too few arguments to function 'SIN'. Expected 1 but got 0."); confirmArgCountMsg("countif(1, 2, 3, 4)", "Too many arguments to function 'COUNTIF'. Expected 2 but got 4."); confirmArgCountMsg("index(1, 2, 3, 4, 5, 6)", "Too many arguments to function 'INDEX'. At most 4 were expected but got 6."); @@ -915,7 +915,7 @@ public final class TestFormulaParser { } @Test - public void testParseErrorExpectedMsg() { + void testParseErrorExpectedMsg() { FormulaParseException e; e = assertThrows(FormulaParseException.class, () -> parseFormula("round(3.14;2)")); confirmParseException(e, "Parse error near char 10 ';' in specified formula 'round(3.14;2)'. Expected ',' or ')'"); @@ -928,7 +928,7 @@ public final class TestFormulaParser { * this function name has a dot in it. */ @Test - public void testParseErrorTypeFunction() { + void testParseErrorTypeFunction() { Ptg[] ptgs; try { @@ -944,7 +944,7 @@ public final class TestFormulaParser { } @Test - public void testNamedRangeThatLooksLikeCell() throws IOException { + void testNamedRangeThatLooksLikeCell() throws IOException { try (HSSFWorkbook wb = new HSSFWorkbook()) { HSSFSheet sheet = wb.createSheet("Sheet1"); HSSFName name = wb.createName(); @@ -972,7 +972,7 @@ public final class TestFormulaParser { } @Test - public void testParseAreaRefHighRow_bug45358() throws IOException { + void testParseAreaRefHighRow_bug45358() throws IOException { Ptg[] ptgs; AreaI aptg; @@ -997,7 +997,7 @@ public final class TestFormulaParser { } @Test - public void testParseArray() { + void testParseArray() { Ptg[] ptgs; ptgs = parseFormula("mode({1,2,2,#REF!;FALSE,3,3,2})"); confirmTokenClasses(ptgs, ArrayPtg.class, FuncVarPtg.class); @@ -1010,7 +1010,7 @@ public final class TestFormulaParser { } @Test - public void testParseStringElementInArray() { + void testParseStringElementInArray() { Ptg[] ptgs; ptgs = parseFormula("MAX({\"5\"},3)"); confirmTokenClasses(ptgs, ArrayPtg.class, IntPtg.class, FuncVarPtg.class); @@ -1037,7 +1037,7 @@ public final class TestFormulaParser { } @Test - public void testParseArrayNegativeElement() { + void testParseArrayNegativeElement() { Ptg[] ptgs; try { ptgs = parseFormula("{-42}"); @@ -1060,7 +1060,7 @@ public final class TestFormulaParser { } @Test - public void testRangeOperator() throws IOException { + void testRangeOperator() throws IOException { HSSFWorkbook wb = new HSSFWorkbook(); HSSFSheet sheet = wb.createSheet(); @@ -1085,7 +1085,7 @@ public final class TestFormulaParser { } @Test - public void testBooleanNamedSheet() throws IOException { + void testBooleanNamedSheet() throws IOException { HSSFWorkbook wb = new HSSFWorkbook(); HSSFSheet sheet = wb.createSheet("true"); HSSFCell cell = sheet.createRow(0).createCell(0); @@ -1097,7 +1097,7 @@ public final class TestFormulaParser { } @Test - public void testParseExternalWorkbookReference() throws IOException { + void testParseExternalWorkbookReference() throws IOException { HSSFWorkbook wbA = HSSFTestDataSamples.openSampleWorkbook("multibookFormulaA.xls"); HSSFCell cell = wbA.getSheetAt(0).getRow(0).getCell(0); @@ -1129,7 +1129,7 @@ public final class TestFormulaParser { } @Test - public void testUnion() throws IOException { + void testUnion() throws IOException { String formula = "Sheet1!$B$2:$C$3,OFFSET(Sheet1!$E$2:$E$4,1,Sheet1!$A$1),Sheet1!$D$6"; HSSFWorkbook wb = new HSSFWorkbook(); wb.createSheet("Sheet1"); @@ -1157,7 +1157,7 @@ public final class TestFormulaParser { } @Test - public void testIntersection() throws IOException { + void testIntersection() throws IOException { String formula = "Sheet1!$B$2:$C$3 OFFSET(Sheet1!$E$2:$E$4, 1,Sheet1!$A$1) Sheet1!$D$6"; HSSFWorkbook wb = new HSSFWorkbook(); wb.createSheet("Sheet1"); @@ -1185,7 +1185,7 @@ public final class TestFormulaParser { } @Test - public void testComparisonInParen() { + void testComparisonInParen() { confirmTokenClasses("(A1 > B2)", RefPtg.class, RefPtg.class, @@ -1195,7 +1195,7 @@ public final class TestFormulaParser { } @Test - public void testUnionInParen() { + void testUnionInParen() { confirmTokenClasses("(A1:B2,B2:C3)", MemAreaPtg.class, AreaPtg.class, @@ -1206,7 +1206,7 @@ public final class TestFormulaParser { } @Test - public void testIntersectionInParen() { + void testIntersectionInParen() { confirmTokenClasses("(A1:B2 B2:C3)", MemAreaPtg.class, AreaPtg.class, @@ -1218,7 +1218,7 @@ public final class TestFormulaParser { // https://bz.apache.org/bugzilla/show_bug.cgi?id=60980 @Test - public void testIntersectionInFunctionArgs() { + void testIntersectionInFunctionArgs() { confirmTokenClasses("SUM(A1:B2 B2:C3)", MemAreaPtg.class, AreaPtg.class, @@ -1229,7 +1229,7 @@ public final class TestFormulaParser { } @Test - public void testIntersectionNamesInFunctionArgs() { + void testIntersectionNamesInFunctionArgs() { HSSFWorkbook wb = new HSSFWorkbook(); HSSFName name1 = wb.createName(); @@ -1252,7 +1252,7 @@ public final class TestFormulaParser { } @Test - public void testRange_bug46643() throws IOException { + void testRange_bug46643() throws IOException { String formula = "Sheet1!A1:Sheet1!B3"; HSSFWorkbook wb = new HSSFWorkbook(); wb.createSheet("Sheet1"); @@ -1276,7 +1276,7 @@ public final class TestFormulaParser { /** Named ranges with backslashes, e.g. 'POI\\2009' */ @Test - public void testBackSlashInNames() throws IOException { + void testBackSlashInNames() throws IOException { HSSFWorkbook wb = new HSSFWorkbook(); HSSFName name = wb.createName(); @@ -1301,7 +1301,7 @@ public final class TestFormulaParser { * See the related/similar test: {@link BaseTestBugzillaIssues#bug42448()} */ @Test - public void testParseAbnormalSheetNamesAndRanges_bug42448() throws IOException { + void testParseAbnormalSheetNamesAndRanges_bug42448() throws IOException { HSSFWorkbook wb = new HSSFWorkbook(); wb.createSheet("A"); try { @@ -1316,7 +1316,7 @@ public final class TestFormulaParser { } @Test - public void testRangeFuncOperand_bug46951() throws IOException { + void testRangeFuncOperand_bug46951() throws IOException { try (HSSFWorkbook wb = new HSSFWorkbook()) { Ptg[] ptgs; try { @@ -1341,7 +1341,7 @@ public final class TestFormulaParser { } @Test - public void testUnionOfFullCollFullRowRef() throws IOException { + void testUnionOfFullCollFullRowRef() throws IOException { parseFormula("3:4"); Ptg[] ptgs = parseFormula("$Z:$AC"); confirmTokenClasses(ptgs, AreaPtg.class); @@ -1378,7 +1378,7 @@ public final class TestFormulaParser { } @Test - public void testExplicitRangeWithTwoSheetNames() throws IOException { + void testExplicitRangeWithTwoSheetNames() throws IOException { HSSFWorkbook wb = new HSSFWorkbook(); wb.createSheet("Sheet1"); Ptg[] ptgs = HSSFFormulaParser.parse("Sheet1!F1:Sheet1!G2", wb); @@ -1399,7 +1399,7 @@ public final class TestFormulaParser { * and that the {@link MemFuncPtg} / {@link MemAreaPtg} is added correctly */ @Test - public void testComplexExplicitRangeEncodings() { + void testComplexExplicitRangeEncodings() { Ptg[] ptgs; ptgs = parseFormula("SUM(OFFSET(A1,0,0):B2:C3:D4:E5:OFFSET(F6,1,1):G7)"); @@ -1448,7 +1448,7 @@ public final class TestFormulaParser { * */ @Test - public void testEdgeCaseParserErrors() throws IOException { + void testEdgeCaseParserErrors() throws IOException { HSSFWorkbook wb = new HSSFWorkbook(); wb.createSheet("Sheet1"); @@ -1478,7 +1478,7 @@ public final class TestFormulaParser { * POI should also be able to parse such defined names. */ @Test - public void testParseComplexName() throws IOException { + void testParseComplexName() throws IOException { // Mock up a spreadsheet to match the critical details of the sample try (HSSFWorkbook wb = new HSSFWorkbook()) { @@ -1512,7 +1512,7 @@ public final class TestFormulaParser { * references during parsing. */ @Test - public void testZeroRowRefs() throws IOException { + void testZeroRowRefs() throws IOException { String badCellRef = "B0"; // bad because zero is not a valid row number String leadingZeroCellRef = "B000001"; // this should get parsed as "B1" HSSFWorkbook wb = new HSSFWorkbook(); @@ -1546,7 +1546,7 @@ public final class TestFormulaParser { } @Test - public void test57196_Formula() throws IOException { + void test57196_Formula() throws IOException { HSSFWorkbook wb = new HSSFWorkbook(); Ptg[] ptgs = HSSFFormulaParser.parse("DEC2HEX(HEX2DEC(O8)-O2+D2)", wb, FormulaType.CELL, -1); assertNotNull(ptgs, "Ptg array should not be null"); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/model/TestFormulaParserEval.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/model/TestFormulaParserEval.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/model/TestFormulaParserEval.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/model/TestFormulaParserEval.java Fri Jan 8 23:50:02 2021 @@ -40,7 +40,7 @@ import org.junit.jupiter.api.Test; public final class TestFormulaParserEval { @Test - public void testWithNamedRange() { + void testWithNamedRange() { HSSFWorkbook workbook = new HSSFWorkbook(); HSSFSheet s = workbook.createSheet("Foo"); @@ -76,7 +76,7 @@ public final class TestFormulaParserEval } @Test - public void testEvaluateFormulaWithRowBeyond32768_Bug44539() { + void testEvaluateFormulaWithRowBeyond32768_Bug44539() { HSSFWorkbook wb = new HSSFWorkbook(); HSSFSheet sheet = wb.createSheet(); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/model/TestFormulaParserIf.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/model/TestFormulaParserIf.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/model/TestFormulaParserIf.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/model/TestFormulaParserIf.java Fri Jan 8 23:50:02 2021 @@ -55,7 +55,7 @@ public final class TestFormulaParserIf { } @Test - public void testSimpleIf() { + void testSimpleIf() { Class<?>[] expClss = { RefPtg.class, @@ -75,7 +75,7 @@ public final class TestFormulaParserIf { } @Test - public void testSimpleIfNoFalseParam() { + void testSimpleIfNoFalseParam() { Class<?>[] expClss = { RefPtg.class, @@ -92,7 +92,7 @@ public final class TestFormulaParserIf { } @Test - public void testIfWithLargeParams() { + void testIfWithLargeParams() { Class<?>[] expClss = { RefPtg.class, @@ -123,7 +123,7 @@ public final class TestFormulaParserIf { } @Test - public void testNestedIf() { + void testNestedIf() { Class<?>[] expClss = { RefPtg.class, @@ -160,7 +160,7 @@ public final class TestFormulaParserIf { } @Test - public void testEmbeddedIf() { + void testEmbeddedIf() { Ptg[] ptgs = parseFormula("IF(3>=1,\"*\",IF(4<>1,\"first\",\"second\"))"); assertEquals(17, ptgs.length); @@ -170,14 +170,14 @@ public final class TestFormulaParserIf { } @Test - public void testSimpleLogical() { + void testSimpleLogical() { Ptg[] ptgs = parseFormula("IF(A1<A2,B1,B2)"); assertEquals(9, ptgs.length); assertEquals(LessThanPtg.class, ptgs[2].getClass(), "3rd Ptg is less than"); } @Test - public void testParenIf() { + void testParenIf() { Ptg[] ptgs = parseFormula("IF((A1+A2)<=3,\"yes\",\"no\")"); assertEquals(12, ptgs.length); assertEquals(LessEqualPtg.class, ptgs[5].getClass(), "6th Ptg is less than equal"); @@ -185,7 +185,7 @@ public final class TestFormulaParserIf { } @Test - public void testYN() { + void testYN() { Ptg[] ptgs = parseFormula("IF(TRUE,\"Y\",\"N\")"); assertEquals(7, ptgs.length); @@ -207,7 +207,7 @@ public final class TestFormulaParserIf { * Make sure the ptgs are generated properly with two functions embedded */ @Test - public void testNestedFunctionIf() { + void testNestedFunctionIf() { Ptg[] ptgs = parseFormula("IF(A1=B1,AVERAGE(A1:B1),AVERAGE(A2:B2))"); assertEquals(11, ptgs.length); @@ -219,7 +219,7 @@ public final class TestFormulaParserIf { } @Test - public void testIfSingleCondition(){ + void testIfSingleCondition(){ Ptg[] ptgs = parseFormula("IF(1=1,10)"); assertEquals(7, ptgs.length); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/model/TestHSSFAnchor.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/model/TestHSSFAnchor.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/model/TestHSSFAnchor.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/model/TestHSSFAnchor.java Fri Jan 8 23:50:02 2021 @@ -44,7 +44,7 @@ import org.junit.jupiter.api.Test; public class TestHSSFAnchor { @Test - public void testDefaultValues(){ + void testDefaultValues(){ HSSFClientAnchor clientAnchor = new HSSFClientAnchor(); assertEquals(clientAnchor.getAnchorType(), AnchorType.MOVE_AND_RESIZE); assertEquals(clientAnchor.getCol1(), 0); @@ -81,7 +81,7 @@ public class TestHSSFAnchor { } @Test - public void testCorrectOrderInSpContainer(){ + void testCorrectOrderInSpContainer(){ HSSFWorkbook wb = HSSFTestDataSamples.openSampleWorkbook("drawings.xls"); HSSFSheet sheet = wb.getSheet("pictures"); HSSFPatriarch drawing = sheet.getDrawingPatriarch(); @@ -102,7 +102,7 @@ public class TestHSSFAnchor { } @Test - public void testCreateClientAnchorFromContainer(){ + void testCreateClientAnchorFromContainer(){ EscherContainerRecord container = new EscherContainerRecord(); EscherClientAnchorRecord escher = new EscherClientAnchorRecord(); escher.setFlag((short) 3); @@ -137,7 +137,7 @@ public class TestHSSFAnchor { } @Test - public void testCreateChildAnchorFromContainer(){ + void testCreateChildAnchorFromContainer(){ EscherContainerRecord container = new EscherContainerRecord(); EscherChildAnchorRecord escher = new EscherChildAnchorRecord(); escher.setDx1((short) 15); @@ -159,7 +159,7 @@ public class TestHSSFAnchor { } @Test - public void testShapeEscherMustHaveAnchorRecord(){ + void testShapeEscherMustHaveAnchorRecord(){ HSSFWorkbook wb = new HSSFWorkbook(); HSSFSheet sheet = wb.createSheet(); @@ -178,7 +178,7 @@ public class TestHSSFAnchor { } @Test - public void testClientAnchorFromEscher(){ + void testClientAnchorFromEscher(){ EscherClientAnchorRecord escher = new EscherClientAnchorRecord(); escher.setCol1((short)11); escher.setCol2((short)12); @@ -209,7 +209,7 @@ public class TestHSSFAnchor { } @Test - public void testClientAnchorFromScratch(){ + void testClientAnchorFromScratch(){ HSSFClientAnchor anchor = new HSSFClientAnchor(); EscherClientAnchorRecord escher = (EscherClientAnchorRecord) HSSFTestHelper.getEscherAnchor(anchor); anchor.setAnchor((short)11, 12, 13, 14, (short)15, 16, 17, 18); @@ -258,7 +258,7 @@ public class TestHSSFAnchor { } @Test - public void testChildAnchorFromEscher(){ + void testChildAnchorFromEscher(){ EscherChildAnchorRecord escher = new EscherChildAnchorRecord(); escher.setDx1((short) 15); escher.setDx2((short) 16); @@ -277,7 +277,7 @@ public class TestHSSFAnchor { } @Test - public void testChildAnchorFromScratch(){ + void testChildAnchorFromScratch(){ HSSFChildAnchor anchor = new HSSFChildAnchor(); EscherChildAnchorRecord escher = (EscherChildAnchorRecord) HSSFTestHelper.getEscherAnchor(anchor); anchor.setAnchor(11, 12, 13, 14); @@ -306,7 +306,7 @@ public class TestHSSFAnchor { } @Test - public void testEqualsToSelf(){ + void testEqualsToSelf(){ HSSFClientAnchor clientAnchor = new HSSFClientAnchor(0, 1, 2, 3, (short)4, 5, (short)6, 7); assertEquals(clientAnchor, clientAnchor); @@ -315,7 +315,7 @@ public class TestHSSFAnchor { } @Test - public void testPassIncompatibleTypeIsFalse(){ + void testPassIncompatibleTypeIsFalse(){ HSSFClientAnchor clientAnchor = new HSSFClientAnchor(0, 1, 2, 3, (short)4, 5, (short)6, 7); assertNotSame(clientAnchor, "wrongType"); @@ -324,7 +324,7 @@ public class TestHSSFAnchor { } @Test - public void testNullReferenceIsFalse() { + void testNullReferenceIsFalse() { HSSFClientAnchor clientAnchor = new HSSFClientAnchor(0, 1, 2, 3, (short)4, 5, (short)6, 7); assertNotNull(clientAnchor, "Passing null to equals should return false"); @@ -333,7 +333,7 @@ public class TestHSSFAnchor { } @Test - public void testEqualsIsReflexiveIsSymmetric() { + void testEqualsIsReflexiveIsSymmetric() { HSSFClientAnchor clientAnchor1 = new HSSFClientAnchor(0, 1, 2, 3, (short)4, 5, (short)6, 7); HSSFClientAnchor clientAnchor2 = new HSSFClientAnchor(0, 1, 2, 3, (short)4, 5, (short)6, 7); @@ -348,7 +348,7 @@ public class TestHSSFAnchor { } @Test - public void testEqualsValues(){ + void testEqualsValues(){ HSSFClientAnchor clientAnchor1 = new HSSFClientAnchor(0, 1, 2, 3, (short)4, 5, (short)6, 7); HSSFClientAnchor clientAnchor2 = new HSSFClientAnchor(0, 1, 2, 3, (short)4, 5, (short)6, 7); assertEquals(clientAnchor1, clientAnchor2); @@ -423,7 +423,7 @@ public class TestHSSFAnchor { } @Test - public void testFlipped(){ + void testFlipped(){ HSSFChildAnchor child = new HSSFChildAnchor(2,2,1,1); assertTrue(child.isHorizontallyFlipped()); assertTrue(child.isVerticallyFlipped()); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/model/TestLinkTable.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/model/TestLinkTable.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/model/TestLinkTable.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/model/TestLinkTable.java Fri Jan 8 23:50:02 2021 @@ -59,7 +59,7 @@ public final class TestLinkTable { * It's not clear what exact steps need to be taken in Excel to create such a workbook */ @Test - public void testLinkTableWithoutExternalBookRecord_bug45046() { + void testLinkTableWithoutExternalBookRecord_bug45046() { // Bug 45046 b: DEFINEDNAME is part of LinkTable HSSFWorkbook wb = HSSFTestDataSamples.openSampleWorkbook("ex45046-21984.xls"); // some other sanity checks @@ -74,7 +74,7 @@ public final class TestLinkTable { } @Test - public void testMultipleExternSheetRecords_bug45698() { + void testMultipleExternSheetRecords_bug45698() { // Bug: Extern sheet is part of LinkTable HSSFWorkbook wb = HSSFTestDataSamples.openSampleWorkbook("ex45698-22488.xls"); // some other sanity checks @@ -82,7 +82,7 @@ public final class TestLinkTable { } @Test - public void testExtraSheetRefs_bug45978() { + void testExtraSheetRefs_bug45978() { HSSFWorkbook wb = HSSFTestDataSamples.openSampleWorkbook("ex45978-extraLinkTableSheets.xls"); /* ex45978-extraLinkTableSheets.xls is a cut-down version of attachment 22561. @@ -121,7 +121,7 @@ public final class TestLinkTable { * when reading the workbook of attachment 23468 from bugzilla 47001 */ @Test - public void testMissingExternSheetRecord_bug47001b() { + void testMissingExternSheetRecord_bug47001b() { Record[] recs = { SupBookRecord.createAddInFunctions(), @@ -136,7 +136,7 @@ public final class TestLinkTable { } @Test - public void testNameCommentRecordBetweenNameRecords() { + void testNameCommentRecordBetweenNameRecords() { final Record[] recs = { new NameRecord(), @@ -160,7 +160,7 @@ public final class TestLinkTable { } @Test - public void testAddNameX(){ + void testAddNameX(){ WorkbookRecordList wrl = new WorkbookRecordList(); wrl.add(0, new BOFRecord()); wrl.add(1, new CountryRecord()); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/model/TestOperandClassTransformer.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/model/TestOperandClassTransformer.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/model/TestOperandClassTransformer.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/model/TestOperandClassTransformer.java Fri Jan 8 23:50:02 2021 @@ -46,7 +46,7 @@ public final class TestOperandClassTrans } @Test - public void testMdeterm() { + void testMdeterm() { String formula = "MDETERM(ABS(A1))"; Ptg[] ptgs = parseFormula(formula); @@ -56,7 +56,7 @@ public final class TestOperandClassTrans } @Test - public void testMdetermReturnsValueInvalidOnABlankCell() { + void testMdetermReturnsValueInvalidOnABlankCell() { ValueEval matrixRef = EvalFactory.createAreaEval("A1:B2", new ValueEval[]{ BlankEval.instance, @@ -80,7 +80,7 @@ public final class TestOperandClassTrans */ @Test @Disabled - public void testIndexPi1() { + void testIndexPi1() { String formula = "INDEX(PI(),1)"; Ptg[] ptgs = parseFormula(formula); @@ -93,7 +93,7 @@ public final class TestOperandClassTrans * value operator it must get type V */ @Test - public void testDirectOperandOfValueOperator() { + void testDirectOperandOfValueOperator() { String formula = "COUNT(A1*1)"; Ptg[] ptgs = parseFormula(formula); assertNotEquals(Ptg.CLASS_REF, ptgs[0].getPtgClass()); @@ -105,7 +105,7 @@ public final class TestOperandClassTrans * A cell ref passed to a function expecting type V should be converted to type V */ @Test - public void testRtoV() { + void testRtoV() { String formula = "lookup(A1, A3:A52, B3:B52)"; Ptg[] ptgs = parseFormula(formula); @@ -113,7 +113,7 @@ public final class TestOperandClassTrans } @Test - public void testComplexIRR_bug45041() { + void testComplexIRR_bug45041() { String formula = "(1+IRR(SUMIF(A:A,ROW(INDIRECT(MIN(A:A)&\":\"&MAX(A:A))),B:B),0))^365-1"; Ptg[] ptgs = parseFormula(formula); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/model/TestRowBlocksReader.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/model/TestRowBlocksReader.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/model/TestRowBlocksReader.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/model/TestRowBlocksReader.java Fri Jan 8 23:50:02 2021 @@ -41,7 +41,7 @@ import org.junit.jupiter.api.Test; */ public final class TestRowBlocksReader { @Test - public void testAbnormalPivotTableRecords_bug46280() { + void testAbnormalPivotTableRecords_bug46280() { int SXVIEW_SID = ViewDefinitionRecord.sid; Record[] inRecs = { new RowRecord(0), Modified: poi/trunk/src/testcases/org/apache/poi/hssf/model/TestSheet.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/model/TestSheet.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/model/TestSheet.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/model/TestSheet.java Fri Jan 8 23:50:02 2021 @@ -56,7 +56,7 @@ public final class TestSheet { } @Test - public void testCreateSheet() { + void testCreateSheet() { // Check we're adding row and cell aggregates List<org.apache.poi.hssf.record.Record> records = new ArrayList<>(); records.add(BOFRecord.createSheetBOF()); @@ -105,7 +105,7 @@ public final class TestSheet { } @Test - public void testAddMergedRegion() { + void testAddMergedRegion() { InternalSheet sheet = InternalSheet.createSheet(); final int regionsToAdd = 4096; @@ -141,7 +141,7 @@ public final class TestSheet { } @Test - public void testRemoveMergedRegion() { + void testRemoveMergedRegion() { InternalSheet sheet = InternalSheet.createSheet(); int regionsToAdd = 4096; @@ -172,7 +172,7 @@ public final class TestSheet { * */ @Test - public void testMovingMergedRegion() { + void testMovingMergedRegion() { List<org.apache.poi.hssf.record.Record> records = new ArrayList<>(); CellRangeAddress[] cras = { @@ -197,12 +197,12 @@ public final class TestSheet { } // @Test - // public void testGetMergedRegionAt() { + // void testGetMergedRegionAt() { // TODO // } // @Test - // public void testGetNumMergedRegions() { + // void testGetNumMergedRegions() { // TODO // } @@ -211,7 +211,7 @@ public final class TestSheet { * */ @Test - public void testRowAggregation() { + void testRowAggregation() { List<org.apache.poi.hssf.record.Record> records = new ArrayList<>(); records.add(InternalSheet.createBOF()); @@ -235,7 +235,7 @@ public final class TestSheet { * */ @Test - public void testRowPageBreaks() { + void testRowPageBreaks() { short colFrom = 0; short colTo = 255; @@ -291,7 +291,7 @@ public final class TestSheet { * */ @Test - public void testColPageBreaks() { + void testColPageBreaks() { short rowFrom = 0; short rowTo = (short)65535; @@ -352,7 +352,7 @@ public final class TestSheet { * works as designed. */ @Test - public void testXFIndexForColumn() { + void testXFIndexForColumn() { final short TEST_IDX = 10; final short DEFAULT_IDX = 0xF; // 15 InternalSheet sheet = InternalSheet.createSheet(); @@ -422,7 +422,7 @@ public final class TestSheet { * when an <tt>UncalcedRecord</tt> was present.<p> */ @Test - public void testUncalcSize_bug45066() { + void testUncalcSize_bug45066() { List<org.apache.poi.hssf.record.Record> records = new ArrayList<>(); records.add(BOFRecord.createSheetBOF()); @@ -455,7 +455,7 @@ public final class TestSheet { * The code here represents a normal POI use case where a spreadsheet is created from scratch. */ @Test - public void testRowValueAggregatesOrder_bug45145() { + void testRowValueAggregatesOrder_bug45145() { InternalSheet sheet = InternalSheet.createSheet(); @@ -519,7 +519,7 @@ public final class TestSheet { * which in turn got the dimensions record out of alignment */ @Test - public void testGutsRecord_bug45640() { + void testGutsRecord_bug45640() { InternalSheet sheet = InternalSheet.createSheet(); sheet.addRow(new RowRecord(0)); @@ -533,7 +533,7 @@ public final class TestSheet { } @Test - public void testMisplacedMergedCellsRecords_bug45699() throws Exception { + void testMisplacedMergedCellsRecords_bug45699() throws Exception { try (HSSFWorkbook wb = HSSFTestDataSamples.openSampleWorkbook("ex45698-22488.xls")) { HSSFSheet sheet = wb.getSheetAt(0); HSSFRow row = sheet.getRow(3); @@ -546,7 +546,7 @@ public final class TestSheet { * In 3.1, setting margins between creating first row and first cell caused an exception. */ @Test - public void testSetMargins_bug45717() throws Exception { + void testSetMargins_bug45717() throws Exception { HSSFWorkbook workbook = new HSSFWorkbook(); HSSFSheet sheet = workbook.createSheet("Vorschauliste"); HSSFRow row = sheet.createRow(0); @@ -569,7 +569,7 @@ public final class TestSheet { * Excel(2007) tolerates this, so POI should too. */ @Test - public void testMissingDims() { + void testMissingDims() { int rowIx = 5; int colIx = 6; @@ -604,7 +604,7 @@ public final class TestSheet { * and since there is a slight performance hit the fix was made to avoid it. */ @Test - public void testShiftFormulasAddCondFormat_bug46547() { + void testShiftFormulasAddCondFormat_bug46547() { // Create a sheet with data validity (similar to bugzilla attachment id=23131). InternalSheet sheet = InternalSheet.createSheet(); @@ -621,7 +621,7 @@ public final class TestSheet { * which already had data validity constraints. */ @Test - public void testAddCondFormatAfterDataValidation_bug46547() { + void testAddCondFormatAfterDataValidation_bug46547() { // Create a sheet with data validity (similar to bugzilla attachment id=23131). InternalSheet sheet = InternalSheet.createSheet(); sheet.getOrCreateDataValidityTable(); @@ -632,7 +632,7 @@ public final class TestSheet { } @Test - public void testCloneMulBlank_bug46776() { + void testCloneMulBlank_bug46776() { org.apache.poi.hssf.record.Record[] recs = { InternalSheet.createBOF(), new DimensionsRecord(), @@ -654,7 +654,7 @@ public final class TestSheet { } @Test - public void testCreateAggregate() { + void testCreateAggregate() { String msoDrawingRecord1 = "0F 00 02 F0 20 01 00 00 10 00 08 F0 08 00 00 00 \n" + "03 00 00 00 02 04 00 00 0F 00 03 F0 08 01 00 00 \n" + @@ -742,7 +742,7 @@ public final class TestSheet { } @Test - public void testSheetDimensions() { + void testSheetDimensions() { InternalSheet sheet = InternalSheet.createSheet(); DimensionsRecord dimensions = (DimensionsRecord)sheet.findFirstRecordBySid(DimensionsRecord.sid); assertNotNull(dimensions); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/model/TestSheetAdditional.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/model/TestSheetAdditional.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/model/TestSheetAdditional.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/model/TestSheetAdditional.java Fri Jan 8 23:50:02 2021 @@ -25,7 +25,7 @@ import org.junit.jupiter.api.Test; public final class TestSheetAdditional { @Test - public void testGetCellWidth() { + void testGetCellWidth() { InternalSheet sheet = InternalSheet.createSheet(); ColumnInfoRecord nci = new ColumnInfoRecord(); @@ -55,7 +55,7 @@ public final class TestSheetAdditional { } @Test - public void testMaxColumnWidth() { + void testMaxColumnWidth() { InternalSheet sheet = InternalSheet.createSheet(); // the limit sheet.setColumnWidth(0, 255*256); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/model/TestWorkbook.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/model/TestWorkbook.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/model/TestWorkbook.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/model/TestWorkbook.java Fri Jan 8 23:50:02 2021 @@ -43,7 +43,7 @@ import org.junit.jupiter.api.Test; */ public final class TestWorkbook { @Test - public void testFontStuff() throws IOException { + void testFontStuff() throws IOException { HSSFWorkbook hwb = new HSSFWorkbook(); InternalWorkbook wb = TestHSSFWorkbook.getInternalWorkbook(hwb); @@ -102,7 +102,7 @@ public final class TestWorkbook { } @Test - public void testAddNameX() throws IOException { + void testAddNameX() throws IOException { HSSFWorkbook hwb = new HSSFWorkbook(); InternalWorkbook wb = TestHSSFWorkbook.getInternalWorkbook(hwb); assertNotNull(wb.getNameXPtg("ISODD", AggregatingUDFFinder.DEFAULT)); @@ -128,7 +128,7 @@ public final class TestWorkbook { } @Test - public void testRecalcId() throws IOException { + void testRecalcId() throws IOException { HSSFWorkbook wb = new HSSFWorkbook(); assertFalse(wb.getForceFormulaRecalculation()); @@ -156,7 +156,7 @@ public final class TestWorkbook { } @Test - public void testWriteAccess() { + void testWriteAccess() { HSSFWorkbook wb = new HSSFWorkbook(); InternalWorkbook iwb = TestHSSFWorkbook.getInternalWorkbook(wb); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/TestArrayRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/TestArrayRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/TestArrayRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/TestArrayRecord.java Fri Jan 8 23:50:02 2021 @@ -36,7 +36,7 @@ import org.junit.jupiter.api.Test; public final class TestArrayRecord { @Test - public void testRead() { + void testRead() { String hex = "21 02 25 00 01 00 01 00 01 01 00 00 00 00 00 00 " + "17 00 65 00 00 01 00 02 C0 02 C0 65 00 00 01 00 " + @@ -62,7 +62,7 @@ public final class TestArrayRecord { } @Test - public void testBug57231() { + void testBug57231() { HSSFWorkbook wb = HSSFTestDataSamples .openSampleWorkbook("57231_MixedGasReport.xls"); HSSFSheet sheet = wb.getSheet("master"); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/TestAutoFilterInfoRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/TestAutoFilterInfoRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/TestAutoFilterInfoRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/TestAutoFilterInfoRecord.java Fri Jan 8 23:50:02 2021 @@ -31,7 +31,7 @@ public final class TestAutoFilterInfoRec }; @Test - public void testRead() { + void testRead() { AutoFilterInfoRecord record = new AutoFilterInfoRecord(TestcaseRecordInputStream.create(AutoFilterInfoRecord.sid, data)); @@ -43,7 +43,7 @@ public final class TestAutoFilterInfoRec } @Test - public void testWrite() { + void testWrite() { AutoFilterInfoRecord record = new AutoFilterInfoRecord(); record.setNumEntries((short)3); @@ -54,7 +54,7 @@ public final class TestAutoFilterInfoRec } @Test - public void testClone() + void testClone() { AutoFilterInfoRecord record = new AutoFilterInfoRecord(); record.setNumEntries((short)3); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/TestBOFRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/TestBOFRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/TestBOFRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/TestBOFRecord.java Fri Jan 8 23:50:02 2021 @@ -28,7 +28,7 @@ import org.junit.jupiter.api.Test; public final class TestBOFRecord { @Test - public void testBOFRecord() throws IOException { + void testBOFRecord() throws IOException { // This used to throw an error before - #42794 try (HSSFWorkbook wb = HSSFTestDataSamples.openSampleWorkbook("bug_42794.xls")) { Sheet sh = wb.getSheetAt(0); --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@poi.apache.org For additional commands, e-mail: commits-h...@poi.apache.org