dennishuo commented on code in PR #165:
URL: https://github.com/apache/polaris/pull/165#discussion_r1730634417
##########
polaris-core/src/main/java/io/polaris/core/PolarisConfiguration.java:
##########
@@ -147,4 +149,36 @@ public static <T> Builder<T> builder() {
"If set to true, allows tables to have external locations
outside the default structure.")
.defaultValue(false)
.build();
+
+ public static final PolarisConfiguration<Boolean>
+ ALLOW_TABLE_LOCATION_OUTSIDE_NAMESPACE_LOCATION =
+ PolarisConfiguration.<Boolean>builder()
+ .key("ALLOW_TABLE_LOCATION_OUTSIDE_NAMESPACE_LOCATION")
+ .catalogConfig("allow.table.location.outside.namespace.location")
+ .description(
+ "If set to true, allows tables to have a location outside of
their parent namespace")
+ .defaultValue(false)
+ .build();
+
+ public static final PolarisConfiguration<Boolean>
ALLOW_TABLE_LOCATION_OUTSIDE_CATALOG_LOCATION =
+ PolarisConfiguration.<Boolean>builder()
+ .key("ALLOW_TABLE_LOCATION_OUTSIDE_CATALOG_LOCATION")
Review Comment:
One important distinction is that `ALLOWED_LOCATIONS` is a property of the
*storage config*, not necessarily of a Catalog itself; a Catalog just happens
to hold a storage config. Right now we don't have namespace-level storage
configs yet (though we might in the future).
The singular "location" of a catalog or namespace (as opposed to
ALLOWED_LOCATIONS) is semantically just the "default-location *hint*".
The options we're talking about with unstructured table location, etc., are
just about allowing going off-road from the "default hints", but in general the
list of `ALLOWED_LOCATIONS` should always be abided by.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
