adutra commented on code in PR #165:
URL: https://github.com/apache/polaris/pull/165#discussion_r1734208205
##########
polaris-core/src/main/java/org/apache/polaris/core/PolarisConfiguration.java:
##########
@@ -18,6 +18,8 @@
*/
package org.apache.polaris.core;
+import io.polaris.core.admin.model.StorageConfigInfo;
Review Comment:
Old import; should be:
```java
import org.apache.polaris.core.admin.model.StorageConfigInfo;
```
##########
polaris-core/src/main/java/org/apache/polaris/core/PolarisConfiguration.java:
##########
@@ -150,4 +152,17 @@ public static <T> Builder<T> builder() {
"If set to true, allows tables to have external locations
outside the default structure.")
.defaultValue(false)
.build();
+
+ public static final PolarisConfiguration<List<String>>
SUPPORTED_CATALOG_STORAGE_TYPES =
Review Comment:
Why not `PolarisConfiguration<List<StorageConfigInfo.StorageTypeEnum>>`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
