eric-maynard commented on code in PR #247:
URL: https://github.com/apache/polaris/pull/247#discussion_r1757665304
##########
extension/persistence/eclipselink/src/main/java/org/apache/polaris/extension/persistence/impl/eclipselink/PolarisEclipseLinkMetaStoreSessionImpl.java:
##########
@@ -280,8 +283,8 @@ public void runActionInTransaction(
LOGGER.debug("transaction committed");
}
} catch (Exception e) {
+ LOGGER.debug("Rolled back transaction due to an error", e);
tr.rollback();
Review Comment:
Agreed this is not in scope for this PR, but maybe we could consider it. As
long as we maintain transactionality, anything is ok.
However my guess is that most (99+%) of failures will be non-recoverable.
Before changing this logic, I would advocate for us collecting stats on
recoverable failures and perhaps trying to tailor the retry to only recoverable
failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
