eric-maynard commented on code in PR #247:
URL: https://github.com/apache/polaris/pull/247#discussion_r1759294192
##########
extension/persistence/eclipselink/src/main/java/org/apache/polaris/extension/persistence/impl/eclipselink/PolarisEclipseLinkStore.java:
##########
@@ -62,14 +66,22 @@ public PolarisEclipseLinkStore(@NotNull PolarisDiagnostics
diagnostics) {
this.diagnosticServices = diagnostics;
}
+ /** Initialize the store. This should be called before other methods. */
+ public void initialize(EntityManager session) {
+ PolarisSequenceManager.initialize(session);
+ initialized.set(true);
+ }
Review Comment:
Yes, it is needed. We need to initialize here so that if the POLARIS_SEQ
check is going to fail, it does so outside the context of a transaction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
